Adjusting too many redirections problem in subject

Zambom
1 parent 428ed258
Showing 2 changed files with 41 additions and 65 deletions Show diff stats
amadeus/permissions.py
subjects/views.py
 # File used to store functions to handle permissions
+from categories.models import Category
 from subjects.models import Subject
 from topics.models import Resource
 """
 	Function to know if a user has permission to:
+		- Edit Category
+		- Delete Category
+		- Create Subject
+		- Replicate Subject
+"""
+def has_category_permissions(user, category):
+	if user.is_staff:
+		return True
+
+	if category.coordinators.filter(id = user.id).exists():
+		return True
+
+	return False
+
+"""
+	Function to know if a user has permission to:
 		- Edit Subject
 		- Delete Subject
 		- Create Topic inside Subject 
@@ -30,6 +30,7 @@ from .utils import has_student_profile, has_professor_profile, count_subjects, g
 from users.models import User
 from topics.models import Resource
+from amadeus.permissions import has_category_permissions, has_subject_permissions, has_subject_view_permissions
 class HomeView(LoginRequiredMixin, ListView):
     login_url = reverse_lazy("users:login")
@@ -234,32 +235,19 @@ class SubjectCreateView(LoginRequiredMixin, LogMixin, CreateView):
     success_url = reverse_lazy('subject:index')
     def dispatch(self, request, *args, **kwargs):
-        user = request.user
-        pk = user.pk 
-        
         if kwargs.get('subject_slug'):
-            subject = Subject.objects.filter((Q(professor__pk=pk) | Q(category__coordinators__pk=pk)) & Q(slug = kwargs.get('subject_slug')))
-            if not user.is_staff:
-                if subject.count() == 0:
-                    if request.META.get('HTTP_REFERER'):
-                        return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-                    else:
-                        return redirect('subjects:index')
-    
+            subject = get_object_or_404(Subject, slug = kwargs.get('subject_slug', ''))
+            
+            if not has_category_permissions(request.user, subject.category):
+                return redirect(reverse_lazy('subjects:home'))
         if kwargs.get('slug'):
-            if not user.is_staff:
-                category = Category.objects.filter(Q(coordinators__pk=pk) & Q(slug= kwargs.get('slug')))
-                if category.count() == 0:
-                        if request.META.get('HTTP_REFERER'):
-                            return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-                        else:
-                            return redirect('subjects:index')               
-        if request.method.lower() in self.http_method_names:
-            handler = getattr(self, request.method.lower(), self.http_method_not_allowed)
-        else:
-            handler = self.http_method_not_allowed
-        return handler(request, *args, **kwargs)
+            category = get_object_or_404(Category, slug = kwargs.get('slug', ''))
+
+            if not has_category_permissions(request.user, category):
+                return redirect(reverse_lazy('subjects:home'))
+            
+        return super(SubjectCreateView, self).dispatch(request, *args, **kwargs)
     def get_initial(self):
@@ -357,23 +345,12 @@ class SubjectUpdateView(LoginRequiredMixin, LogMixin, UpdateView):
     redirect_field_name = 'next'
     def dispatch(self, request, *args, **kwargs):
-        user = self.request.user
+        subject = get_object_or_404(Subject, slug = kwargs.get('slug', ''))
-        pk = user.pk
-
-        subject = Subject.objects.filter((Q(professor__pk=pk) | Q(category__coordinators__pk=pk)) & Q(slug = kwargs.get('slug')))
-        if not user.is_staff:
-            if subject.count() == 0:
-                if request.META.get('HTTP_REFERER'):
-                    return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-                else:
-                    return redirect('subjects:index')
+        if not has_subject_permissions(request.user, subject):
+            return redirect(reverse_lazy('subjects:home'))
-        if request.method.lower() in self.http_method_names:
-            handler = getattr(self, request.method.lower(), self.http_method_not_allowed)
-        else:
-            handler = self.http_method_not_allowed
-        return handler(request, *args, **kwargs)
+        return super(SubjectUpdateView, self).dispatch(request, *args, **kwargs)
     def get_context_data(self, **kwargs):
         context = super(SubjectUpdateView, self).get_context_data(**kwargs)
@@ -413,17 +390,11 @@ class SubjectDeleteView(LoginRequiredMixin, LogMixin, DeleteView):
     template_name = 'subjects/delete.html'
     def dispatch(self, request, *args, **kwargs):
-        user = self.request.user
+        subject = get_object_or_404(Subject, slug = kwargs.get('slug', ''))
-        pk = user.pk
-
-        subject = Subject.objects.filter((Q(professor__pk=pk) | Q(category__coordinators__pk=pk)) & Q(slug = kwargs.get('slug')))
-        if not user.is_staff:
-            if subject.count() == 0:
-                if request.META.get('HTTP_REFERER'):
-                    return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-                else:
-                    return redirect('subjects:index')
+        if not has_subject_permissions(request.user, subject):
+            return redirect(reverse_lazy('subjects:home'))
+
         return super(SubjectDeleteView, self).dispatch(request, *args, **kwargs)
     def get(self, request, *args, **kwargs):
@@ -480,24 +451,12 @@ class SubjectDetailView(LoginRequiredMixin, LogMixin, DetailView):
     context_object_name = 'subject'
     def dispatch(self, request, *args,**kwargs):
-        user = request.user
-        pk = user.pk
-        if kwargs.get('slug') and not user.is_staff:
-            subject = get_object_or_404(Subject, slug = kwargs.get('slug'))
+        subject = get_object_or_404(Subject, slug = kwargs.get('slug', ''))
-            subject = Subject.objects.filter((Q(students__pk=pk) | Q(professor__pk=pk) | Q(category__coordinators__pk=pk)) & Q(slug = kwargs.get('slug')))
-            
-            if subject.count() == 0:
-                if request.META.get('HTTP_REFERER'):
-                    return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-                else:
-                    return redirect('subjects:home')
-                            
-        if request.method.lower() in self.http_method_names:
-            handler = getattr(self, request.method.lower(), self.http_method_not_allowed)
-        else:
-            handler = self.http_method_not_allowed
-        return handler(request, *args, **kwargs)
+        if not has_subject_view_permissions(request.user, subject):
+            return redirect(reverse_lazy('subjects:home'))
+
+        return super(SubjectDetailView, self).dispatch(request, *args, **kwargs)
     def get_context_data(self, **kwargs):
         context = super(SubjectDetailView, self).get_context_data(**kwargs)
1	# File used to store functions to handle permissions	1	# File used to store functions to handle permissions
2		2
		3	+from categories.models import Category
3	from subjects.models import Subject	4	from subjects.models import Subject
4	from topics.models import Resource	5	from topics.models import Resource
5		6
6	"""	7	"""
7	Function to know if a user has permission to:	8	Function to know if a user has permission to:
		9	+ - Edit Category
		10	+ - Delete Category
		11	+ - Create Subject
		12	+ - Replicate Subject
		13	+"""
		14	+def has_category_permissions(user, category):
		15	+ if user.is_staff:
		16	+ return True
		17	+
		18	+ if category.coordinators.filter(id = user.id).exists():
		19	+ return True
		20	+
		21	+ return False
		22	+
		23	+"""
		24	+ Function to know if a user has permission to:
8	- Edit Subject	25	- Edit Subject
9	- Delete Subject	26	- Delete Subject
10	- Create Topic inside Subject	27	- Create Topic inside Subject