rails4: fix more unit tests

Braulio Bhavamitra
1 parent 3c57da65
Showing 18 changed files with 91 additions and 67 deletions Show diff stats
app/models/create_enterprise.rb
app/models/domain.rb
app/models/image.rb
app/models/person_notifier.rb
app/models/profile.rb
app/views/person_notifier/mailer/content_summary.html.erb
config/initializers/dependencies.rb
lib/noosfero/core_ext/array.rb
test/unit/array_core_ext_test.rb
test/unit/block_test.rb
test/unit/create_enterprise_test.rb
test/unit/domain_test.rb
test/unit/organization_mailing_test.rb
test/unit/person_notifier_test.rb
test/unit/product_test.rb
test/unit/profile_test.rb
test/unit/tags_block_test.rb
vendor/plugins/monkey_patches/attachment_fu/init.rb
@@ -22,7 +22,7 @@ class CreateEnterprise &lt; Task
   #checks if the validation method is region to validates
   validates_presence_of :region_id, :if => lambda { |obj| obj.environment.organization_approval_method == :region }
-  validates_format_of :foundation_year, :with => /\d*/
+  validates_numericality_of :foundation_year, only_integer: true
   # checks for actual attributes
   validates_presence_of :requestor_id, :target_id
@@ -14,7 +14,7 @@ class Domain &lt; ActiveRecord::Base
   # <tt>name</tt> must be sequences of alphanumeric characters (a to z,
   # 0 to 9), plus '_' or '-', separated by dots. Letters must be lowercase.
-  validates_format_of :name, :with => /([a-z0-9_-]+\.)+[a-z0-9_-]+/, :message => N_('{fn} must be composed of sequences of lowercase letters (a to z), numbers (0 to 9), "_" and "-", separated by dots.').fix_i18n
+  validates_format_of :name, with: /\A([a-z0-9_-]+\.)+[a-z0-9_-]+\z/, message: N_('{fn} must be composed of sequences of lowercase letters (a to z), numbers (0 to 9), "_" and "-", separated by dots.').fix_i18n
   # checks validations that could not be expressed using Rails' predefined
   # validations. In particular:
 class Image < ActiveRecord::Base
+  attr_accessible :uploaded_data, :label
+
   def self.max_size
     Image.attachment_options[:max_size]
   end
@@ -24,8 +26,6 @@ class Image &lt; ActiveRecord::Base
   postgresql_attachment_fu
-  attr_accessible :uploaded_data, :label
-
   def current_data
     File.file?(full_filename) ? File.read(full_filename) : nil
   end
+# FIXME needed by test/units/application_helper.rb
+require_dependency 'application_helper'
+
 class PersonNotifier
   def initialize(person)
@@ -76,7 +79,7 @@ class PersonNotifier
   class Mailer < ActionMailer::Base
-    add_template_helper(ApplicationHelper)
+    helper ApplicationHelper
     def session
       {:theme => nil}
@@ -93,7 +96,7 @@ class PersonNotifier
       @recipient = @profile.nickname || @profile.name
       @notifications = notifications
       @tasks = tasks
-      @environment = @profile.environment.name
+      @environment = @profile.environment
       @url = @profile.environment.top_url
       mail(
         content_type: "text/html",
@@ -98,7 +98,9 @@ class Profile &lt; ActiveRecord::Base
     where((Community.send(:subclasses).map(&:name) << 'Community').map { |klass| "profiles.type = '#{klass}'"}.join(" OR "))
   }
   scope :templates, -> (template_id = nil) {
-    if template_id then where id: template_id else where is_template: true end
+    s = where is_template: true
+    s = s.where id: template_id if template_id
+    s
   }
   scope :with_templates, -> (templates) {
@@ -25,7 +25,7 @@
           <% @notifications.each do |activity| %>
               <div style="border-bottom:1px solid #e2e2e2;padding:15px 0;width:600px">
               <table style="width:100%;">
-                <%= render :partial => activity.verb, :locals => { :activity => activity } rescue "cannot render notification for #{activity.verb}" %>
+                <%= render activity.verb, activity: activity %>
               </table>
             </div>
           <% end %>
@@ -6,7 +6,7 @@ require &#39;will_paginate/array&#39;
 require 'nokogiri'
 # dependencies at vendor, firstly loaded on Gemfile
-vendor = (Dir.glob('vendor/{,plugins/}*') - ['vendor/plugins'])
+vendor = Dir.glob('vendor/{,plugins/}*') - ['vendor/plugins']
 vendor.each do |dir|
   init_rb = "#{Rails.root}/#{dir}/init.rb"
   require init_rb if File.file? init_rb
@@ -24,3 +24,4 @@ require &#39;set_profile_region_from_city_state&#39;
 require 'authenticated_system'
 require 'needs_profile'
 require 'white_list_filter'
+
@@ -1,9 +0,0 @@
-class Array
-
-  def uniq_by
-    hash, array = {}, []
-    each { |i| hash[yield(i)] ||= (array << i) }
-    array
-  end
-
-end
@@ -1,11 +0,0 @@
-require_relative "../test_helper"
-
-# tests for Array core extension. See lib/noosfero/core_ext/array.rb
-class StringCoreExtTest < ActiveSupport::TestCase
-
-  should 'allow uniq by a block' do
-    array = [0,1,2,3,4,5,6]
-    assert_equal [0,1], array.uniq_by {|number| number%2 }
-  end
-
-end
@@ -248,7 +248,8 @@ class BlockTest &lt; ActiveSupport::TestCase
   should 'generate embed code' do
     b = Block.new
     b.stubs(:url_for).returns('http://myblogtest.com/embed/block/1')
-    assert_equal "<iframe class=\"embed block block\" frameborder=\"0\" height=\"768\" src=\"http://myblogtest.com/embed/block/1\" width=\"1024\"></iframe>", b.embed_code.call
+    assert_equal "<iframe class=\"embed block block\" frameborder=\"0\" height=\"768\" src=\"http://myblogtest.com/embed/block/1\" width=\"1024\"></iframe>",
+      b.embed_code.call
   end
   should 'default value for display_user is all' do
@@ -15,18 +15,18 @@ class CreateEnterpriseTest &lt; ActiveSupport::TestCase
       assert task.respond_to?("#{field}=")
     end
   end
-  
+
   should 'accept only numbers as foundation year' do
     task = CreateEnterprise.new
     task.stubs(:environment).returns(Environment.default)
     task.foundation_year = "test"
     task.valid?
-    assert task.errors[:foundation_year.to_s].present?
+    assert task.errors[:foundation_year].present?
     task.foundation_year = 2006
     task.valid?
-    assert !task.errors[:foundation_year.to_s].present?
+    assert !task.errors[:foundation_year].present?
   end
   should 'require a requestor' do
@@ -65,7 +65,7 @@ class CreateEnterpriseTest &lt; ActiveSupport::TestCase
     task.valid?
     assert task.errors[:target.to_s].present?
-    
+
     region.validators << validator
     task.valid?
@@ -10,37 +10,37 @@ class DomainTest &lt; ActiveSupport::TestCase
   should 'not allow domains without name' do
     domain = Domain.new
     domain.valid?
-    assert domain.errors[:name.to_s].present?
+    assert domain.errors[:name].present?
   end
   should 'not allow domain without dot' do
     domain = build(Domain, :name => 'test')
     domain.valid?
-    assert domain.errors[:name.to_s].present?
+    assert domain.errors[:name].present?
   end
   should 'allow domains with dot' do
     domain = build(Domain, :name => 'test.org')
     domain.valid?
-    assert !domain.errors[:name.to_s].present?
+    assert !domain.errors[:name].present?
   end
   should 'not allow domains with upper cased letters' do
     domain = build(Domain, :name => 'tEst.org')
     domain.valid?
-    assert domain.errors[:name.to_s].present?
+    assert domain.errors[:name].present?
   end
   should 'allow domains with hyphen' do
     domain = build(Domain, :name => 'test-domain.org')
     domain.valid?
-    assert !domain.errors[:name.to_s].present?
+    assert !domain.errors[:name].present?
   end
   should 'allow domains with underscore' do
     domain = build(Domain, :name => 'test_domain.org')
     domain.valid?
-    assert !domain.errors[:name.to_s].present?
+    assert !domain.errors[:name].present?
   end
   def test_owner
@@ -59,11 +59,11 @@ class DomainTest &lt; ActiveSupport::TestCase
     d = Domain.new
     d.name = 'www.example.net'
     d.valid?
-    assert d.errors[:name.to_s].present?, "Name should not accept www."
+    assert d.errors[:name].present?, "Name should not accept www."
     d.name = 'example.net'
     d.valid?
-    assert !d.errors[:name.to_s].present?
+    assert !d.errors[:name].present?
   end
   def test_find_by_name
@@ -82,7 +82,7 @@ class DomainTest &lt; ActiveSupport::TestCase
     d = build(Domain, :name => 'example.net')
     assert !d.valid?
-    assert d.errors[:name.to_s].present?
+    assert d.errors[:name].present?
   end
   def test_environment
@@ -57,7 +57,7 @@ class OrganizationMailingTest &lt; ActiveSupport::TestCase
   should 'return url for organization on url' do
     mailing = build(OrganizationMailing, :source => community)
-    assert_equal "#{community.environment.top_url}/#{community.name.to_slug}/", mailing.url
+    assert_equal "#{community.environment.top_url}/#{community.name.to_slug}", mailing.url
   end
   should 'deliver mailing to each member after create' do
 require_relative "../test_helper"
 class PersonNotifierTest < ActiveSupport::TestCase
+
   FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures'
   CHARSET = "utf-8"
@@ -19,7 +20,6 @@ class PersonNotifierTest &lt; ActiveSupport::TestCase
     @community.add_member(@admin)
     @article = fast_create(TextileArticle, :name => 'Article test', :profile_id => @community.id, :notify_comments => false)
     Delayed::Job.delete_all
-    notify
     ActionMailer::Base.deliveries = []
   end
@@ -157,28 +157,30 @@ class PersonNotifierTest &lt; ActiveSupport::TestCase
     process_delayed_job_queue
     notify
     sent = ActionMailer::Base.deliveries.last
-    assert_match /cannot render notification for some_invalid_verb/, sent.body.to_s
+    # don't raise erros
   end
   ActionTrackerConfig.verb_names.each do |verb|
     should "render notification for verb #{verb}" do
-      action = mock()
-      action.stubs(:verb).returns(verb)
-      action.stubs(:user).returns(@member)
-      action.stubs(:created_at).returns(DateTime.now)
-      action.stubs(:target).returns(fast_create(Forum))
-      action.stubs(:comments_count).returns(0)
-      action.stubs(:comments).returns([])
-      action.stubs(:params).returns({'name' => 'home', 'url' => '/', 'lead' => ''})
-      action.stubs(:get_url).returns('')
-
-      notifications = []
-      notifications.stubs(:find).returns([action])
-      Person.any_instance.stubs(:tracked_notifications).returns(notifications)
+      @member.tracked_notifications = []
+
+      a = @member.tracked_notifications.build
+      a.verb = verb
+      a.user = @member
+      a.created_at = @member.notifier.notify_from + 1.day
+      a.target = fast_create(Forum)
+      a.comments_count = 0
+      a.params = {'view_url'=> {}, 'name' => 'home', 'url' => '/', 'lead' => ''}
+      a.get_url = ''
+      a.save!
+      n = @member.action_tracker_notifications.build
+      n.action_tracker = a
+      n.profile = @member
+      n.save!
       notify
       sent = ActionMailer::Base.deliveries.last
-      assert_no_match /cannot render notification for #{verb}/, sent.body.to_s
+      # assert not raised
     end
   end
@@ -178,7 +178,7 @@ class ProductTest &lt; ActiveSupport::TestCase
     product.valid?
     assert_no_match /[<>]/, product.name
-    assert_no_match /[<>]/, product.description
+    assert_match /<h1>&gt;&gt; &gt;&gt; html &gt;<\/h1>/, product.description
   end
   should 'use name of category when has no name yet' do
@@ -457,7 +457,7 @@ class ProfileTest &lt; ActiveSupport::TestCase
     p1 = create(Profile, :public_profile => true)
     p2 = create(Profile, :public_profile => true, :secret => true)
-    result = Profile.public
+    result = Profile.is_public
     assert_includes result, p1
     assert_not_includes result, p2
   end
@@ -921,6 +921,7 @@ class ProfileTest &lt; ActiveSupport::TestCase
   should 'copy communities from person template' do
     template = create_user('test_template').person
+    template.is_template = true
     Environment.any_instance.stubs(:person_default_template).returns(template)
     c1 = fast_create(Community)
@@ -1395,6 +1396,7 @@ class ProfileTest &lt; ActiveSupport::TestCase
     template = create_user('test_template').person
     template.custom_footer = "footer customized"
     template.custom_header = "header customized"
+    template.is_template = true
     Environment.any_instance.stubs(:person_default_template).returns(template)
     person = create_user_full('mytestuser').person
@@ -1450,7 +1452,7 @@ class ProfileTest &lt; ActiveSupport::TestCase
     assert_equal [t2], environment.profiles.templates(t2)
   end
-  should 'not return a template when and invalid template is specified' do
+  should 'not return a template when a non template is specified' do
     environment = Environment.default
     t1 = fast_create(Profile, :is_template => true)
     t2 = fast_create(Profile, :is_template => true)
@@ -38,10 +38,10 @@ class TagsBlockTest &lt; ActiveSupport::TestCase
     box = create(Box, :owner => Environment.default)
     @block = create(TagsBlock, :box => box)
-    assert_match /\/tag\/first-tag" [^>]+"3 items"/,  block.content
-    assert_match /\/tag\/second-tag" [^>]+"3 items"/, block.content
-    assert_match /\/tag\/third-tag" [^>]+"one item"/, block.content
-    assert_match /\/tag\/other-tag" [^>]+"2 items"/,  block.content
+    assert_match /3 items[^>]+\/tag\/first-tag/,  block.content
+    assert_match /3 items[^>]+\/tag\/second-tag/, block.content
+    assert_match /one item[^>]+\/tag\/third-tag/, block.content
+    assert_match /2 item[^>]+\/tag\/other-tag"/,  block.content
   end
   should 'return (none) when no tags to display' do
 # Monkey patch to rewrite attachment_fu's logic where no image with parent can
 # be thumbnailable.
+require_dependency 'technoweenie/attachment_fu'
+
 Technoweenie::AttachmentFu::InstanceMethods.module_eval do
   def thumbnailable?
     image? && !is_thumbnail?
@@ -24,3 +26,34 @@ Technoweenie::AttachmentFu::Backends::FileSystemBackend.module_eval do
   end
 end
+# https://github.com/pothoven/attachment_fu/pull/14
+# remove on 3.2.16
+Technoweenie::AttachmentFu::InstanceMethods.module_eval do
+  # Creates or updates the thumbnail for the current attachment.
+  def create_or_update_thumbnail(temp_file, file_name_suffix, *size)
+    thumbnailable? || raise(ThumbnailError.new("Can't create a thumbnail if the content type is not an image or there is no parent_id column"))
+    find_or_initialize_thumbnail(file_name_suffix).tap do |thumb|
+      thumb.temp_paths.unshift temp_file
+      attributes = {
+        content_type:             content_type,
+        filename:                 thumbnail_name_for(file_name_suffix),
+        thumbnail_resize_options: size
+      }
+      attributes.each{ |a, v| thumb.send "#{a}=", v }
+      callback_with_args :before_thumbnail_saved, thumb
+      thumb.save!
+    end
+  end
+
+  # Initializes a new thumbnail with the given suffix.
+  def find_or_initialize_thumbnail(file_name_suffix)
+    attrs = {thumbnail: file_name_suffix.to_s}
+    attrs[:parent_id] = id if respond_to? :parent_id
+    thumb = thumbnail_class.where(attrs).first
+    unless thumb
+      thumb = thumbnail_class.new
+      attrs.each{ |a, v| thumb[a] = v }
+    end
+    thumb
+  end
+end
	@@ -22,7 +22,7 @@ class CreateEnterprise < Task		@@ -22,7 +22,7 @@ class CreateEnterprise < Task
22	#checks if the validation method is region to validates	22	#checks if the validation method is region to validates
23	validates_presence_of :region_id, :if => lambda { \|obj\| obj.environment.organization_approval_method == :region }	23	validates_presence_of :region_id, :if => lambda { \|obj\| obj.environment.organization_approval_method == :region }
24		24
25	- validates_format_of :foundation_year, :with => /\d*/	25	+ validates_numericality_of :foundation_year, only_integer: true
26		26
27	# checks for actual attributes	27	# checks for actual attributes
28	validates_presence_of :requestor_id, :target_id	28	validates_presence_of :requestor_id, :target_id
	@@ -14,7 +14,7 @@ class Domain < ActiveRecord::Base		@@ -14,7 +14,7 @@ class Domain < ActiveRecord::Base
14		14
15	# <tt>name</tt> must be sequences of alphanumeric characters (a to z,	15	# <tt>name</tt> must be sequences of alphanumeric characters (a to z,
16	# 0 to 9), plus '_' or '-', separated by dots. Letters must be lowercase.	16	# 0 to 9), plus '_' or '-', separated by dots. Letters must be lowercase.
17	- validates_format_of :name, :with => /([a-z0-9_-]+\.)+[a-z0-9_-]+/, :message => N_('{fn} must be composed of sequences of lowercase letters (a to z), numbers (0 to 9), "_" and "-", separated by dots.').fix_i18n	17	+ validates_format_of :name, with: /\A([a-z0-9_-]+\.)+[a-z0-9_-]+\z/, message: N_('{fn} must be composed of sequences of lowercase letters (a to z), numbers (0 to 9), "_" and "-", separated by dots.').fix_i18n
18		18
19	# checks validations that could not be expressed using Rails' predefined	19	# checks validations that could not be expressed using Rails' predefined
20	# validations. In particular:	20	# validations. In particular:
	@@ -25,7 +25,7 @@		@@ -25,7 +25,7 @@
25	<% @notifications.each do \|activity\| %>	25	<% @notifications.each do \|activity\| %>
26	<div style="border-bottom:1px solid #e2e2e2;padding:15px 0;width:600px">	26	<div style="border-bottom:1px solid #e2e2e2;padding:15px 0;width:600px">
27	<table style="width:100%;">	27	<table style="width:100%;">
28	- <%= render :partial => activity.verb, :locals => { :activity => activity } rescue "cannot render notification for #{activity.verb}" %>	28	+ <%= render activity.verb, activity: activity %>
29	</table>	29	</table>
30	</div>	30	</div>
31	<% end %>	31	<% end %>
	@@ -1,9 +0,0 @@	@@ -1,9 +0,0 @@
1	-class Array
2	-
3	- def uniq_by
4	- hash, array = {}, []
5	- each { \|i\| hash[yield(i)] \|\|= (array << i) }
6	- array
7	- end
8	-
9	-end
	@@ -1,11 +0,0 @@	@@ -1,11 +0,0 @@
1	-require_relative "../test_helper"
2	-
3	-# tests for Array core extension. See lib/noosfero/core_ext/array.rb
4	-class StringCoreExtTest < ActiveSupport::TestCase
5	-
6	- should 'allow uniq by a block' do
7	- array = [0,1,2,3,4,5,6]
8	- assert_equal [0,1], array.uniq_by {\|number\| number%2 }
9	- end
10	-
11	-end
	@@ -15,18 +15,18 @@ class CreateEnterpriseTest < ActiveSupport::TestCase		@@ -15,18 +15,18 @@ class CreateEnterpriseTest < ActiveSupport::TestCase
15	assert task.respond_to?("#{field}=")	15	assert task.respond_to?("#{field}=")
16	end	16	end
17	end	17	end
18	-	18	+
19	should 'accept only numbers as foundation year' do	19	should 'accept only numbers as foundation year' do
20	task = CreateEnterprise.new	20	task = CreateEnterprise.new
21	task.stubs(:environment).returns(Environment.default)	21	task.stubs(:environment).returns(Environment.default)
22		22
23	task.foundation_year = "test"	23	task.foundation_year = "test"
24	task.valid?	24	task.valid?
25	- assert task.errors[:foundation_year.to_s].present?	25	+ assert task.errors[:foundation_year].present?
26		26
27	task.foundation_year = 2006	27	task.foundation_year = 2006
28	task.valid?	28	task.valid?
29	- assert !task.errors[:foundation_year.to_s].present?	29	+ assert !task.errors[:foundation_year].present?
30	end	30	end
31		31
32	should 'require a requestor' do	32	should 'require a requestor' do
	@@ -65,7 +65,7 @@ class CreateEnterpriseTest < ActiveSupport::TestCase		@@ -65,7 +65,7 @@ class CreateEnterpriseTest < ActiveSupport::TestCase
65		65
66	task.valid?	66	task.valid?
67	assert task.errors[:target.to_s].present?	67	assert task.errors[:target.to_s].present?
68	-	68	+
69	region.validators << validator	69	region.validators << validator
70		70
71	task.valid?	71	task.valid?
	@@ -10,37 +10,37 @@ class DomainTest < ActiveSupport::TestCase		@@ -10,37 +10,37 @@ class DomainTest < ActiveSupport::TestCase
10	should 'not allow domains without name' do	10	should 'not allow domains without name' do
11	domain = Domain.new	11	domain = Domain.new
12	domain.valid?	12	domain.valid?
13	- assert domain.errors[:name.to_s].present?	13	+ assert domain.errors[:name].present?
14	end	14	end
15		15
16	should 'not allow domain without dot' do	16	should 'not allow domain without dot' do
17	domain = build(Domain, :name => 'test')	17	domain = build(Domain, :name => 'test')
18	domain.valid?	18	domain.valid?
19	- assert domain.errors[:name.to_s].present?	19	+ assert domain.errors[:name].present?
20	end	20	end
21		21
22	should 'allow domains with dot' do	22	should 'allow domains with dot' do
23	domain = build(Domain, :name => 'test.org')	23	domain = build(Domain, :name => 'test.org')
24	domain.valid?	24	domain.valid?
25	- assert !domain.errors[:name.to_s].present?	25	+ assert !domain.errors[:name].present?
26	end	26	end
27		27
28	should 'not allow domains with upper cased letters' do	28	should 'not allow domains with upper cased letters' do
29	domain = build(Domain, :name => 'tEst.org')	29	domain = build(Domain, :name => 'tEst.org')
30	domain.valid?	30	domain.valid?
31	- assert domain.errors[:name.to_s].present?	31	+ assert domain.errors[:name].present?
32	end	32	end
33		33
34	should 'allow domains with hyphen' do	34	should 'allow domains with hyphen' do
35	domain = build(Domain, :name => 'test-domain.org')	35	domain = build(Domain, :name => 'test-domain.org')
36	domain.valid?	36	domain.valid?
37	- assert !domain.errors[:name.to_s].present?	37	+ assert !domain.errors[:name].present?
38	end	38	end
39		39
40	should 'allow domains with underscore' do	40	should 'allow domains with underscore' do
41	domain = build(Domain, :name => 'test_domain.org')	41	domain = build(Domain, :name => 'test_domain.org')
42	domain.valid?	42	domain.valid?
43	- assert !domain.errors[:name.to_s].present?	43	+ assert !domain.errors[:name].present?
44	end	44	end
45		45
46	def test_owner	46	def test_owner
	@@ -59,11 +59,11 @@ class DomainTest < ActiveSupport::TestCase		@@ -59,11 +59,11 @@ class DomainTest < ActiveSupport::TestCase
59	d = Domain.new	59	d = Domain.new
60	d.name = 'www.example.net'	60	d.name = 'www.example.net'
61	d.valid?	61	d.valid?
62	- assert d.errors[:name.to_s].present?, "Name should not accept www."	62	+ assert d.errors[:name].present?, "Name should not accept www."
63		63
64	d.name = 'example.net'	64	d.name = 'example.net'
65	d.valid?	65	d.valid?
66	- assert !d.errors[:name.to_s].present?	66	+ assert !d.errors[:name].present?
67	end	67	end
68		68
69	def test_find_by_name	69	def test_find_by_name
	@@ -82,7 +82,7 @@ class DomainTest < ActiveSupport::TestCase		@@ -82,7 +82,7 @@ class DomainTest < ActiveSupport::TestCase
82		82
83	d = build(Domain, :name => 'example.net')	83	d = build(Domain, :name => 'example.net')
84	assert !d.valid?	84	assert !d.valid?
85	- assert d.errors[:name.to_s].present?	85	+ assert d.errors[:name].present?
86	end	86	end
87		87
88	def test_environment	88	def test_environment
	@@ -57,7 +57,7 @@ class OrganizationMailingTest < ActiveSupport::TestCase		@@ -57,7 +57,7 @@ class OrganizationMailingTest < ActiveSupport::TestCase
57		57
58	should 'return url for organization on url' do	58	should 'return url for organization on url' do
59	mailing = build(OrganizationMailing, :source => community)	59	mailing = build(OrganizationMailing, :source => community)
60	- assert_equal "#{community.environment.top_url}/#{community.name.to_slug}/", mailing.url	60	+ assert_equal "#{community.environment.top_url}/#{community.name.to_slug}", mailing.url
61	end	61	end
62		62
63	should 'deliver mailing to each member after create' do	63	should 'deliver mailing to each member after create' do
	@@ -178,7 +178,7 @@ class ProductTest < ActiveSupport::TestCase		@@ -178,7 +178,7 @@ class ProductTest < ActiveSupport::TestCase
178	product.valid?	178	product.valid?
179		179
180	assert_no_match /[<>]/, product.name	180	assert_no_match /[<>]/, product.name
181	- assert_no_match /[<>]/, product.description	181	+ assert_match /<h1>>> >> html ><\/h1>/, product.description
182	end	182	end
183		183
184	should 'use name of category when has no name yet' do	184	should 'use name of category when has no name yet' do
1	# Monkey patch to rewrite attachment_fu's logic where no image with parent can	1	# Monkey patch to rewrite attachment_fu's logic where no image with parent can
2	# be thumbnailable.	2	# be thumbnailable.
3		3
		4	+require_dependency 'technoweenie/attachment_fu'
		5	+
4	Technoweenie::AttachmentFu::InstanceMethods.module_eval do	6	Technoweenie::AttachmentFu::InstanceMethods.module_eval do
5	def thumbnailable?	7	def thumbnailable?
6	image? && !is_thumbnail?	8	image? && !is_thumbnail?
	@@ -24,3 +26,34 @@ Technoweenie::AttachmentFu::Backends::FileSystemBackend.module_eval do		@@ -24,3 +26,34 @@ Technoweenie::AttachmentFu::Backends::FileSystemBackend.module_eval do
24	end	26	end
25	end	27	end
26		28
		29	+# https://github.com/pothoven/attachment_fu/pull/14
		30	+# remove on 3.2.16
		31	+Technoweenie::AttachmentFu::InstanceMethods.module_eval do
		32	+ # Creates or updates the thumbnail for the current attachment.
		33	+ def create_or_update_thumbnail(temp_file, file_name_suffix, *size)
		34	+ thumbnailable? \|\| raise(ThumbnailError.new("Can't create a thumbnail if the content type is not an image or there is no parent_id column"))
		35	+ find_or_initialize_thumbnail(file_name_suffix).tap do \|thumb\|
		36	+ thumb.temp_paths.unshift temp_file
		37	+ attributes = {
		38	+ content_type: content_type,
		39	+ filename: thumbnail_name_for(file_name_suffix),
		40	+ thumbnail_resize_options: size
		41	+ }
		42	+ attributes.each{ \|a, v\| thumb.send "#{a}=", v }
		43	+ callback_with_args :before_thumbnail_saved, thumb
		44	+ thumb.save!
		45	+ end
		46	+ end
		47	+
		48	+ # Initializes a new thumbnail with the given suffix.
		49	+ def find_or_initialize_thumbnail(file_name_suffix)
		50	+ attrs = {thumbnail: file_name_suffix.to_s}
		51	+ attrs[:parent_id] = id if respond_to? :parent_id
		52	+ thumb = thumbnail_class.where(attrs).first
		53	+ unless thumb
		54	+ thumb = thumbnail_class.new
		55	+ attrs.each{ \|a, v\| thumb[a] = v }
		56	+ end
		57	+ thumb
		58	+ end
		59	+end