[Mezuro] Refactored the source tree navegation with tests

Caio Salgado + Diego Araújo + Pedro Leal · Diego Camarinha
1 parent a62342f3
Showing 5 changed files with 45 additions and 24 deletions Show diff stats
plugins/mezuro/controllers/mezuro_plugin_profile_controller.rb
plugins/mezuro/lib/kalibro/entities/module.rb
plugins/mezuro/lib/kalibro/entities/project_result.rb
plugins/mezuro/test/fixtures/module_node_fixtures.rb
plugins/mezuro/test/unit/kalibro/entities/project_result_test.rb
@@ -18,8 +18,11 @@ class MezuroPluginProfileController &lt; ProfileController
   def project_result
     content = profile.articles.find(params[:id])
     project_result = content.project_result
-    source_tree = project_result.subtree(params[:module_name])
-    source_tree = project_result.source_tree if source_tree.nil?
+    if params[:module_name].nil?
+      source_tree = project_result.source_tree
+    else
+      source_tree = project_result.get_node(params[:module_name])
+    end
     render :partial => 'content_viewer/project_result', :locals => { :project_result => project_result, :source_tree => source_tree }
   end
@@ -2,13 +2,17 @@ class Kalibro::Entities::Module &lt; Kalibro::Entities::Entity
   attr_accessor :name, :granularity
-  def ancestor_names
+  def self.parent_names(name)
     path = []
     ancestors = []
-    @name.split(".").each do |token|
+    name.split(".").each do |token|
        path << token
        ancestors << path.join(".")
      end
      ancestors
   end
+
+  def ancestor_names
+    Kalibro::Entities::Module.parent_names(@name)
+  end
 end
@@ -14,22 +14,6 @@ class Kalibro::Entities::ProjectResult &lt; Kalibro::Entities::Entity
     format_milliseconds(@load_time)
   end
-  def subtree(name)
-    find_subtree(@source_tree, name)
-  end
-
-  def find_subtree(tree, name)
-    if tree.module.name == name
-      tree
-    elsif !tree.children.nil?
-      tree.children.each do |child| 
-        found = find_subtree(child, name)
-        return found if !found.nil? 
-      end
-      return nil
-    end
-  end
-
   def formatted_analysis_time
      format_milliseconds(@analysis_time)
   end
@@ -47,4 +31,21 @@ class Kalibro::Entities::ProjectResult &lt; Kalibro::Entities::Entity
     ('%2d' % amount).sub(/\s/, '0')
   end
+  def get_node(module_name)
+    path = Kalibro::Entities::Module.parent_names(module_name)
+    parent = @source_tree
+    path.each do |node_name|
+      parent = get_leaf_from(parent, node_name)
+    end
+    return parent
+  end
+
+  private
+  def get_leaf_from(node, module_name) 
+    node.children.each do |child_node|
+      return child_node if child_node.module.name == module_name
+    end
+    nil
+  end
+
 end
@@ -3,7 +3,9 @@ class ModuleNodeFixtures
   def self.qt_calculator_tree
     node = Kalibro::Entities::ModuleNode.new
     node.module = ModuleFixtures.qt_calculator
-    node.children = [new_node('Dialog', 'CLASS'), new_node('main', 'CLASS')]
+    org_node = new_node('org', 'PACKAGE')
+    org_node.children = [new_node('org.Window', 'CLASS')]
+    node.children = [new_node('Dialog', 'CLASS'), new_node('main', 'CLASS'), org_node]
     node
   end
@@ -11,7 +13,9 @@ class ModuleNodeFixtures
     {:module => ModuleFixtures.qt_calculator_hash,
       :child => [
         {:module => {:name => 'Dialog', :granularity => 'CLASS'}},
-        {:module => {:name => 'main', :granularity => 'CLASS'}}
+        {:module => {:name => 'main', :granularity => 'CLASS'}},
+        {:module => {:name => 'org', :granularity => 'PACKAGE'},
+         :child => [{:module => {:name => 'org.Window', :granularity => 'CLASS'}}]}
       ]
     }
   end
@@ -24,5 +24,14 @@ class ProjectResultTest &lt; ActiveSupport::TestCase
   should 'retrieve formatted analysis time' do
     assert_equal '00:00:01', @result.formatted_analysis_time
   end
-  
-end
 \ No newline at end of file
+
+  should 'retrieve module node' do
+    node = @result.get_node("main")
+    assert_equal @hash[:source_tree][:child][1], node.to_hash
+  end
+
+  should 'retrive complex module' do
+    node = @result.get_node("org.Window")
+    assert_equal @hash[:source_tree][:child][2][:child].first, node.to_hash
+  end
+end
	@@ -24,5 +24,14 @@ class ProjectResultTest < ActiveSupport::TestCase		@@ -24,5 +24,14 @@ class ProjectResultTest < ActiveSupport::TestCase
24	should 'retrieve formatted analysis time' do	24	should 'retrieve formatted analysis time' do
25	assert_equal '00:00:01', @result.formatted_analysis_time	25	assert_equal '00:00:01', @result.formatted_analysis_time
26	end	26	end
27	-
28	-end
29	\ No newline at end of file	27	\ No newline at end of file
		28	+
		29	+ should 'retrieve module node' do
		30	+ node = @result.get_node("main")
		31	+ assert_equal @hash[:source_tree][:child][1], node.to_hash
		32	+ end
		33	+
		34	+ should 'retrive complex module' do
		35	+ node = @result.get_node("org.Window")
		36	+ assert_equal @hash[:source_tree][:child][2][:child].first, node.to_hash
		37	+ end
		38	+end