Download as
Browse Code »

Commit 2c1b5026184466b60b3ffe361adcde2ea0fe7ff5

Authored by Rodrigo Souto
1 parent 5e5b5f3a
Exists in master and in 22 other branches angular_poc, api-article-archived, article-readonly, backup-7-jan-2016, captcha_serpro_plugin, content-manager-hostspot, export-comment-paragraph, fix_event_date_issue, login-captcha, master_rails3, new_video_plugin, pg_search_rank, production, refactor_with_role, refactor_with_role_scope, remove_profile_cat_icons, resend_confirmation_email, staging, staging_rails3, tasks_keep_filter_params, theme-brasil-digital-from-staging, travis

Product edit category doesn't crash if product has no category 

(ActionItem2007)
Showing 2 changed files with 8 additions and 1 deletions   Show diff stats
app/controllers/my_profile/manage_products_controller.rb
  Diff comments   View file @2c1b502
... ... @@ -72,7 +72,7 @@ class ManageProductsController < ApplicationController
72 72  
73 73 def edit_category
74 74 @product = @profile.products.find(params[:id])
75   - @category = @product.product_category
  75 + @category = @product.product_category || ProductCategory.first
76 76 @categories = ProductCategory.top_level_for(environment)
77 77 @edit = true
78 78 @level = @category.level
... ...
test/functional/manage_products_controller_test.rb
  Diff comments   View file @2c1b502
... ... @@ -123,6 +123,13 @@ class ManageProductsControllerTest < Test::Unit::TestCase
123 123 assert_template 'shared/_dialog_error_messages'
124 124 end
125 125  
  126 + should "not crash if product has no category" do
  127 + product = fast_create(Product, :enterprise_id => @enterprise.id)
  128 + assert_nothing_raised do
  129 + post 'edit_category', :profile => @enterprise.identifier, :id => product.id
  130 + end
  131 + end
  132 +
126 133 should "destroy product" do
127 134 product = fast_create(Product, :name => 'test product', :enterprise_id => @enterprise.id, :product_category_id => @product_category.id)
128 135 assert_difference Product, :count, -1 do
... ...