Refactory add_members() profile method and break them into two methods. Created …

…functional test to this refactory

Refactory add_members() profile method and break them into two methods. Created …
…functional test to this refactory
Michel Felipe
1 parent a70da834
Showing 4 changed files with 45 additions and 26 deletions Show diff stats
app/models/profile.rb
lib/add_members_job.rb
test/functional/invite_controller_test.rb
vendor/plugins/access_control/lib/acts_as_accessible.rb
@@ -665,29 +665,26 @@ private :generate_url, :url_options
     end
   end
-  # Adds many people to profile by id's or email's
-  def add_members(people_ids)
+  # Adds many people to profile by id's
+  def add_members_by_id(people_ids)
     unless people_ids.nil? && people_ids.empty?
-      people = []
-      if people_ids.first =~ /\@/
-        people = User.where(email: people_ids)
-      else
-        people = Person.where(id: people_ids)
+      people = Person.where(id: people_ids)
+      people.each do |person|
+
+        add_member(person) unless person.is_member_of?(self)
       end
+    end
+  end
-      people.each do |profile|
-        person = profile
+  # Adds many people to profile by email's
+  def add_members_by_email(people_emails)
-        if profile.is_a? User
-          person = profile.person
-        end
+    people = User.where(email: people_emails)
+    people.each do |user|
-        unless person.is_member_of?(self)
-          add_member person
-        end
-      end
+      add_member(user.person) unless user.person.is_member_of?(self)
     end
   end
@@ -4,7 +4,12 @@ class AddMembersJob &lt; Struct.new(:people_ids, :profile_id, :locale)
     Noosfero.with_locale(locale) do
       profile = Profile.find(profile_id)
-      profile.add_members people_ids
+
+      if people_ids.first =~ /\@/
+        profile.add_members_by_email people_ids
+      else
+        profile.add_members_by_id people_ids
+      end
     end
   end
@@ -284,11 +284,6 @@ class InviteControllerTest &lt; ActionController::TestCase
     assert_empty json_response
   end
-  #@todo Copy this test and create a another version
-  #of this, for test add members in a community
-  #logged as admin of environment!
-  # #issue227
-  #
   should 'invite registered users through profile id' do
     friend1 = create_user('testuser1').person
     friend2 = create_user('testuser2').person
@@ -302,7 +297,7 @@ class InviteControllerTest &lt; ActionController::TestCase
     end
   end
-  should 'add registered users imediatly instead invite if logged user is a environment admin' do
+  should 'add registered users by id imediatly instead invite if logged user is a environment admin' do
     #Add user like a environment admin
     Environment.default.add_admin profile
@@ -313,7 +308,29 @@ class InviteControllerTest &lt; ActionController::TestCase
     assert_difference 'Delayed::Job.count', 1 do
       assert_equal 0,community.members.count
-      post :invite_registered_friend, :profile => @community.identifier, :q => [friend1.id,friend2.id]
+      post :invite_registered_friend, :profile => @community.identifier, :q => "#{friend1.id},#{friend2.id}"
+
+      assert_response :redirect
+      assert_redirected_to :controller => 'profile', :action => 'members'
+    end
+
+    Delayed::Worker.new.run(Delayed::Job.last)
+
+    assert_equal 2,community.members.count
+
+  end
+
+  should 'add registered users by email imediatly instead invite if logged user is a environment admin' do
+
+    Environment.default.add_admin profile
+
+    friend1 = create_user('testuser1', {email: 'friend1@test.com.br'})
+    friend2 = create_user('testuser2', {email: 'friend2@test.com.br'})
+
+    assert_difference 'Delayed::Job.count', 1 do
+      assert_equal 0,community.members.count
+
+      post :invite_registered_friend, :profile => @community.identifier, :q => "#{friend1.email},#{friend2.email}"
       assert_response :redirect
       assert_redirected_to :controller => 'profile', :action => 'members'
@@ -19,9 +19,9 @@ module ActsAsAccessible
     nil
   end
-  def affiliate(accessor, roles)
+  def affiliate(accessor, roles, attributes = {})
     roles = [roles] unless roles.kind_of?(Array)
-    roles.map {|role| accessor.add_role(role, self)}.any? 
+    roles.map {|role| accessor.add_role(role, self, attributes)}.any?
   end
   def disaffiliate(accessor, roles)
	@@ -19,9 +19,9 @@ module ActsAsAccessible		@@ -19,9 +19,9 @@ module ActsAsAccessible
19	nil	19	nil
20	end	20	end
21		21
22	- def affiliate(accessor, roles)	22	+ def affiliate(accessor, roles, attributes = {})
23	roles = [roles] unless roles.kind_of?(Array)	23	roles = [roles] unless roles.kind_of?(Array)
24	- roles.map {\|role\| accessor.add_role(role, self)}.any?	24	+ roles.map {\|role\| accessor.add_role(role, self, attributes)}.any?
25	end	25	end
26		26
27	def disaffiliate(accessor, roles)	27	def disaffiliate(accessor, roles)