Merge branch 'rails3' of gitlab.com:noosfero/noosfero into rails3

Conflicts: lib/noosfero/plugin/routes.rb plugins/container_block/test/unit/block_test.rb plugins/container_block/test/unit/environment_test.rb plugins/container_block/test/unit/profile_test.rb plugins/container_block/views/blocks/container.html.erb

Merge branch 'rails3' of gitlab.com:noosfero/noosfero into rails3
Conflicts: lib/noosfero/plugin/routes.rb plugins/container_block/test/unit/block_test.rb plugins/container_block/test/unit/environment_test.rb plugins/container_block/test/unit/profile_test.rb plugins/container_block/views/blocks/container.html.erb
Victor Costa
2 parents ab47509b 423aba17
Showing 81 changed files with 1032 additions and 190 deletions Show diff stats
INSTALL.md
app/controllers/admin/users_controller.rb
app/controllers/application_controller.rb
app/controllers/box_organizer_controller.rb
app/controllers/my_profile/profile_members_controller.rb
app/controllers/public/profile_controller.rb
app/helpers/application_helper.rb
app/helpers/boxes_helper.rb
app/models/box.rb
app/models/environment.rb
app/models/link_list_block.rb
app/models/profile.rb
app/views/blocks/location.html.erb
app/views/box_organizer/_link_list_block.html.erb
app/views/content_viewer/view_page.html.erb
app/views/profile_members/_members_list.html.erb
debian/changelog
lib/noosfero.rb
lib/noosfero/core_ext/array.rb
lib/noosfero/plugin/macro.rb
@@ -23,7 +23,7 @@ You need to install some packages Noosfero depends on. On Debian GNU/Linux or De
     # apt-get install ruby rake po4a libgettext-ruby-util libgettext-ruby1.8 \
       libsqlite3-ruby rcov librmagick-ruby libredcloth-ruby libhpricot-ruby \
       libwill-paginate-ruby iso-codes libfeedparser-ruby libdaemons-ruby thin \
-      tango-icon-theme libnokogiri-ruby
+      tango-icon-theme
 On other systems, they may or may not be available through your regular package management system. Below are the links to their homepages.
@@ -41,7 +41,6 @@ On other systems, they may or may not be available through your regular package 
 * Thin: http://code.macournoyer.com/thin
 * tango-icon-theme: http://tango.freedesktop.org/Tango_Icon_Library
 * Hpricot: http://hpricot.com
-* Nokogiri: http://nokogiri.org/
 If you manage to install Noosfero successfully on other systems than Debian,
 please feel free to contact the Noosfero development mailing with the
@@ -7,7 +7,7 @@ class UsersController &lt; AdminController
   include UsersHelper
   def index
-    @filter = params[:filter]
+    @filter = params[:filter] || 'all_users'
     scope = environment.people.no_templates
     if @filter == 'admin_users'
       scope = scope.admins
@@ -16,6 +16,7 @@ class UsersController &lt; AdminController
     elsif @filter == 'deactivated_users'
       scope = scope.deactivated
     end
+    scope = scope.order('name ASC')
     @q = params[:q]
     @collection = find_by_contents(:people, scope, @q, {:per_page => per_page, :page => params[:npage]})[:results]
   end
@@ -24,6 +24,7 @@ class ApplicationController &lt; ActionController::Base
   include ApplicationHelper
   layout :get_layout
   def get_layout
+    return nil if request.format == :js
     theme_layout = theme_option(:layout)
     if theme_layout
       theme_view_file('layouts/'+theme_layout) || theme_layout
@@ -70,7 +70,7 @@ class BoxOrganizerController &lt; ApplicationController
     else
       @center_block_types = (Box.acceptable_center_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => 1)
       @side_block_types = (Box.acceptable_side_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => [2,3])
-      @boxes = boxes_holder.boxes
+      @boxes = boxes_holder.boxes.with_position
       render :action => 'add_block', :layout => false
     end
   end
@@ -2,7 +2,7 @@ class ProfileMembersController &lt; MyProfileController
   protect 'manage_memberships', :profile
   def index
-    @members = profile.members
+    @members = profile.members_by_name
     @member_role = environment.roles.find_by_name('member')
   end
@@ -67,7 +67,7 @@ class ProfileController &lt; PublicController
   def members
     if is_cache_expired?(profile.members_cache_key(params))
-      @members = profile.members.includes(relations_to_include).paginate(:per_page => members_per_page, :page => params[:npage])
+      @members = profile.members_by_name.includes(relations_to_include).paginate(:per_page => members_per_page, :page => params[:npage])
     end
   end
@@ -1415,16 +1415,16 @@ module ApplicationHelper
   end
   def convert_macro(html, source)
-    doc = Nokogiri::HTML(html)
+    doc = Hpricot(html)
     #TODO This way is more efficient but do not support macro inside of
     #     macro. You must parse them from the inside-out in order to enable
     #     that.
-    doc.css('.macro').each do |macro|
+    doc.search('.macro').each do |macro|
       macro_name = macro['data-macro']
       result = @plugins.parse_macro(macro_name, macro, source)
-      macro.content = result.kind_of?(Proc) ? self.instance_eval(&result) : result
+      macro.inner_html = result.kind_of?(Proc) ? self.instance_eval(&result) : result
     end
-    CGI.unescapeHTML(doc.xpath('//body/*').to_s)
+    doc.html
   end
   def default_folder_for_image_upload(profile)
@@ -39,7 +39,7 @@ module BoxesHelper
   end
   def display_boxes(holder, main_content)
-    boxes = holder.boxes.first(holder.boxes_limit)
+    boxes = holder.boxes.with_position.first(holder.boxes_limit)
     content = boxes.reverse.map { |item| display_box(item, main_content) }.join("\n")
     content = main_content if (content.blank?)
@@ -7,6 +7,8 @@ class Box &lt; ActiveRecord::Base
   include Noosfero::Plugin::HotSpot
+  named_scope :with_position, :conditions => ['boxes.position > 0']
+
   def environment
     owner ? (owner.kind_of?(Environment) ? owner : owner.environment) : nil
   end
@@ -190,7 +190,7 @@ class Environment &lt; ActiveRecord::Base
   has_many :states
   has_many :cities
-  has_many :roles
+  has_many :roles, :dependent => :destroy
   has_many :qualifiers
   has_many :certifiers
@@ -65,7 +65,7 @@ class LinkListBlock &lt; Block
   def link_html(link)
     klass = 'icon-' + link[:icon] if link[:icon]
     sanitize_link(
-      link_to(link[:name], expand_address(link[:address]), :target => link[:target], :class => klass)
+      link_to(link[:name], expand_address(link[:address]), :target => link[:target], :class => klass, :title => link[:title])
     )
   end
@@ -96,6 +96,10 @@ class Profile &lt; ActiveRecord::Base
     ScopeTool.union *scopes
   end
+  def members_by_name
+    members.order(:name)
+  end
+
   def members_count
     members.count
   end
@@ -3,7 +3,6 @@
   <div class='the-localization-map'>
     <img src="https://maps.google.com/maps/api/staticmap?center=<%=profile.lat%>,<%=profile.lng%>&zoom=<%=block.zoom%>&size=190x250&maptype=<%=block.map_type%>&markers=<%=profile.lat%>,<%=profile.lng%>&sensor=false"/>
   </div>
-</div>
 <% else %>
   <i><%= _('This profile has no geographical position registered.') %></i>
 <% end %>
 <strong><%= _('Links') %></strong>
-<div id='edit-link-list-block' style='width:450px'>
+<div id='edit-link-list-block'>
 <table id='links' class='noborder'>
-  <tr><th><%= _('Icon') %></th><th><%= _('Name') %></th><th><%= _('Address') %></th><th><%= _('Target') %></th></tr>
+  <tr>
+    <th><%= _('Icon') %></th>
+    <th><%= _('Name') %></th>
+    <th><%= _('Address') %></th>
+    <th><%= _('Title') %></th>
+    <th><%= _('Target') %></th>
+  </tr>
   <% for link in @block.links do %>
-    <tr>
-      <td>
-         <%= icon_selector(link['icon']) %>
-      </td>
-      <td><%= text_field_tag 'block[links][][name]', link[:name], :class => 'link-name', :maxlength => 20 %></td>
-      <td class='cel-address'><%= text_field_tag 'block[links][][address]', link[:address], :class => 'link-address' %></td>
-      <td>
-        <%= select_tag('block[links][][target]', options_for_select(LinkListBlock::TARGET_OPTIONS, link[:target])) %>
-      </td>
-    </tr>
+  <tr>
+    <td><%= icon_selector(link['icon']) %></td>
+    <td><%= text_field_tag 'block[links][][name]', link[:name], :class => 'link-name', :maxlength => 20 %></td>
+    <td class='cel-address'><%= text_field_tag 'block[links][][address]', link[:address], :class => 'link-address' %></td>
+    <td><%= text_field_tag 'block[links][][title]', link[:title], :class => 'link-title' %></td>
+    <td><%= select_tag('block[links][][target]', options_for_select(LinkListBlock::TARGET_OPTIONS, link[:target])) %></td>
+  </tr>
   <% end %>
 </table>
 </div>
@@ -22,8 +25,8 @@
       content_tag('td', icon_selector('ok')) +
       content_tag('td', text_field_tag('block[links][][name]', '', :maxlength => 20)) +
       content_tag('td', text_field_tag('block[links][][address]', nil, :class => 'link-address'), :class => 'cel-address') +
-      content_tag('td', select_tag('block[links][][target]',
-options_for_select(LinkListBlock::TARGET_OPTIONS, '_self')))
+      content_tag('td', text_field_tag('block[links][][title]', '', :class => 'link-title')) +
+      content_tag('td', select_tag('block[links][][target]', options_for_select(LinkListBlock::TARGET_OPTIONS, '_self')))
     ) +
     javascript_tag("$('edit-link-list-block').scrollTop = $('edit-link-list-block').scrollHeight"))
 end %>
@@ -40,14 +40,6 @@
   </div>
 <% end %>
-<% if !@page.tags.empty? %>
-  <div id="article-tags">
-    <%= _("This article's tags:") %>
-    <%= @page.tags.map { |t| link_to(t, :controller => 'profile', :profile => @profile.identifier, :action => 'tags', :id => t.name ) }.join("\n") %>
-  </div>
-<% end %>
-
-
 <%= render :partial => 'shared/disabled_enterprise' %>
 <% if NOOSFERO_CONF['addthis_enabled'] %>
@@ -83,6 +75,13 @@
 </div>
 <% end %>
+<% if !@page.tags.empty? %>
+  <div id="article-tags">
+    <%= _("This article's tags:") %>
+    <%= @page.tags.map { |t| link_to(t, :controller => 'profile', :profile => @profile.identifier, :action => 'tags', :id => t.name ) }.join("\n") %>
+  </div>
+<% end %>
+
 <%= display_source_info(@page) %>
 <div class="comments" id="comments_list">
-<% collection = @collection == :profile_admins ? profile.admins : profile.members %>
+<% collection = @collection == :profile_admins ? profile.admins : profile.members_by_name %>
 <% title = @title ? @title : _('Current members') %>
 <% remove_action = @remove_action ? @remove_action : {:action => 'unassociate'} %>
+noosfero (0.46.1) unstable; urgency=low
+
+  * Bugfixes release
+
+ -- Daniela Soares Feitosa <daniela@colivre.coop.br>  Fri, 07 Mar 2014 10:33:11 +0000
+
 noosfero (0.46.0) unstable; urgency=low
   * New features release
@@ -4,7 +4,7 @@ require &#39;fast_gettext&#39;
 module Noosfero
   PROJECT = 'noosfero'
-  VERSION = '0.46.0'
+  VERSION = '0.46.1'
   def self.pattern_for_controllers_in_directory(dir)
     disjunction = controllers_in_directory(dir).join('|')
@@ -0,0 +1,9 @@
+class Array
+
+  def uniq_by
+    hash, array = {}, []
+    each { |i| hash[yield(i)] ||= (array << i) }
+    array
+  end
+
+end
@@ -33,9 +33,9 @@ class Noosfero::Plugin::Macro
   end
   def attributes(macro)
-    macro.attributes.
+    macro.attributes.to_hash.
       select {|key, value| key[0..10] == 'data-macro-'}.
-      inject({}){|result, a| result.merge({a[0][11..-1] => a[1].value})}.
+      inject({}){|result, a| result.merge({a[0][11..-1] => a[1]})}.
       with_indifferent_access
   end
@@ -15,7 +15,11 @@ Dir.glob(Rails.root.join(plugins_root, &#39;*&#39;, &#39;controllers&#39;)) do |controllers_dir|
   controllers_by_folder.each do |folder, controllers|
     controllers.each do |controller|
       controller_name = controller.gsub("#{plugin_name}_plugin_",'')
-      match "#{prefixes_by_folder[folder]}/#{plugin_name}/#{controller_name}(/:action(/:id))", :controller => controller
+      if %w[profile myprofile].include?(folder)
+        match "#{prefixes_by_folder[folder]}/#{plugin_name}/#{controller_name}(/:action(/:id))", :controller => controller, :profile => /#{Noosfero.identifier_format}/
+      else
+        match "#{prefixes_by_folder[folder]}/#{plugin_name}/#{controller_name}(/:action(/:id))", :controller => controller
+      end
     end
   end
@@ -0,0 +1,19 @@
+README - Comment Classification Plugin
+======================================
+
+This plugin creates the structure for classifying the comments. The
+initial idea of this plugin is to support the management of public
+consulting, but it can be used in different contexts.
+For now, two kind of classification will be available:
+
+  * Label: when creating a comment, the user identify the kind of it by
+choosing the label of the comment. Example: "Suggestion",
+"Disagreement"...
+  * Status: users with permission can include a Status for a comment.
+Example: "Merged", "Unmerged"
+
+Dependency
+==========
+
+This plugin was developed to help public consulting and needs the
+CommentGroupPlugin enabled to be used.
@@ -0,0 +1,55 @@
+class CommentClassificationPluginLabelsController < AdminController
+  append_view_path File.join(File.dirname(__FILE__) + '/../../views')
+
+  def index
+#    @labels = @environment.labels
+    @labels = CommentClassificationPlugin::Label.all
+  end
+
+  def create
+    @label = CommentClassificationPlugin::Label.new(params[:label])
+    @colors = CommentClassificationPlugin::Label::COLORS
+    if request.post?
+      begin
+        @label.owner = environment
+        @label.save!
+        session[:notice] = _('Label created')
+        redirect_to :action => 'index'
+      rescue
+        session[:notice] = _('Label could not be created')
+      end
+    end
+  end
+
+  def edit
+#    @labels = @environment.labels.find(params[:id])
+    @label = CommentClassificationPlugin::Label.find(params[:id])
+    @colors = CommentClassificationPlugin::Label::COLORS
+    if request.post?
+      begin
+        @label.update_attributes!(params[:label])
+        session[:notice] = _('Label updated')
+        redirect_to :action => :index
+      rescue
+        session[:notice] = _('Failed to edit label')
+      end
+    end
+  end
+
+  def remove
+#    @label = environment.labels.find(params[:label])
+    @label = CommentClassificationPlugin::Label.find(params[:id])
+    if request.post?
+      begin
+        @label.destroy
+        session[:notice] = _('Label removed')
+      rescue
+        session[:notice] = _('Label could not be removed')
+      end
+    else
+      session[:notice] = _('Label could not be removed')
+    end
+    redirect_to :action => 'index'
+  end
+
+end
@@ -0,0 +1,53 @@
+class CommentClassificationPluginStatusController < AdminController
+  append_view_path File.join(File.dirname(__FILE__) + '/../../views')
+
+  def index
+#    @labels = @environment.labels
+    @status = CommentClassificationPlugin::Status.all
+  end
+
+  def create
+    @status = CommentClassificationPlugin::Status.new(params[:status])
+    if request.post?
+      begin
+        @status.owner = environment
+        @status.save!
+        session[:notice] = _('Status created')
+        redirect_to :action => 'index'
+      rescue
+        session[:notice] = _('Status could not be created')
+      end
+    end
+  end
+
+  def edit
+#    @labels = @environment.labels.find(params[:id])
+    @status = CommentClassificationPlugin::Status.find(params[:id])
+    if request.post?
+      begin
+        @status.update_attributes!(params[:status])
+        session[:notice] = _('Status updated')
+        redirect_to :action => :index
+      rescue
+        session[:notice] = _('Failed to edit status')
+      end
+    end
+  end
+
+  def remove
+#    @label = environment.labels.find(params[:label])
+    @status = CommentClassificationPlugin::Status.find(params[:id])
+    if request.post?
+      begin
+        @status.destroy
+        session[:notice] = _('Status removed')
+      rescue
+        session[:notice] = _('Status could not be removed')
+      end
+    else
+      session[:notice] = _('Status could not be removed')
+    end
+    redirect_to :action => 'index'
+  end
+
+end
@@ -0,0 +1,7 @@
+class CommentClassificationPluginAdminController < AdminController
+  append_view_path File.join(File.dirname(__FILE__) + '/../views')
+
+  def index
+  end
+
+end
@@ -0,0 +1,26 @@
+class CommentClassificationPluginMyprofileController < MyProfileController
+  append_view_path File.join(File.dirname(__FILE__) + '/../views')
+
+  before_filter :organizations_only
+  protect 'moderate_comments', :profile
+
+  def index
+    @comments = Comment.all
+  end
+
+  def add_status
+    @comment = Comment.find(params[:id])
+    @statuses = CommentClassificationPlugin::Status.enabled
+    @status = CommentClassificationPlugin::CommentStatusUser.new(:profile => user, :comment => @comment)
+    if request.post? && params[:status]
+      @status.update_attributes(params[:status])
+      @status.save
+    end
+  end
+
+  private
+
+  def organizations_only
+    render_not_found if !profile.organization?
+  end
+end
@@ -0,0 +1,16 @@
+class CreateCommentsLabels < ActiveRecord::Migration
+  def self.up
+    create_table :comment_classification_plugin_labels do |t|
+      t.string      :name
+      t.string      :color
+      t.boolean     :enabled, :default => true
+      t.references  :owner, :polymorphic => true
+
+      t.timestamps
+    end
+  end
+
+  def self.down
+    drop_table :comment_classification_plugin_labels
+  end
+end
@@ -0,0 +1,16 @@
+class CreateCommentLabelUser < ActiveRecord::Migration
+  def self.up
+    create_table :comment_classification_plugin_comment_label_user do |t|
+      t.references  :profile
+      t.references  :comment
+      t.references  :label
+
+      t.timestamps
+    end
+
+  end
+
+  def self.down
+    drop_table :comment_classification_plugin_comment_label_user
+  end
+end
@@ -0,0 +1,16 @@
+class CreateCommentStatus < ActiveRecord::Migration
+  def self.up
+    create_table :comment_classification_plugin_statuses do |t|
+      t.string      :name
+      t.boolean     :enabled, :default => true
+      t.boolean     :enable_reason, :default => true
+      t.references  :owner, :polymorphic => true
+      t.timestamps
+    end
+
+  end
+
+  def self.down
+    drop_table :comment_classification_plugin_statuses
+  end
+end
@@ -0,0 +1,16 @@
+class CreateCommentStatusUser < ActiveRecord::Migration
+  def self.up
+    create_table :comment_classification_plugin_comment_status_user do |t|
+      t.references  :profile
+      t.references  :comment
+      t.references  :status
+      t.text        :reason
+
+      t.timestamps
+    end
+  end
+
+  def self.down
+    drop_table :comment_classification_plugin_comment_status_user
+  end
+end
@@ -0,0 +1,64 @@
+Feature:
+  As a user
+  I want to add label for comments
+
+Background:
+  Given the following users
+    | login      |  name       |
+    | joaosilva  | Joao Silva  |
+    | mariasilva | Maria Silva |
+  And the following communities
+    | identifier       | name             |
+    | sample-community | Sample Community |
+  And the following articles
+    | owner            | name               | body       |
+    | sample-community | Article to comment | First post |
+  And CommentClassificationPlugin is enabled
+  And "Maria Silva" is a member of "Sample Community"
+  And "Joao Silva" is admin of "Sample Community"
+  And I am logged in as "joaosilva"
+
+  @selenium
+  Scenario: dont display labels if admin did not configure status
+    Given I am on article "Article to comment"
+    And I follow "Post a comment"
+    Then I should not see "Label" within "#page-comment-form"
+
+  Scenario: admin configure labels
+    Given I am logged in as "admin_user"
+    And I am on the environment control panel
+    And I follow "Plugins"
+    And I follow "Configuration"
+    And I follow "Manage Labels"
+    Then I should see "no label registered yet" within "#comment-classification-labels"
+    When I follow "Add a new label"
+    And I fill in "Name" with "Question"
+    And I check "Enable this label"
+    And I press "Save"
+    Then I should see "Question" within "#comment-classification-labels"
+
+  @selenium
+  Scenario: save label for comment
+    Given the following labels
+      | owner       | name     | enabled |
+      | environment | Addition | true    |
+    And I go to article "Article to comment"
+    And I follow "Post a comment"
+    And I fill in "Enter your comment" with "Hey ho, let's go!"
+    Then I select "Addition" from "comment_label_id"
+    And I press "Post comment"
+    Then I should see "Addition" within ".comment-details"
+
+  @selenium
+  Scenario: users without permission should not edit the labels
+    Given the following labels
+      | owner       | name     | enabled |
+      | environment | Addition | true    |
+    And I go to article "Article to comment"
+    And I follow "Post a comment"
+    Then I should see "Label" within "#page-comment-form"
+    And I should see "Addition" within "#comment_label_id"
+    When I am not logged in
+    And I am on article "Article to comment"
+    And I follow "Post a comment"
+    Then I should not see "Label" within "#page-comment-form"
@@ -0,0 +1,67 @@
+Feature:
+  As a user
+  I want to add status for comments
+
+Background:
+  Given the following users
+    | login      |  name       |
+    | joaosilva  | Joao Silva  |
+    | mariasilva | Maria Silva |
+  And the following communities
+    | identifier       | name             |
+    | sample-community | Sample Community |
+  And the following articles
+    | owner            | name               | body       |
+    | sample-community | Article to comment | First post |
+    And the following comments
+      | article            | author     | body        |
+      | Article to comment | mariasilva | great post! |
+  And CommentClassificationPlugin is enabled
+  And "Maria Silva" is a member of "Sample Community"
+  And "Joao Silva" is admin of "Sample Community"
+  And I am logged in as "joaosilva"
+
+  Scenario: dont display to add status if not an organization
+    Given the following articles
+      | owner     | name                        | body       |
+      | joaosilva | Article on a person profile | First post |
+    And the following comments
+      | article                     | author     | body        |
+      | Article on a person profile | mariasilva | great post! |
+    Given I am on article "Article on a person profile"
+    Then I should see "great post!" within ".comment-details"
+    And I should not see "Status" within ".comment-details"
+
+  Scenario: dont display to add status if admin did not configure status
+    Given I am on article "Article to comment"
+    Then I should see "great post!" within ".comment-details"
+    And I should not see "Status" within ".comment-details"
+
+  Scenario: admin configure status
+    Given I am logged in as "admin_user"
+    And I am on the environment control panel
+    And I follow "Plugins"
+    And I follow "Configuration"
+    And I follow "Manage Status"
+    Then I should see "no status registered yet" within "#comment-classification-status"
+    When I follow "Add a new status"
+    And I fill in "Name" with "Merged"
+    And I check "Enable this status"
+    And I press "Save"
+    Then I should see "Merged" within "#comment-classification-status"
+
+  Scenario: save status for comment
+    Given the following status
+      | owner       | name   | enabled |
+      | environment | Merged | true    |
+    And I go to article "Article to comment"
+    And I follow "Status"
+    Then I select "Merged" from "status_status_id"
+    And I press "Save"
+    Then I should see "added the status Merged" within "#comment-classification-status-list"
+
+  Scenario: dont display to add status if user not allowed
+    Given I am logged in as "mariasilva"
+    When I go to article "Article to comment"
+    Then I should see "great post!" within ".comment-details"
+    And I should not see "Status" within ".comment-details"
@@ -0,0 +1,24 @@
+Given /^CommentClassificationPlugin is enabled$/ do
+  Given %{I am logged in as admin}
+  And %{I am on the environment control panel}
+  And %{I follow "Plugins"}
+  And %{I check "Comment Classification"}
+  And %{I press "Save changes"}
+  Environment.default.enabled_plugins.should include("CommentClassificationPlugin")
+end
+
+Given /^the following labels$/ do |table|
+  table.hashes.map{|item| item.dup}.each do |item|
+    owner_type = item.delete('owner')
+    owner = owner_type == 'environment' ? Environment.default : Profile[owner_type]
+    CommentClassificationPlugin::Label.create!(item)
+  end
+end
+
+Given /^the following status$/ do |table|
+  table.hashes.map{|item| item.dup}.each do |item|
+    owner_type = item.delete('owner')
+    owner = owner_type == 'environment' ? Environment.default : Profile[owner_type]
+    CommentClassificationPlugin::Status.create!(item)
+  end
+end
@@ -0,0 +1,57 @@
+require 'ext/environment'
+require 'ext/comment'
+
+class CommentClassificationPlugin < Noosfero::Plugin
+
+  def self.plugin_name
+    "Comment Classification"
+  end
+
+  def self.plugin_description
+    _("A plugin that allow classification of comments.")
+  end
+
+#TODO Each organization can add its own status and labels
+#  def control_panel_buttons
+#    if context.profile.organization?
+#      { :title => _('Manage comment classification'), :icon => 'comment_classification', :url => {:controller => 'comment_classification_plugin_myprofile'} }
+#    end
+#  end
+
+  def comment_form_extra_contents(args)
+    comment = args[:comment]
+    lambda {
+      render :file => 'comment/comments_labels_select.rhtml', :locals => {:comment => comment }
+    }
+  end
+
+  def comment_extra_contents(args)
+    comment = args[:comment]
+    lambda {
+      render :file => 'comment/comment_extra.rhtml', :locals => {:comment => comment}
+    }
+  end
+
+  def process_extra_comment_params(args)
+    comment = Comment.find args[0]
+    label_id = args[1][:comment_label_id]
+    if label_id.blank?
+      if !CommentClassificationPlugin::CommentLabelUser.find_by_comment_id(comment.id).nil?
+        CommentClassificationPlugin::CommentLabelUser.find_by_comment_id(comment.id).destroy
+      end
+    else
+      label = CommentClassificationPlugin::Label.find label_id
+      relation = CommentClassificationPlugin::CommentLabelUser.new(:profile => comment.author, :comment => comment, :label => label )
+      relation.save
+    end
+  end
+
+ def js_files
+    'comment_classification.js'
+  end
+
+  def stylesheet?
+    true
+  end
+
+end
@@ -0,0 +1,11 @@
+class CommentClassificationPlugin::CommentLabelUser < Noosfero::Plugin::ActiveRecord
+  set_table_name :comment_classification_plugin_comment_label_user
+
+  belongs_to :profile
+  belongs_to :comment
+  belongs_to :label, :class_name => 'CommentClassificationPlugin::Label'
+
+  validates_presence_of :profile
+  validates_presence_of :comment
+  validates_presence_of :label
+end
@@ -0,0 +1,11 @@
+class CommentClassificationPlugin::CommentStatusUser < Noosfero::Plugin::ActiveRecord
+  set_table_name :comment_classification_plugin_comment_status_user
+
+  belongs_to :profile
+  belongs_to :comment
+  belongs_to :status, :class_name => 'CommentClassificationPlugin::Status'
+
+  validates_presence_of :profile
+  validates_presence_of :comment
+  validates_presence_of :status
+end
@@ -0,0 +1,10 @@
+class CommentClassificationPlugin::Label < Noosfero::Plugin::ActiveRecord
+
+  belongs_to :owner, :polymorphic => true
+
+  validates_presence_of :name
+
+  named_scope :enabled, :conditions => { :enabled => true }
+
+  COLORS = ['red', 'green', 'yellow', 'gray', 'blue']
+end
@@ -0,0 +1,8 @@
+class CommentClassificationPlugin::Status < Noosfero::Plugin::ActiveRecord
+
+  belongs_to :owner, :polymorphic => true
+
+  validates_presence_of :name
+
+  named_scope :enabled, :conditions => { :enabled => true }
+end
@@ -0,0 +1,13 @@
+require_dependency 'comment'
+require 'comment_classification_plugin.rb'
+require 'comment_classification_plugin/label.rb'
+
+class Comment
+
+  has_one :comment_classification_plugin_comment_label_user, :class_name => 'CommentClassificationPlugin::CommentLabelUser'
+  has_one :label, :through => :comment_classification_plugin_comment_label_user, :foreign_key => 'label_id'
+
+  has_many :comment_classification_plugin_comment_status_users, :class_name => 'CommentClassificationPlugin::CommentStatusUser'
+  has_many :statuses, :through => :comment_classification_plugin_comment_status_users, :foreign_key => 'status_id'
+
+end
@@ -0,0 +1,8 @@
+require_dependency 'environment'
+
+class Environment
+
+  has_many :labels, :as => :owner, :class_name => 'CommentClassificationPlugin::Label'
+
+end
+
@@ -0,0 +1,12 @@
+.controller-profile_editor .control-panel a.control-panel-comment_classification {
+  background-image: url(images/comment-classification.png);
+}
+
+#content .comment-classification-options .label-name {
+  font-style: italic;
+}
+
+#content .comment-classification-options a.button {
+  background-color: transparent;
+  border: none;
+}
@@ -0,0 +1,17 @@
+<div class='comment-classification-options'>
+
+  <% unless comment.label.nil? %>
+    <p class='label-name' style='color:<%= comment.label.color %>'>
+      <%= comment.label.name %>
+    </p>
+  <% end %>
+
+  <% statuses = CommentClassificationPlugin::Status.enabled %>
+  <% if profile.organization? && user && user.has_permission?(:moderate_comments, profile) && !statuses.empty? %>
+    <div class='comment-classification-status'>
+      <%= link_to(_('Status'), :profile => profile.identifier, :controller => :comment_classification_plugin_myprofile, :action => :add_status, :id => comment.id)
+    %>
+    </div>
+  <% end %>
+
+</div>
@@ -0,0 +1,4 @@
+<% labels = CommentClassificationPlugin::Label.enabled  %>
+<% if logged_in? && user.has_permission?(:moderate_comments, profile) && !labels.empty? %>
+  <%= labelled_form_field(_('Label'), select_tag('comment_label_id', options_for_select( [[_('[Select ...]'), nil]] + labels.map{|l|[l.name,l.id]}, @comment.label.nil? ? '' : @comment.label.id)))  %>
+<% end %>
@@ -0,0 +1,6 @@
+<h1><%= _('Comments classification options')%></h1>
+
+<ul>
+  <li><%= link_to _('Manage Labels'), :controller => 'comment_classification_plugin_labels' %></li>
+  <li><%= link_to _('Manage Status'), :controller => 'comment_classification_plugin_status' %></li>
+</ul>
@@ -0,0 +1,13 @@
+<%= error_messages_for :label %>
+
+<% form_for :label, @label do |f| %>
+  <%= required_fields_message %>
+
+  <%= required labelled_form_field(_('Name'), f.text_field(:name)) %>
+  <%= labelled_form_field(_('Color'), f.select(:color, @colors.map{|s|[s.capitalize,s]}))  %>
+  <%= labelled_form_field(f.check_box(:enabled) + _('Enable this label?'),'') %>
+
+  <% button_bar do %>
+    <%= submit_button('save', _('Save'), :cancel => {:action => 'index'}  ) %>
+  <% end %>
+<% end %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Add a new label") %> </h2>
+
+<%= render :partial => 'form' %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Editing label %s") % @label.name %> </h2>
+
+<%= render :partial => 'form' %>
@@ -0,0 +1,32 @@
+<h1><%= _("Manage comments labels") %></h1>
+
+<div id='comment-classification-labels'>
+  <% if @labels.empty? %>
+    <%= _('(no label registered yet)') %>
+  <% else %>
+    <table>
+      <tr>
+        <th><%= _('Label') %></th>
+        <th><%= _('Color') %></th>
+        <th><%= _('Enabled') %></th>
+        <th><%= _('Actions') %></th>
+      </tr>
+      <% @labels.each do |label| %>
+        <tr>
+          <td><%= label.name %></td>
+          <td><%= label.color %></td>
+          <td><%= label.enabled %></td>
+          <td>
+            <%= button_without_text :edit, _('Edit'), {:action => 'edit', :id => label} %>
+            <%= button_without_text :delete, _('Remove'), {:action => 'destroy', :id => label}, :confirm => _('Are you sure you want to  remove this label?') %>
+          </td>
+        </tr>
+      <% end %>
+    </table>
+  <% end %>
+
+  <% button_bar do %>
+    <%= button(:add, _('Add a new label'), :action => 'create')%>
+    <%= button :back, _('Back to admin panel'), :controller => 'admin_panel' %>
+  <% end %>
+</div>
@@ -0,0 +1,12 @@
+<%= error_messages_for :status %>
+
+<% form_for :status, @status do |f| %>
+  <%= required_fields_message %>
+
+  <%= labelled_form_field(_('Status'), f.select(:status_id, @statuses.map{|s|[s.name,s.id]}))  %>
+  <%= labelled_form_field(_('Reason:'), f.text_area(:reason, :rows => 5)) %>
+
+  <% button_bar do %>
+    <%= submit_button('save', _('Save') ) %>
+  <% end %>
+<% end %>
@@ -0,0 +1,27 @@
+<h1><%= _('Status for comment') %></h1>
+
+<div id='comment-classification-status-list'>
+  <% unless @comment.title.blank? %>
+    <div class='comment-title'><%= _("Title: %s") % @comment.title %></div>
+  <% end %>
+
+  <b><%= _('Body:') %></b>
+  <p><%= @comment.body %></p>
+
+  <h2> <%= _("History") %> </h2>
+
+    <ul>
+    <% @comment.comment_classification_plugin_comment_status_users.each do |relation| %>
+      <li>
+        <%= _("<i>%{user}</i> added the status <i>%{status_name}</i> at <i>%{created_at}</i>.") % { :user => relation.profile.name, :status_name => relation.status.name, :created_at => time_ago_as_sentence(relation.created_at)} %>
+        <% unless relation.reason.blank? %>
+          <p><%= _("<i>Reason:</i> %s") % relation.reason %></p>
+        <% end %>
+      </li>
+    <% end %>
+    </ul>
+
+  <h2> <%= _("Add a new status") %> </h2>
+
+  <%= render :partial => 'status_form' %>
+</div>
@@ -0,0 +1,3 @@
+<h1><%= _('Manage comment classification') %></h1>
+
+List all classifications
@@ -0,0 +1,13 @@
+<%= error_messages_for :status %>
+
+<% form_for :status, @status do |f| %>
+  <%= required_fields_message %>
+
+  <%= required labelled_form_field(_('Name'), f.text_field(:name)) %>
+  <%= labelled_form_field(f.check_box(:enabled) + _('Enable this status?'),'') %>
+  <%#= labelled_form_field(f.check_box(:enable_reason) + _('This status allows reason?'),'') %>
+
+  <% button_bar do %>
+    <%= submit_button('save', _('Save'), :cancel => {:action => 'index'}  ) %>
+  <% end %>
+<% end %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Add a new status") %> </h2>
+
+<%= render :partial => 'form' %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Editing status %s") % @status.name %> </h2>
+
+<%= render :partial => 'form' %>
@@ -0,0 +1,32 @@
+<h1> <%= _("Manage comments status") %></h1>
+
+<div id='comment-classification-status'>
+  <% if @status.empty? %>
+    <%= _('(no status registered yet)') %>
+  <% else %>
+    <table>
+      <tr>
+        <th><%= _('Status') %></th>
+        <th><%= _('Enabled') %></th>
+        <th><%= _('Reason enabled?') %></th>
+        <th><%= _('Actions') %></th>
+      </tr>
+      <% @status.each do |st| %>
+        <tr>
+          <td><%= st.name %></td>
+          <td><%= st.enabled %></td>
+          <td><%= st.enable_reason %></td>
+          <td>
+            <%= button_without_text :edit, _('Edit'), {:action => 'edit', :id => st} %>
+            <%= button_without_text :delete, _('Remove'), {:action => 'destroy', :id => st}, :confirm => _('Are you sure you want to remove this status?') %>
+          </td>
+        </tr>
+      <% end %>
+    </table>
+  <% end %>
+
+  <% button_bar do %>
+    <%= button(:add, _('Add a new status'), :action => 'create')%>
+    <%= button :back, _('Back to admin panel'), :controller => 'admin_panel' %>
+  <% end %>
+</div>
@@ -16,4 +16,8 @@ class ContainerBlockPlugin &lt; Noosfero::Plugin
     true
   end
+  def js_files
+    'container_block.js'
+  end
+
 end
@@ -7,6 +7,16 @@ class ContainerBlockPlugin::ContainerBlock &lt; Block
   settings_items :container_box_id, :type => Integer, :default => nil
   settings_items :children_settings, :type => Hash, :default => {}
+  validate :no_cyclical_reference, :if => 'container_box_id.present?'
+
+  def no_cyclical_reference
+    errors.add(:box_id, _('cyclical reference is not allowed.')) if box_id == container_box_id
+  end
+
+  before_save do |b|
+    raise "cyclical reference is not allowed" if b.box_id == b.container_box_id && !b.container_box_id.blank?
+  end
+
   def self.description
     _('Container')
   end
@@ -15,6 +25,10 @@ class ContainerBlockPlugin::ContainerBlock &lt; Block
     _('This block acts as a container for another blocks')
   end
+  def cacheable?
+    false
+  end
+
   def layout_template
     nil
   end
@@ -24,8 +38,9 @@ class ContainerBlockPlugin::ContainerBlock &lt; Block
   end
   def create_box
-    box = Box.create!(:owner => owner)
-    settings[:container_box_id] = box.id
+    container_box = Box.create!(:owner => owner)
+    container_box.update_attribute(:position, nil)
+    settings[:container_box_id] = container_box.id
     save!
   end
@@ -0,0 +1,28 @@
+function enableMoveContainerChildren(container, box) {
+  var div = jQuery('#box-'+box+' > .block-outer > .block');
+  if(!div.is('.ui-resizable')) {
+    div.resizable({
+      handles: 'e, w',
+      containment: '#block-'+container+' .block-inner-2',
+      resize: function( event, ui ) {
+        ui.element.height('auto');
+      }
+    });
+  }
+}
+
+function disableMoveContainerChildren(container, box) {
+  var div = jQuery('#box-'+box+' > .block-outer > .block');
+  if(div.is('.ui-resizable')) {
+    div.resizable('destroy');
+  }
+}
+
+function containerChildrenWidth(container, box) {
+  widths = "";
+  jQuery('#box-'+box+' > .block-outer > .block').each(function(i) {
+    childId = jQuery(this).attr('id').match(/block-(\d+)/)[1];
+    widths+=childId+","+jQuery(this).width()+"|";
+  });
+  return "widths="+widths;
+}
+#box-organizer .container-block-plugin_container-block > .block-inner-1 > .block-inner-2 > .button-bar {
+  height: 22px;
+  padding-bottom: 0px;
+  width: auto;
+}
+
 #content .boxes .container-block-plugin_container-block .container_block_child, .container-block-plugin_container-block .block-outer {
   display: inline-block;
   vertical-align: top;
@@ -17,14 +23,10 @@
   background-image: url(/designs/icons/default/Tango/16x16/actions/go-previous.png);
 }
-#content .boxes .container-block-plugin_container-block .block {
-  outline-offset: -2px;
-}
-
 #content .boxes .container-block-plugin_container-block .block .ui-resizable-handle {
   width: 10px;
   height: 28px;
-  z-index: 0;
+  z-index: 1000;
 }
 #content .boxes .container-block-plugin_container-block .block .ui-resizable-e {
@@ -37,6 +39,21 @@
   background-image: url(/plugins/container_block/images/handle_w.png);
 }
-.container-block-plugin_container-block .button-bar .icon-resize {
+.container-block-plugin_container-block .container-block-button-bar .icon-resize {
   background-image: url(/designs/icons/default/Tango/16x16/actions/view-fullscreen.png);
 }
+
+#box-organizer .block .container-block-button-bar {
+  right: 0px;
+  bottom: 0px;
+  height: auto;
+}
+
+#box-organizer .container-block-plugin_container-block:hover .block {
+  outline: 1px dashed black;
+  outline-offset: -1px;
+}
+
+.container-block-plugin_container-block .block-target {
+  background: #afd;
+}
@@ -31,6 +31,13 @@ class HomeControllerTest &lt; ActionController::TestCase
     assert_tag :div, :attributes => { :class => 'block container-block-plugin_container-block' }
   end
+  should 'display block title' do
+    @block.title = "Block Title"
+    @block.save!
+    get :index
+    assert_tag :div, :attributes => { :class => 'block container-block-plugin_container-block' }, :descendant => {:tag => 'h3', :attributes => { :class => "block-title"}, :content => @block.title }
+  end
+
   should 'display container children' do
     c1 = RawHTMLBlock.create!(:box_id => @block.container_box.id, :html => 'child1 content')
     c2 = RawHTMLBlock.create!(:box_id => @block.container_box.id, :html => 'child2 content')
@@ -1,31 +0,0 @@
-require 'test_helper'
-
-class BlockTest < ActiveSupport::TestCase
-
-  def setup
-    @environment = fast_create(Environment)
-    @box = Box.create!(:owner => @environment)
-    @container = ContainerBlockPlugin::ContainerBlock.create!(:box_id => @box.id)
-  end
-
-  should 'return environment box if block owner is not a ContainerBlock' do
-    block = Block.create!(:box_id => @box.id)
-    assert_equal @box, block.box
-  end
-
-  should 'return container box if block owner is a ContainerBlock' do
-    block = Block.create!(:box_id => @container.container_box.id)
-    assert_equal @container.container_box, block.box
-  end
-
-  should 'return block owner if block onwer is not a ContainerBlock' do
-    block = Block.create!(:box_id => @box.id)
-    assert_equal @environment, block.owner
-  end
-
-  should 'return environment as owner if block onwer is a ContainerBlock' do
-    block = Block.create!(:box_id => @container.container_box.id)
-    assert_equal @environment, block.owner
-  end
-
-end
@@ -20,6 +20,11 @@ class ContainerBlockPlugin::ContainerBlockTest &lt; ActiveSupport::TestCase
     assert @block.container_box_id
   end
+  should 'created box should have nil as position' do
+    @block.save!
+    assert_equal nil, @block.container_box.position
+  end
+
   should 'return created box' do
     @block.save!
     assert @block.container_box
@@ -89,4 +94,27 @@ class ContainerBlockPlugin::ContainerBlockTest &lt; ActiveSupport::TestCase
     end
   end
+  should 'not mess up with boxes positions when destroyed' do
+    env = fast_create(Environment)
+    box1 = fast_create(Box, :owner_id => env.id, :owner_type => 'Environment', :position => 1)
+    box2 = fast_create(Box, :owner_id => env.id, :owner_type => 'Environment', :position => 2)
+    box3 = fast_create(Box, :owner_id => env.id, :owner_type => 'Environment', :position => 3)
+    block = ContainerBlockPlugin::ContainerBlock.create!(:box => box1)
+    block.destroy
+    assert_equal [1, 2, 3], [box1.reload.position, box2.reload.position, box3.reload.position]
+  end
+
+  should 'be able to change box' do
+    @block.save!
+    @block.box = Box.new(:owner => Environment.default)
+    @block.save!
+  end
+
+  should 'not able to change box to be the same as container_box' do
+    @block.save!
+    @block.box = @block.container_box
+    @block.save
+    assert @block.errors.invalid?(:box_id)
+  end
+
 end
@@ -1,32 +0,0 @@
-require 'test_helper'
-
-class EnvironmentTest < ActiveSupport::TestCase
-
-  def setup
-    @environment = fast_create(Environment)
-
-    @box = create(Box, :owner => @environment)
-    @block = create(Block, :box => @box)
-
-    @container = create(ContainerBlockPlugin::ContainerBlock, :box => @box)
-  end
-
-  should 'return blocks as usual' do
-    assert_equal [@block, @container], @environment.blocks
-  end
-
-  should 'return blocks with container children' do
-    child = Block.create!(:box_id => @container.container_box.id)
-    assert_equal [@block, @container, child], @environment.blocks
-  end
-
-  should 'return block with id at find method' do
-    assert_equal @block, @environment.blocks.find(@block.id)
-  end
-
-  should 'return child block with id at find method' do
-    child = Block.create!(:box_id => @container.container_box.id)
-    assert_equal child, @environment.blocks.find(child.id)
-  end
-
-end
@@ -1,32 +0,0 @@
-require 'test_helper'
-
-class ProfileTest < ActiveSupport::TestCase
-
-  def setup
-    @profile = fast_create(Profile)
-
-    @box = create(Box, :owner => @profile)
-    @block = create(Block, :box => @box)
-
-    @container = create(ContainerBlockPlugin::ContainerBlock, :box => @box)
-  end
-
-  should 'return blocks as usual' do
-    assert_equal [@block, @container], @profile.blocks
-  end
-
-  should 'return blocks with container children' do
-    child = Block.create!(:box_id => @container.container_box.id)
-    assert_equal [@block, @container, child], @profile.blocks
-  end
-
-  should 'return block with id at find method' do
-    assert_equal @block, @profile.blocks.find(@block.id)
-  end
-
-  should 'return child block with id at find method' do
-    child = Block.create!(:box_id => @container.container_box.id)
-    assert_equal child, @profile.blocks.find(child.id)
-  end
-
-end
 <% edit_mode = controller.send(:boxes_editor?) && controller.send(:uses_design_blocks?) %>
 <% box_decorator = edit_mode ? self : BoxesHelper::DontMoveBlocks %>
+<%= block_title(block.title) %>
 <div class="box" id="box-<%= block.container_box.id %>">
   <%= display_box_content(block.container_box, nil) %>
@@ -15,46 +16,23 @@
 </style>
 <% if edit_mode %>
-  <div class="button-bar">
-    <a href="#" onclick="toggleMoveContainerChildren(<%= block.id %>, <%= block.container_box.id %>); return false;" class="button icon-resize" title=<%= _('Resize blocks').to_json %>></a>
-    <%= link_to_remote '', :url => { :controller => controller.boxes_holder.kind_of?(Environment) ? 'container_block_plugin_admin' : 'container_block_plugin_myprofile', :action => 'saveWidths', :id => block.id }, 
+
+  <script>
+    jQuery("#block-<%= block.id %>").hover(
+      function() {
+        enableMoveContainerChildren(<%= block.id %>, <%= block.container_box.id %>);
+      }, function() {
+        disableMoveContainerChildren(<%= block.id %>, <%= block.container_box.id %>);
+      }
+    );
+  </script>
+
+  <div class="container-block-button-bar button-bar">
+    <%= link_to_remote '', :url => { :controller => @controller.boxes_holder.kind_of?(Environment) ? 'container_block_plugin_admin' : 'container_block_plugin_myprofile', :action => 'saveWidths', :id => block.id }, 
                            :with => "containerChildrenWidth(#{block.id}, #{block.container_box.id})", 
     :html => {:class => "button icon-save container_block_save", :id => "container_block_save_#{block.id}", :title => _('Save') },
                            :loading => "open_loading(DEFAULT_LOADING_MESSAGE);",
                            :loaded => "close_loading();",
                            :complete => "display_notice(request.responseText);"%>
   </div>
-
-  <script>
-    function toggleMoveContainerChildren(container, box) {
-      var div = jQuery('#box-'+box+' > .block-outer > .block');
-      var targetDiv = jQuery('#box-'+box+' .block-outer .block-target');
-      if(div.is('.ui-resizable')) {
-        targetDiv.show();
-        div.find("a").die("click");
-        div.resizable('destroy');
-      } else {
-        targetDiv.hide();
-        div.find("a").live("click", function(e) {
-          e.preventDefault();
-        });
-        div.resizable({
-          handles: 'e, w',
-          containment: '#block-'+container+' .block-inner-2',
-          resize: function( event, ui ) {
-            ui.element.height('auto');
-          }
-        });
-      }
-    }
-
-    function containerChildrenWidth(container, box) {
-      widths = "";
-      jQuery('#box-'+box+' > .block-outer > .block').each(function(i) { 
-        childId = jQuery(this).attr('id').match(/block-(\d+)/)[1];
-        widths+=childId+","+jQuery(this).width()+"|";
-      });
-      return "widths="+widths;
-    }
-  </script>
 <% end %>
 (function($) {
   $(window).bind('userDataLoaded', function(event, data) {
-    if (data.login || $('meta[name=profile.allow_unauthenticated_comments]').length > 0) {
+    if (data.login || $('meta[name="profile.allow_unauthenticated_comments"]').length > 0) {
       $('.post-comment-button').livequery(function() {
         $(this).show();
       });
@@ -8,7 +8,7 @@
         $(this).show();
       });
       $('.comment-footer').livequery(function() {
-        $(this).show();      
+        $(this).show();
       });
     }
   });
+/* browser fixes */
+
+img:-moz-broken {
+  -moz-force-broken-image-icon:1;
+}
+
+/* general styles */
+
 body {
   padding: 0px;
   margin: 0px;
@@ -1727,8 +1735,8 @@ a.button.disabled, input.disabled {
   display: none;
 }
-#box-organizer .block:focus .button-bar,
-#box-organizer .block:hover .button-bar {
+#box-organizer .block-outer:focus .button-bar,
+#box-organizer .block-outer:hover .button-bar {
   display: block;
 }
@@ -1834,8 +1842,13 @@ a.button.disabled, input.disabled {
 }
 /* ==> blocks/link-list-block.css <<= */
+#edit-link-list-block {
+  width: 820px;
+}
+
 #edit-link-list-block table {
-  width: 100%;
+  width: auto;
+  margin-bottom: 10px;
 }
 #edit-link-list-block table .cel-address {
   width: 220px;
@@ -5,7 +5,7 @@ run sudo apt-get -y install $runtime_dependencies
 sudo apt-get -y install iceweasel || sudo apt-get -y install firefox
 # needed for development
-run sudo apt-get -y install libtidy-ruby libhpricot-ruby libnokogiri-ruby libmocha-ruby imagemagick po4a xvfb libxml2-dev libxslt-dev postgresql openjdk-6-jre
+run sudo apt-get -y install libtidy-ruby libhpricot-ruby libmocha-ruby imagemagick po4a xvfb libxml2-dev libxslt-dev postgresql openjdk-6-jre
 gem which bundler >/dev/null 2>&1 || gem_install bundler
 setup_rubygems_path
 run bundle install
@@ -310,4 +310,23 @@ class ProfileThemesControllerTest &lt; ActionController::TestCase
     assert_no_tag :content => "Select theme"
   end
+  should 'not duplicate themes that are included by the user and by the environment' do
+    t1 = Theme.create('theme1')
+    t2 = Theme.create('theme2')
+    Environment.any_instance.stubs('themes').returns([t1,t2])
+    Theme.stubs(:approved_themes).returns([t2])
+
+    get :index, :profile => "testinguser"
+    assert_equivalent [t1, t2], assigns(:themes)
+  end
+
+  should 'sort themes by name' do
+    t1 = Theme.create('bill-theme')
+    t2 = Theme.create('ana-theme')
+    Theme.stubs(:approved_themes).returns([t1,t2])
+
+    get :index, :profile => "testinguser"
+    assert_equal [t2, t1], assigns(:themes)
+  end
+
 end
@@ -107,6 +107,21 @@ class UsersControllerTest &lt; ActionController::TestCase
     assert_equal false, u.activated?
   end
+  should 'order users by name' do
+    create_user('jeremy')
+    create_user('bill')
+    create_user('ana')
+    create_user('creed')
+    get :index
+
+    assert_order ['ana', 'bill', 'creed', 'jeremy'], assigns(:collection).map(&:name)
+  end
+
+  should 'set filter to all_users by default' do
+    get :index
+    assert_equal 'all_users', assigns(:filter)
+  end
+
   should 'response as XML to export users' do
     get :download, :format => 'xml'
     assert_equal 'text/xml', @response.content_type
@@ -178,6 +178,19 @@ class ActiveSupport::TestCase
     assert !tag, "expected no tag #{options.inspect}, but tag found in #{text.inspect}"
   end
+  def assert_order(reference, original)
+    original.each do |value|
+      if reference.include?(value)
+        if reference.first == value
+          reference.shift
+        else
+          assert false, "'#{value}' was found before it should be on: #{original.inspect}"
+        end
+      end
+    end
+    assert reference.blank?, "The following elements are not in the collection: #{reference.inspect}"
+  end
+
   # For models that render views (blocks, articles, ...)
   def render(*args)
     view_paths = @explicit_view_paths || ActionController::Base.view_paths
@@ -0,0 +1,11 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+# tests for Array core extension. See lib/noosfero/core_ext/array.rb
+class StringCoreExtTest < ActiveSupport::TestCase
+
+  should 'allow uniq by a block' do
+    array = [0,1,2,3,4,5,6]
+    assert_equal [0,1], array.uniq_by {|number| number%2 }
+  end
+
+end
@@ -140,4 +140,11 @@ class BoxTest &lt; ActiveSupport::TestCase
     assert !blocks.include?('box-test_plugin-block')
   end
+  should 'list only boxes with a postion greater than zero' do
+    profile = fast_create(Profile)
+    box = fast_create(Box, :owner_id => profile.id, :owner_type => 'Profile', :position => 0)
+    box2 = fast_create(Box, :owner_id => profile.id, :owner_type => 'Profile', :position => 1)
+    assert_equal [box2], profile.boxes.with_position
+  end
+
 end
@@ -12,7 +12,8 @@ class BoxesHelperTest &lt; ActionView::TestCase
   should 'include profile-specific header' do
     holder = mock
-    holder.stubs(:boxes).returns([])
+    holder.stubs(:boxes).returns(boxes = [])
+    boxes.stubs(:with_position).returns([])
     holder.stubs(:boxes_limit).returns(0)
     holder.stubs(:custom_header_expanded).returns('my custom header')
     @controller.stubs(:boxes_holder).returns(holder)
@@ -22,7 +23,8 @@ class BoxesHelperTest &lt; ActionView::TestCase
   should 'include profile-specific footer' do
     holder = mock
-    holder.stubs(:boxes).returns([])
+    holder.stubs(:boxes).returns(boxes = [])
+    boxes.stubs(:with_position).returns([])
     holder.stubs(:boxes_limit).returns(0)
     holder.stubs(:custom_footer_expanded).returns('my custom footer')
     @controller.stubs(:boxes_holder).returns(holder)
@@ -285,6 +285,37 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert_equal [c1,c3], c.reload.children
   end
+  should "return activities comments as a thread" do
+    person = fast_create(Person)
+    a = TextileArticle.create!(:profile => person, :name => 'My article', :body => 'Article body')
+    c0 = Comment.create!(:source => a, :body => 'My comment', :author => person)
+    c1 = Comment.create!(:reply_of_id => c0.id, :source => a, :body => 'bla', :author => person)
+    c2 = Comment.create!(:reply_of_id => c1.id, :source => a, :body => 'bla', :author => person)
+    c3 = Comment.create!(:reply_of_id => c0.id, :source => a, :body => 'bla', :author => person)
+    c4 = Comment.create!(:source => a, :body => 'My comment', :author => person)
+    result = a.activity.comments
+    assert_equal c0, result[0]
+    assert_equal [c1, c3], result[0].replies
+    assert_equal [c2], result[0].replies[0].replies
+    assert_equal c4, result[1]
+    assert result[1].replies.empty?
+  end
+
+  should "return activities comments when some comment on thread is spam and not display its replies" do
+    person = fast_create(Person)
+    a = TextileArticle.create!(:profile => person, :name => 'My article', :body => 'Article body')
+    c0 = Comment.create(:source => a, :body => 'Root comment', :author => person)
+    c1 = Comment.create(:reply_of_id => c0.id, :source => a, :body => 'c1', :author => person)
+    c2 = Comment.create(:source => a, :body => 'c2', :author => person)
+    spam = Comment.create(:spam => true, :reply_of_id => c2.id, :source => a, :body => 'spam', :author => person)
+    spam_reply = Comment.create(:reply_of_id => spam.id, :source => a, :body => 'spam reply', :author => person)
+    result = a.activity.comments
+    assert_equal c0, result[0]
+    assert_equal [c1], result[0].replies.without_spam
+    assert_equal c2, result[1]
+    assert_equal [], result[1].replies.without_spam
+  end
+
   should 'provide author url for authenticated user' do
     author = Person.new
     author.expects(:url).returns('http://blabla.net/author')
@@ -389,6 +420,7 @@ class CommentTest &lt; ActiveSupport::TestCase
   end
   should 'be able to select non-spam comments' do
+    Comment.destroy_all
     c1 = fast_create(Comment)
     c2 = fast_create(Comment, :spam => false)
     c3 = fast_create(Comment, :spam => true)
@@ -660,6 +692,7 @@ class CommentTest &lt; ActiveSupport::TestCase
   end
   should 'be able to select non-reply comments' do
+    Comment.destroy_all
     c1 = fast_create(Comment)
     c2 = fast_create(Comment, :reply_of_id => c1.id)
     c3 = fast_create(Comment, :reply_of_id => c2.id)
@@ -783,6 +783,18 @@ class EnvironmentTest &lt; ActiveSupport::TestCase
     assert role2.valid?
   end
+  should 'destroy roles when its environment is destroyed' do
+    e1 = fast_create(Environment)
+    role1 = Role.create!(:name => 'test_role', :environment => e1, :key => 'a_member')
+    e2 = fast_create(Environment)
+    role2 = Role.create!(:name => 'test_role', :environment => e2, :key => 'a_member')
+
+    e2.destroy
+
+    assert_nothing_raised {Role.find(role1.id)}
+    assert_raise(ActiveRecord::RecordNotFound) {Role.find(role2.id)}
+  end
+
   should 'have a help_message_to_add_enterprise attribute' do
     env = Environment.new
@@ -88,4 +88,9 @@ class LinkListBlockTest &lt; ActiveSupport::TestCase
     assert_equivalent LinkListBlock::TARGET_OPTIONS.map {|t|t[1]}, ['_self', '_blank', '_new']
   end
+  should 'link with title' do
+    l = LinkListBlock.new
+    assert_match /title="mytitle"/, l.link_html({:name => 'mylink', :address => '/myaddress', :title => 'mytitle'})
+  end
+
 end
@@ -15,7 +15,7 @@ class MacroTest &lt; ActiveSupport::TestCase
   def setup
     @macro = Plugin1::Macro.new
-    @macro_element = Nokogiri::HTML(MACRO).css('.macro').first
+    @macro_element = Hpricot(MACRO).search('.macro').first
   end
   attr_reader :macro, :macro_element
@@ -1462,7 +1462,7 @@ class ProfileTest &lt; ActiveSupport::TestCase
   should 'list events by month' do
     profile = fast_create(Profile)
-    today = Date.today
+    today = Date.new(2014, 03, 2)
     yesterday_event = Event.new(:name => 'Joao Birthday', :start_date => today - 1.day)
     today_event = Event.new(:name => 'Ze Birthday', :start_date => today)
     tomorrow_event = Event.new(:name => 'Mane Birthday', :start_date => today + 1.day)
@@ -1693,6 +1693,28 @@ class ProfileTest &lt; ActiveSupport::TestCase
     assert_equal 1, community.members_count
   end
+  should 'order members by name alphabetically considering special characters' do
+    community = fast_create(Community)
+
+    community.add_member(create_user('José').person)
+    community.add_member(create_user('João').person)
+    community.add_member(create_user('Mariana').person)
+    members = community.members_by_name
+
+    assert_equal ["João", "José", "Mariana"], members.map(&:name)
+  end
+
+  should 'order members by name alphabetically considering upper and lower cases' do
+    community = fast_create(Community)
+
+    community.add_member(create_user('mariana').person)
+    community.add_member(create_user('João').person)
+    community.add_member(create_user('guest').person)
+    members = community.members_by_name
+
+    assert_equal ["guest", "João", "mariana"], members.map(&:name)
+  end
+
   should 'know if url is the profile homepage' do
     profile = fast_create(Profile)
@@ -11,5 +11,6 @@ Rails.configuration.to_prepare do
       type, id = (self.target_type == 'Article' ? ['Article', self.target_id] : [self.class.to_s, self.id])
       "source_type = '#{type}' AND source_id = '#{id}' AND spam IS NOT TRUE AND reply_of_id IS NULL"
     end
+
   end
 end
	@@ -70,7 +70,7 @@ class BoxOrganizerController < ApplicationController		@@ -70,7 +70,7 @@ class BoxOrganizerController < ApplicationController
70	else	70	else
71	@center_block_types = (Box.acceptable_center_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => 1)	71	@center_block_types = (Box.acceptable_center_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => 1)
72	@side_block_types = (Box.acceptable_side_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => [2,3])	72	@side_block_types = (Box.acceptable_side_blocks & available_blocks) + plugins.dispatch(:extra_blocks, :type => boxes_holder.class, :position => [2,3])
73	- @boxes = boxes_holder.boxes	73	+ @boxes = boxes_holder.boxes.with_position
74	render :action => 'add_block', :layout => false	74	render :action => 'add_block', :layout => false
75	end	75	end
76	end	76	end
	@@ -2,7 +2,7 @@ class ProfileMembersController < MyProfileController		@@ -2,7 +2,7 @@ class ProfileMembersController < MyProfileController
2	protect 'manage_memberships', :profile	2	protect 'manage_memberships', :profile
3		3
4	def index	4	def index
5	- @members = profile.members	5	+ @members = profile.members_by_name
6	@member_role = environment.roles.find_by_name('member')	6	@member_role = environment.roles.find_by_name('member')
7	end	7	end
8		8
	@@ -67,7 +67,7 @@ class ProfileController < PublicController		@@ -67,7 +67,7 @@ class ProfileController < PublicController
67		67
68	def members	68	def members
69	if is_cache_expired?(profile.members_cache_key(params))	69	if is_cache_expired?(profile.members_cache_key(params))
70	- @members = profile.members.includes(relations_to_include).paginate(:per_page => members_per_page, :page => params[:npage])	70	+ @members = profile.members_by_name.includes(relations_to_include).paginate(:per_page => members_per_page, :page => params[:npage])
71	end	71	end
72	end	72	end
73		73
	@@ -1415,16 +1415,16 @@ module ApplicationHelper		@@ -1415,16 +1415,16 @@ module ApplicationHelper
1415	end	1415	end
1416		1416
1417	def convert_macro(html, source)	1417	def convert_macro(html, source)
1418	- doc = Nokogiri::HTML(html)	1418	+ doc = Hpricot(html)
1419	#TODO This way is more efficient but do not support macro inside of	1419	#TODO This way is more efficient but do not support macro inside of
1420	# macro. You must parse them from the inside-out in order to enable	1420	# macro. You must parse them from the inside-out in order to enable
1421	# that.	1421	# that.
1422	- doc.css('.macro').each do \|macro\|	1422	+ doc.search('.macro').each do \|macro\|
1423	macro_name = macro['data-macro']	1423	macro_name = macro['data-macro']
1424	result = @plugins.parse_macro(macro_name, macro, source)	1424	result = @plugins.parse_macro(macro_name, macro, source)
1425	- macro.content = result.kind_of?(Proc) ? self.instance_eval(&result) : result	1425	+ macro.inner_html = result.kind_of?(Proc) ? self.instance_eval(&result) : result
1426	end	1426	end
1427	- CGI.unescapeHTML(doc.xpath('//body/*').to_s)	1427	+ doc.html
1428	end	1428	end
1429		1429
1430	def default_folder_for_image_upload(profile)	1430	def default_folder_for_image_upload(profile)
	@@ -39,7 +39,7 @@ module BoxesHelper		@@ -39,7 +39,7 @@ module BoxesHelper
39	end	39	end
40		40
41	def display_boxes(holder, main_content)	41	def display_boxes(holder, main_content)
42	- boxes = holder.boxes.first(holder.boxes_limit)	42	+ boxes = holder.boxes.with_position.first(holder.boxes_limit)
43	content = boxes.reverse.map { \|item\| display_box(item, main_content) }.join("\n")	43	content = boxes.reverse.map { \|item\| display_box(item, main_content) }.join("\n")
44	content = main_content if (content.blank?)	44	content = main_content if (content.blank?)
45		45
	@@ -7,6 +7,8 @@ class Box < ActiveRecord::Base		@@ -7,6 +7,8 @@ class Box < ActiveRecord::Base
7		7
8	include Noosfero::Plugin::HotSpot	8	include Noosfero::Plugin::HotSpot
9		9
		10	+ named_scope :with_position, :conditions => ['boxes.position > 0']
		11	+
10	def environment	12	def environment
11	owner ? (owner.kind_of?(Environment) ? owner : owner.environment) : nil	13	owner ? (owner.kind_of?(Environment) ? owner : owner.environment) : nil
12	end	14	end
	@@ -190,7 +190,7 @@ class Environment < ActiveRecord::Base		@@ -190,7 +190,7 @@ class Environment < ActiveRecord::Base
190	has_many :states	190	has_many :states
191	has_many :cities	191	has_many :cities
192		192
193	- has_many :roles	193	+ has_many :roles, :dependent => :destroy
194		194
195	has_many :qualifiers	195	has_many :qualifiers
196	has_many :certifiers	196	has_many :certifiers
	@@ -65,7 +65,7 @@ class LinkListBlock < Block		@@ -65,7 +65,7 @@ class LinkListBlock < Block
65	def link_html(link)	65	def link_html(link)
66	klass = 'icon-' + link[:icon] if link[:icon]	66	klass = 'icon-' + link[:icon] if link[:icon]
67	sanitize_link(	67	sanitize_link(
68	- link_to(link[:name], expand_address(link[:address]), :target => link[:target], :class => klass)	68	+ link_to(link[:name], expand_address(link[:address]), :target => link[:target], :class => klass, :title => link[:title])
69	)	69	)
70	end	70	end
71		71
1	-<% collection = @collection == :profile_admins ? profile.admins : profile.members %>	1	+<% collection = @collection == :profile_admins ? profile.admins : profile.members_by_name %>
2	<% title = @title ? @title : _('Current members') %>	2	<% title = @title ? @title : _('Current members') %>
3	<% remove_action = @remove_action ? @remove_action : {:action => 'unassociate'} %>	3	<% remove_action = @remove_action ? @remove_action : {:action => 'unassociate'} %>
4		4
		1	+noosfero (0.46.1) unstable; urgency=low
		2	+
		3	+ * Bugfixes release
		4	+
		5	+ -- Daniela Soares Feitosa <daniela@colivre.coop.br> Fri, 07 Mar 2014 10:33:11 +0000
		6	+
1	noosfero (0.46.0) unstable; urgency=low	7	noosfero (0.46.0) unstable; urgency=low
2		8
3	* New features release	9	* New features release