ActionItem111: made the changes to allow the links be shown based on witch permissions the user have

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@724 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem111: made the changes to allow the links be shown based on witch permissions the user have
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@724 3f533792-8f58-4932-b0fe-aaf55b0a4547
MoisesMachado
1 parent 6a007a4b
Showing 16 changed files with 182 additions and 17 deletions Show diff stats
app/controllers/environment_admin/environment_role_manager_controller.rb
app/controllers/profile_admin/profile_members_controller.rb
app/controllers/public/account_controller.rb
app/helpers/application_helper.rb
app/helpers/environment_role_manager_helper.rb
app/models/environment.rb
app/models/profile.rb
app/views/environment_role_manager/affiliate.rhtml
app/views/environment_role_manager/change_role.rhtml
app/views/environment_role_manager/index.rhtml
app/views/environment_role_manager/make_admin.rhtml
app/views/layouts/application.rhtml
app/views/role/_form.rhtml
app/views/role/new.rhtml
public/stylesheets/menu.css
test/functional/environment_role_manager_controller_test.rb
@@ -0,0 +1,67 @@
+class EnvironmentRoleManagerController < ApplicationController
+  def index
+    @admins = Person.find(:all, :conditions => ['role_assignments.resource_type = ?', 'Environment'], :include => :role_assignments )
+  end
+
+  def change_roles
+    @admin = Person.find(params[:id])
+    @roles = Role.find(:all).select{ |r| r.has_kind?(:environment) }
+  end  
+
+  def update_roles
+    @roles = params[:roles] ? Role.find(params[:roles]) : []
+    @person = Person.find(params[:person])
+    if @person.define_roles(@roles, environment)
+      flash[:notice] = _('Roles successfuly updated')
+    else
+      flash[:notice] = _('Couldn\'t change the roles')
+    end
+    redirect_to :action => :index
+  end
+  
+  def change_role
+    @roles = Role.find(:all).select{ |r| r.has_kind?(:environment) }
+    @admin = Person.find(params[:id])
+    @associations = RoleAssignment.find(:all, :conditions => {:accessor_id => @admin,
+                                        :accessor_type => @admin.class.base_class.name, 
+                                        :resource_id => environment, 
+                                        :resource_type => environment.class.base_class.name})
+  end
+
+  def add_role
+    @person = Person.find(params[:person])
+    @role = Role.find(params[:role])
+    if environment.affiliate(@person, @role)
+      redirect_to :action => 'index'
+    else
+      @admin = Person.find(params[:person])
+      @roles = Role.find(:all).select{ |r| r.has_kind?(:environment) }
+      render :action => 'affiliate'
+    end
+  end
+
+  def remove_role
+    @association = RoleAssignment.find(params[:id])
+    if @association.destroy
+      flash[:notice] = _('Member succefully unassociated')
+    else
+      flash[:notice] = _('Failed to unassociate member')
+    end
+    redirect_to :aciton => 'index'
+  end
+
+  def unassociate
+    @association = RoleAssignment.find(params[:id])
+    if @association.destroy
+      flash[:notice] = _('Member succefully unassociated')
+    else
+      flash[:notice] = _('Failed to unassociate member')
+    end
+    redirect_to :aciton => 'index'
+  end
+
+  def make_admin
+    @people = Person.find(:all)
+    @roles = Role.find(:all).select{|r|r.has_kind?(:environment)}
+  end
+end
@@ -13,9 +13,9 @@ class ProfileMembersController &lt; ProfileAdminController
     @roles = Role.find(params[:roles])
     @person = Person.find(params[:person])
     if @person.define_roles(@roles, profile)
-      flash[:notice] = 'Roles successfuly updated'
+      flash[:notice] = _('Roles successfuly updated')
     else
-      flash[:notice] = 'Couldn\'t change the roles'
+      flash[:notice] = _('Couldn\'t change the roles')
     end
     redirect_to :action => :index
   end
@@ -16,7 +16,8 @@ class AccountController &lt; PublicController
         self.current_user.remember_me
         cookies[:auth_token] = { :value => self.current_user.remember_token , :expires => self.current_user.remember_token_expires_at }
       end
-      redirect_back_or_default(:controller => '/account', :action => 'index')
+#      redirect_back_or_default(:controller => '/account', :action => 'index')
+      redirect_back_or_default(homepage_path(:profile => current_user.login))
       flash[:notice] = _("Logged in successfully")
     else
       flash[:notice] = _('Incorrect username or password')
@@ -117,7 +117,8 @@ module ApplicationHelper
     links = [
        ( link_to_homepage(current_user.login) ),
        ( link_to(_('My account'), { :controller => 'account' }) ),
-       ( link_to(_('Admin'), { :controller => 'admin_panel' }) ),
+       ( link_to_myprofile _('My Enterprises'), {:controller => 'membership_editor'} ),
+       ( link_to(_('Admin'), { :controller => 'admin_panel' }) if current_user.person.role_assignments.map{|ra| ra.role.permissions}.any?{|ps|ps.any?{|p|ActiveRecord::Base::PERMISSIONS[:environment].keys.include?(p)}}),
     ].join("\n")
     content_tag('span', links, :id => 'user_links')
   end
@@ -171,33 +172,47 @@ module ApplicationHelper
     ]
   end
-  def profile_links
+  def person_links
     links = [
       [(link_to_myprofile _('Edit visual design'), :controller => 'profile_editor', :action => 'design_editor'), 'edit_profile_design', profile],
-      [(link_to_myprofile _('Edit informations'), :controller => 'profile_editor'), 'edit_profile', profile],
+      [(link_to_myprofile _('Edit profile'), :controller => 'profile_editor'), 'edit_profile', profile],
       [(link_to_myprofile _('Manage content'), :controller => 'cms'), 'post_content', profile],
     ]
-    if profile.kind_of?(Enterprise)
-      links << [(link_to_myprofile _('Exclude'), :controller => 'enterprise_editor', :action => 'destroy'), 'edit_profile', profile]
-    else
-      links
-    end
+  end
+
+  
+  def enterprise_links
+    links = [
+      [(link_to_myprofile _('Edit visual design'), :controller => 'profile_editor', :action => 'design_editor'), 'edit_profile_design', profile],
+      [(link_to_myprofile _('Edit informations'), :controller => 'profile_editor'), 'edit_profile', profile],
+      [(link_to_myprofile _('Manage content'), :controller => 'cms'), 'post_content', profile],
+      [(link_to_myprofile _('Exclude'), :controller => 'enterprise_editor', :action => 'destroy'), 'edit_profile', profile],
+    ]
   end
   #FIXME: find a way of accessing environment from here
   def user_options
+    profile = params[:profile]
     case params[:controller]
       when 'admin_panel'
         admin_links
       when 'membership_editor'
         membership_links
       when 'profile_editor'
-        profile_links
+        if profile.kind_of?(Enterprise)
+          enterprise_links
+        elsif profile.kind_of?(Person)
+          person_links
+        else
+          []
+        end
+      when 'content_viewer'
+        person_links
       else
         []
-    end.map{|l| link_if_permitted(l[0], l[1], l[3]) }
+    end.map{|l| link_if_permitted(l[0], l[1], l[2]) }
   end
   def footer
@@ -281,5 +296,4 @@ module ApplicationHelper
     ]
     select_tag "#{object}[#{method}]", options_for_select(options, @page.filter_type || Comatose.config.default_filter), { :id=> "#{object}_#{method}" }.merge(html_options)
   end
-
 end
@@ -0,0 +1,2 @@
+module EnvironmentRoleManagerHelper
+end
@@ -3,6 +3,14 @@
 # domains.
 class Environment < ActiveRecord::Base
+  PERMISSIONS[:environment] = {
+    'edit_environment_features' => N_('Edit environment features'),
+    'edit_environment_design' => N_('Edit environment design'),
+    'manage_environment_categories' => N_('Manage environment categories'),
+    'manage_environment_roles' => N_('Manage environment roles'),
+    'manage_environment_validators' => N_('Manage environment validators'),
+  }
+ 
   # returns the available features for a Environment, in the form of a
   # hash, with pairs in the form <tt>'feature_name' => 'Feature name'</tt>.
   def self.available_features
@@ -8,6 +8,7 @@ class Profile &lt; ActiveRecord::Base
     'destroy_profile' => N_('Destroy profile'),
     'manage_memberships' => N_('Manage memberships'),
     'post_content' => N_('Post content'),
+    'edit_profile_design' => N_('Edit profile design'),
   }
   after_create do |profile|
@@ -0,0 +1,9 @@
+<h2> <%= @member.name %> </h2>
+
+<% form_tag( {:action => 'give_role'}, {:method => :post}) do %>
+  <%= select_tag 'role', options_for_select(@roles.map{|r|[r.name,r.id]})  %>
+  <%= hidden_field_tag 'person', current_user.person.id %>
+  <%= submit_tag _('Affiliate') %>
+<% end %>
+
+<%= link_to _('Back'), :action => 'index' %>
@@ -0,0 +1,13 @@
+<%= _('Changing role of %s') % @admin.name %>
+
+<% labelled_form_for :member, @admin, :url => {:action => 'update_roles'} do |f| %>
+  
+  <%= _('Roles: ') %> <br>
+  <% @roles.each do |r| %>
+    <%= labelled_form_field(r.name, (check_box_tag "roles[]", r.id, @admin.role_assignments.map{|ra|ra.role}.include?(r))) %>
+  <% end %>
+  <%= hidden_field_tag 'person', @admin.id %>
+
+  <%= submit_tag  _('Save changes') %>
+  <%= link_to _('Cancel'), :action => 'index' %>
+<% end %>
@@ -0,0 +1,13 @@
+<h2> <%= _('Listing Administrators') %> </h2>
+
+<%= link_to _('Make new admin'), :action => 'make_admin' %>
+
+<ul>
+  <% @admins.each do |a| %>
+    <li> <%= a.name %> 
+         <%= link_to _('Edit member role'), :action => 'change_role', :id => a %> 
+         <%= link_to _('Remove member'), :action => 'unassociate', :id => a %></li>
+  <% end %>
+</ul>
+
+<%= link_to _('Back'), :controller => 'admin_panel' %>
@@ -0,0 +1,13 @@
+<h2> <% _('Make new admin') %> </h2>
+
+<% labelled_form_for :person, @person, :url => {:action => 'update_roles'} do |f| %>
+  <%= _('Admin') %> <br>
+  <% @people.each do |p| %>
+    <%= labelled_form_field(p.name, (radio_button_tag "person", p.id)) %>
+  <% end %>
+    <%= _('Roles: ') %> <br>
+  <% @roles.each do |r| %>
+    <%= labelled_form_field(r.name, (check_box_tag "roles[]", r.id)) %>
+  <% end %>
+<%= submit_tag _('Make') %>
+<% end %>
@@ -71,7 +71,7 @@
             <%= @category.full_name %>
 	<% else @category %>
         <div id='user_options'>
-               <%= user_options %>
+	  <%= user_options.join(' ') %>
 	</div><!-- id='user_options' -->
         <% end %>
 	</div>
@@ -5,7 +5,7 @@
   <%= f.text_field :name %>
   <%= _('Permissions: ') %> <br>
-  <% Profile::PERMISSIONS[:profile].keys.each do |p| %>
+  <% permissions.keys.each do |p| %>
     <%= labelled_form_field(permission_name(p), (check_box_tag "role[permissions][]", p, @role.has_permission?(p))) %>
   <% end %>
 <h2> <%= _('New Role') %> </h2>
-<%= render :partial => 'form', :locals => { :mode => :new } %>
+<% ActiveRecord::Base::PERMISSIONS.keys.each do |perm_class| %>
+    <h3> <%= perm_class %> </h3>
+  <%= render :partial => 'form', :locals => { :mode => :new, :permissions => ActiveRecord::Base::PERMISSIONS[perm_class] } %>
+<% end %>
@@ -358,3 +358,6 @@ li#category4 ul li a:hover {
   color: black;
 }
+div#user_options *{
+  color: white;
+}
@@ -0,0 +1,18 @@
+require File.dirname(__FILE__) + '/../test_helper'
+require 'environment_role_manager_controller'
+
+# Re-raise errors caught by the controller.
+class EnvironmentRoleManagerController; def rescue_action(e) raise e end; end
+
+class EnvironmentRoleManagerControllerTest < Test::Unit::TestCase
+  def setup
+    @controller = EnvironmentRoleManagerController.new
+    @request    = ActionController::TestRequest.new
+    @response   = ActionController::TestResponse.new
+  end
+
+  # Replace this with your real tests.
+  def test_truth
+    assert true
+  end
+end
@@ -0,0 +1,67 @@		@@ -0,0 +1,67 @@
	1	+class EnvironmentRoleManagerController < ApplicationController
	2	+ def index
	3	+ @admins = Person.find(:all, :conditions => ['role_assignments.resource_type = ?', 'Environment'], :include => :role_assignments )
	4	+ end
	5	+
	6	+ def change_roles
	7	+ @admin = Person.find(params[:id])
	8	+ @roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }
	9	+ end
	10	+
	11	+ def update_roles
	12	+ @roles = params[:roles] ? Role.find(params[:roles]) : []
	13	+ @person = Person.find(params[:person])
	14	+ if @person.define_roles(@roles, environment)
	15	+ flash[:notice] = _('Roles successfuly updated')
	16	+ else
	17	+ flash[:notice] = _('Couldn\'t change the roles')
	18	+ end
	19	+ redirect_to :action => :index
	20	+ end
	21	+
	22	+ def change_role
	23	+ @roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }
	24	+ @admin = Person.find(params[:id])
	25	+ @associations = RoleAssignment.find(:all, :conditions => {:accessor_id => @admin,
	26	+ :accessor_type => @admin.class.base_class.name,
	27	+ :resource_id => environment,
	28	+ :resource_type => environment.class.base_class.name})
	29	+ end
	30	+
	31	+ def add_role
	32	+ @person = Person.find(params[:person])
	33	+ @role = Role.find(params[:role])
	34	+ if environment.affiliate(@person, @role)
	35	+ redirect_to :action => 'index'
	36	+ else
	37	+ @admin = Person.find(params[:person])
	38	+ @roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }
	39	+ render :action => 'affiliate'
	40	+ end
	41	+ end
	42	+
	43	+ def remove_role
	44	+ @association = RoleAssignment.find(params[:id])
	45	+ if @association.destroy
	46	+ flash[:notice] = _('Member succefully unassociated')
	47	+ else
	48	+ flash[:notice] = _('Failed to unassociate member')
	49	+ end
	50	+ redirect_to :aciton => 'index'
	51	+ end
	52	+
	53	+ def unassociate
	54	+ @association = RoleAssignment.find(params[:id])
	55	+ if @association.destroy
	56	+ flash[:notice] = _('Member succefully unassociated')
	57	+ else
	58	+ flash[:notice] = _('Failed to unassociate member')
	59	+ end
	60	+ redirect_to :aciton => 'index'
	61	+ end
	62	+
	63	+ def make_admin
	64	+ @people = Person.find(:all)
	65	+ @roles = Role.find(:all).select{\|r\|r.has_kind?(:environment)}
	66	+ end
	67	+end
	@@ -13,9 +13,9 @@ class ProfileMembersController < ProfileAdminController		@@ -13,9 +13,9 @@ class ProfileMembersController < ProfileAdminController
13	@roles = Role.find(params[:roles])	13	@roles = Role.find(params[:roles])
14	@person = Person.find(params[:person])	14	@person = Person.find(params[:person])
15	if @person.define_roles(@roles, profile)	15	if @person.define_roles(@roles, profile)
16	- flash[:notice] = 'Roles successfuly updated'	16	+ flash[:notice] = _('Roles successfuly updated')
17	else	17	else
18	- flash[:notice] = 'Couldn\'t change the roles'	18	+ flash[:notice] = _('Couldn\'t change the roles')
19	end	19	end
20	redirect_to :action => :index	20	redirect_to :action => :index
21	end	21	end
@@ -0,0 +1,2 @@		@@ -0,0 +1,2 @@
	1	+module EnvironmentRoleManagerHelper
	2	+end
	@@ -3,6 +3,14 @@		@@ -3,6 +3,14 @@
3	# domains.	3	# domains.
4	class Environment < ActiveRecord::Base	4	class Environment < ActiveRecord::Base
5		5
		6	+ PERMISSIONS[:environment] = {
		7	+ 'edit_environment_features' => N_('Edit environment features'),
		8	+ 'edit_environment_design' => N_('Edit environment design'),
		9	+ 'manage_environment_categories' => N_('Manage environment categories'),
		10	+ 'manage_environment_roles' => N_('Manage environment roles'),
		11	+ 'manage_environment_validators' => N_('Manage environment validators'),
		12	+ }
		13	+
6	# returns the available features for a Environment, in the form of a	14	# returns the available features for a Environment, in the form of a
7	# hash, with pairs in the form <tt>'feature_name' => 'Feature name'</tt>.	15	# hash, with pairs in the form <tt>'feature_name' => 'Feature name'</tt>.
8	def self.available_features	16	def self.available_features
	@@ -8,6 +8,7 @@ class Profile < ActiveRecord::Base		@@ -8,6 +8,7 @@ class Profile < ActiveRecord::Base
8	'destroy_profile' => N_('Destroy profile'),	8	'destroy_profile' => N_('Destroy profile'),
9	'manage_memberships' => N_('Manage memberships'),	9	'manage_memberships' => N_('Manage memberships'),
10	'post_content' => N_('Post content'),	10	'post_content' => N_('Post content'),
		11	+ 'edit_profile_design' => N_('Edit profile design'),
11	}	12	}
12		13
13	after_create do \|profile\|	14	after_create do \|profile\|
@@ -0,0 +1,9 @@		@@ -0,0 +1,9 @@
	1	+<h2> <%= @member.name %> </h2>
	2	+
	3	+<% form_tag( {:action => 'give_role'}, {:method => :post}) do %>
	4	+ <%= select_tag 'role', options_for_select(@roles.map{\|r\|[r.name,r.id]}) %>
	5	+ <%= hidden_field_tag 'person', current_user.person.id %>
	6	+ <%= submit_tag _('Affiliate') %>
	7	+<% end %>
	8	+
	9	+<%= link_to _('Back'), :action => 'index' %>
@@ -0,0 +1,13 @@		@@ -0,0 +1,13 @@
	1	+<%= _('Changing role of %s') % @admin.name %>
	2	+
	3	+<% labelled_form_for :member, @admin, :url => {:action => 'update_roles'} do \|f\| %>
	4	+
	5	+ <%= _('Roles: ') %> <br>
	6	+ <% @roles.each do \|r\| %>
	7	+ <%= labelled_form_field(r.name, (check_box_tag "roles[]", r.id, @admin.role_assignments.map{\|ra\|ra.role}.include?(r))) %>
	8	+ <% end %>
	9	+ <%= hidden_field_tag 'person', @admin.id %>
	10	+
	11	+ <%= submit_tag _('Save changes') %>
	12	+ <%= link_to _('Cancel'), :action => 'index' %>
	13	+<% end %>
@@ -0,0 +1,13 @@		@@ -0,0 +1,13 @@
	1	+<h2> <%= _('Listing Administrators') %> </h2>
	2	+
	3	+<%= link_to _('Make new admin'), :action => 'make_admin' %>
	4	+
	5	+<ul>
	6	+ <% @admins.each do \|a\| %>
	7	+ <li> <%= a.name %>
	8	+ <%= link_to _('Edit member role'), :action => 'change_role', :id => a %>
	9	+ <%= link_to _('Remove member'), :action => 'unassociate', :id => a %></li>
	10	+ <% end %>
	11	+</ul>
	12	+
	13	+<%= link_to _('Back'), :controller => 'admin_panel' %>
@@ -0,0 +1,13 @@		@@ -0,0 +1,13 @@
	1	+<h2> <% _('Make new admin') %> </h2>
	2	+
	3	+<% labelled_form_for :person, @person, :url => {:action => 'update_roles'} do \|f\| %>
	4	+ <%= _('Admin') %> <br>
	5	+ <% @people.each do \|p\| %>
	6	+ <%= labelled_form_field(p.name, (radio_button_tag "person", p.id)) %>
	7	+ <% end %>
	8	+ <%= _('Roles: ') %> <br>
	9	+ <% @roles.each do \|r\| %>
	10	+ <%= labelled_form_field(r.name, (check_box_tag "roles[]", r.id)) %>
	11	+ <% end %>
	12	+<%= submit_tag _('Make') %>
	13	+<% end %>
	@@ -71,7 +71,7 @@		@@ -71,7 +71,7 @@
71	<%= @category.full_name %>	71	<%= @category.full_name %>
72	<% else @category %>	72	<% else @category %>
73	<div id='user_options'>	73	<div id='user_options'>
74	- <%= user_options %>	74	+ <%= user_options.join(' ') %>
75	</div><!-- id='user_options' -->	75	</div><!-- id='user_options' -->
76	<% end %>	76	<% end %>
77	</div>	77	</div>