[comments-refactor-review] Encapsulating comment update check

Rodrigo Souto
1 parent cff3d5b7
Showing 2 changed files with 24 additions and 0 deletions Show diff stats
app/models/comment.rb
test/unit/comment_test.rb
@@ -269,4 +269,8 @@ class Comment &lt; ActiveRecord::Base
     user == profile || user.has_permission?(:moderate_comments, profile)
   end
+  def can_be_updated_by?(user)
+    user.present? && user == author
+  end
+
 end
@@ -670,6 +670,26 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert comment.can_be_marked_as_spam_by?(user)
   end
+  should 'not be able to update comment without user' do
+    comment = Comment.new
+
+    assert !comment.can_be_updated_by?(nil)
+  end
+
+  should 'not be able to update comment' do
+    user = Person.new
+    comment = Comment.new
+
+    assert !comment.can_be_updated_by?(user)
+  end
+
+  should 'be able to update comment if is the author' do
+    user = Person.new
+    comment = Comment.new(:author => user)
+
+    assert comment.can_be_updated_by?(user)
+  end
+
   private
   def create_comment(args = {})
	@@ -269,4 +269,8 @@ class Comment < ActiveRecord::Base		@@ -269,4 +269,8 @@ class Comment < ActiveRecord::Base
269	user == profile \|\| user.has_permission?(:moderate_comments, profile)	269	user == profile \|\| user.has_permission?(:moderate_comments, profile)
270	end	270	end
271		271
		272	+ def can_be_updated_by?(user)
		273	+ user.present? && user == author
		274	+ end
		275	+
272	end	276	end
	@@ -670,6 +670,26 @@ class CommentTest < ActiveSupport::TestCase		@@ -670,6 +670,26 @@ class CommentTest < ActiveSupport::TestCase
670	assert comment.can_be_marked_as_spam_by?(user)	670	assert comment.can_be_marked_as_spam_by?(user)
671	end	671	end
672		672
		673	+ should 'not be able to update comment without user' do
		674	+ comment = Comment.new
		675	+
		676	+ assert !comment.can_be_updated_by?(nil)
		677	+ end
		678	+
		679	+ should 'not be able to update comment' do
		680	+ user = Person.new
		681	+ comment = Comment.new
		682	+
		683	+ assert !comment.can_be_updated_by?(user)
		684	+ end
		685	+
		686	+ should 'be able to update comment if is the author' do
		687	+ user = Person.new
		688	+ comment = Comment.new(:author => user)
		689	+
		690	+ assert comment.can_be_updated_by?(user)
		691	+ end
		692	+
673	private	693	private
674		694
675	def create_comment(args = {})	695	def create_comment(args = {})