contact: Send message for non logged users

Braulio Bhavamitra
1 parent fe6c058f
Showing 3 changed files with 26 additions and 10 deletions Show diff stats
app/controllers/public/contact_controller.rb
app/views/contact/new.html.erb
test/functional/contact_controller_test.rb
 class ContactController < PublicController
-  before_filter :login_required
-
   needs_profile
   def new
-    @contact
+    @contact = build_contact
     if request.post? && params[:confirm] == 'true'
-      @contact = user.build_contact(profile, params[:contact])
       @contact.city = (!params[:city].blank? && City.exists?(params[:city])) ? City.find(params[:city]).name : nil
       @contact.state = (!params[:state].blank? && State.exists?(params[:state])) ? State.find(params[:state]).name : nil
       if @contact.deliver
@@ -16,8 +13,17 @@ class ContactController &lt; PublicController
       else
         session[:notice] = _('Contact not sent')
       end
+    end
+  end
+
+  protected
+
+  def build_contact
+    params[:contact] ||= {}
+    if logged_in?
+      user.build_contact profile, params[:contact]
     else
-      @contact = user.build_contact(profile)
+      Contact.new params[:contact].merge(dest: profile)
     end
   end
@@ -13,11 +13,16 @@
   <%= required_fields_message %>
-  <% location_fields = select_city(true) %>
+  <% unless logged_in? %>
+    <%= required f.text_field(:name) %>
+    <%= required f.text_field(:email) %>
+  <% end %>
+  <% location_fields = select_city(true) %>
   <% unless environment.enabled?('disable_select_city_for_contact') || location_fields.blank? %>
     <%= labelled_form_field _('City and state'), location_fields %>
   <% end %>
+
   <%= required f.text_field(:subject) %>
   <%= render :file => 'shared/tiny_mce' %>
@@ -25,5 +30,9 @@
   <%= labelled_form_field check_box(:contact, :receive_a_copy) + _('I want to receive a copy of the message in my e-mail.'), '' %>
-  <%= submit_button(:send, _('Send'), :onclick => "$('confirm').value = 'true'") %>
+  <% unless logged_in? %>
+    <%= recaptcha_tags :ajax => true, :display => {:theme => 'clean'} %>
+  <% end %>
+
+  <%= submit_button(:send, _('Send'), :onclick => "jQuery('#confirm').val('true')") %>
 <% end %>
@@ -90,11 +90,12 @@ class ContactControllerTest &lt; ActionController::TestCase
     assert_no_tag :tag => 'select', :attributes => {:name => 'state'}
   end
-  should 'not allow if not logged' do
+  should 'show name, email and captcha if not logged' do
     logout
     get :new, :profile => profile.identifier
-    assert_response :redirect
-    assert_redirected_to :controller => 'account', :action => 'login'
+    assert_tag :tag => 'input', :attributes => {:name => 'contact[name]'}
+    assert_tag :tag => 'input', :attributes => {:name => 'contact[email]'}
+    assert_tag :attributes => {id: 'dynamic_recaptcha'}
   end
   should 'identify sender' do