[Mezuro] Removing metric_ids and list metrics from BaseTool

Carlos Morais + Paulo Meirelles · Carlos Morais
1 parent 64f6a393
Showing 5 changed files with 22 additions and 32 deletions Show diff stats
plugins/mezuro/lib/kalibro/client/base_tool_client.rb
plugins/mezuro/lib/kalibro/client/metrics_client.rb
plugins/mezuro/lib/mezuro_plugin/configuration_content.rb
plugins/mezuro/test/unit/mezuro_plugin/configuration_content_test.rb
plugins/mezuro/views/cms/mezuro_plugin/_configuration_content.html.erb
@@ -11,7 +11,6 @@ class Kalibro::Client::BaseToolClient
   def base_tool(name)
     hash = @port.request(:get_base_tool, {:base_tool_name => name})[:base_tool]
     Kalibro::Entities::BaseTool.from_hash(hash)
-    #FIXME dando erro
   end
 end
@@ -1,8 +0,0 @@
-class Kalibro::Client::MetricsClient
-
-  def self.all_metrics
-    [Kalibro::Entities::Metric.new("LOC", "class", "Lines of code", 1), 
-    Kalibro::Entities::Metric.new("LCOM", "class", "Lack of cohesion", 2)]
-  end
-
-end
 class MezuroPlugin::ConfigurationContent < Article
-  attr_accessor :metric_ids
-
   def self.short_description
     'Kalibro configuration'
   end
@@ -23,11 +23,6 @@ class ConfigurationContentTest &lt; ActiveSupport::TestCase
     assert_equal 'Sets of thresholds to interpret metrics', MezuroPlugin::ConfigurationContent.description
   end
-  should 'accept metric_ids' do
-    @content.metric_ids = [1,5]
-    assert_equal @content.metric_ids, [1,5]
-  end
-
   should 'have an html view' do
     assert_not_nil @content.to_html
   end
 <h1> <%= _(MezuroPlugin::ConfigurationContent.short_description) %> </h1>
 <%
-  begin
-    @configuration = @article.title.nil? ? nil : Kalibro::Client::ConfigurationClient.new.configuration(@article.title)
-  rescue
-    @configuration = nil
-  end 
-  %>
+begin
+  @configuration = @article.title.nil? ? nil : Kalibro::Client::ConfigurationClient.new.configuration(@article.title)
+rescue
+  @configuration = nil
+end 
+%>
 <%= error_messages_for 'kalibro_configuration' %>
@@ -20,13 +20,19 @@
 <%= f.text_field :description %><br/>
 <h3> Metrics </h3>
-<% @tool_names = Kalibro::Client::BaseToolClient.new
-@tool_names.base_tool_names.each do |collector_name|
-  @collector = @tool_names.base_tool(collector_name)
-  #FIXME dando erro
-  @collector.supported_metrics.each do |metric| %>
-    <div class="metric">
-      <%= label_tag "#{metric.name}" %>
-    </div>
-  <% end
-end %>
+<table>
+  <% @tool_names = Kalibro::Client::BaseToolClient.new
+  @tool_names.base_tool_names.each do |collector_name|
+    @collector = @tool_names.base_tool(collector_name)
+    @collector.supported_metrics.each do |metric| %>
+
+      <tr class="metric" title="<%= metric.description %>">
+        <td>
+          <%= check_box_tag metric.name, metric.name, true %>
+          <%= label_tag metric.name %>
+        </td>
+      </tr>
+
+    <% end %>
+  </table>
+<% end %>
	@@ -11,7 +11,6 @@ class Kalibro::Client::BaseToolClient		@@ -11,7 +11,6 @@ class Kalibro::Client::BaseToolClient
11	def base_tool(name)	11	def base_tool(name)
12	hash = @port.request(:get_base_tool, {:base_tool_name => name})[:base_tool]	12	hash = @port.request(:get_base_tool, {:base_tool_name => name})[:base_tool]
13	Kalibro::Entities::BaseTool.from_hash(hash)	13	Kalibro::Entities::BaseTool.from_hash(hash)
14	- #FIXME dando erro
15	end	14	end
16		15
17	end	16	end
	@@ -1,8 +0,0 @@	@@ -1,8 +0,0 @@
1	-class Kalibro::Client::MetricsClient
2	-
3	- def self.all_metrics
4	- [Kalibro::Entities::Metric.new("LOC", "class", "Lines of code", 1),
5	- Kalibro::Entities::Metric.new("LCOM", "class", "Lack of cohesion", 2)]
6	- end
7	-
8	-end
1	class MezuroPlugin::ConfigurationContent < Article	1	class MezuroPlugin::ConfigurationContent < Article
2		2
3	- attr_accessor :metric_ids
4	-
5	def self.short_description	3	def self.short_description
6	'Kalibro configuration'	4	'Kalibro configuration'
7	end	5	end