Force a browser to save file as after clicking a uploaded file link

(ActionItem2829)

Force a browser to save file as after clicking a uploaded file link
(ActionItem2829)
Braulio Bhavamitra · Rodrigo Souto
1 parent bb031599
Showing 5 changed files with 36 additions and 6 deletions Show diff stats
app/controllers/public/content_viewer_controller.rb
app/models/article.rb
app/models/uploaded_file.rb
test/fixtures/files/500.html
test/functional/content_viewer_controller_test.rb
@@ -53,8 +53,9 @@ class ContentViewerController &lt; ApplicationController
     # At this point the page will be showed
     @page.hit
-    unless @page.mime_type == 'text/html' || (@page.image? && params[:view])
+    if @page.download? params[:view]
       headers['Content-Type'] = @page.mime_type
+      headers.merge! @page.download_headers
       data = @page.data
       # TODO test the condition
@@ -70,7 +71,7 @@ class ContentViewerController &lt; ApplicationController
     #FIXME see a better way to do this. It's not need to pass this variable anymore
     @comment = Comment.new
-    
+
     if @page.has_posts?
       posts = if params[:year] and params[:month]
         filter_date = DateTime.parse("#{params[:year]}-#{params[:month]}-01")
@@ -188,7 +188,7 @@ class Article &lt; ActiveRecord::Base
     pending_categorizations.clear
   end
-  acts_as_taggable  
+  acts_as_taggable
   N_('Tag list')
   acts_as_filesystem
@@ -268,7 +268,7 @@ class Article &lt; ActiveRecord::Base
   end
   # returns the data of the article. Must be overriden in each subclass to
-  # provide the correct content for the article. 
+  # provide the correct content for the article.
   def data
     body
   end
@@ -360,6 +360,16 @@ class Article &lt; ActiveRecord::Base
     false
   end
+  def download? view = nil
+    (self.uploaded_file? and not self.image?) or
+      (self.image? and view.blank?) or
+      (not self.uploaded_file? and self.mime_type != 'text/html')
+  end
+
+  def download_headers
+    {}
+  end
+
   named_scope :native_translations, :conditions => { :translation_of_id => nil }
   def translatable?
@@ -86,6 +86,12 @@ class UploadedFile &lt; Article
     self.name = self.filename
   end
+  def download_headers
+    {
+      'Content-Disposition' => "attachment; filename=\"#{self.filename}\"",
+    }
+  end
+
   def data
     File.read(self.full_filename)
   end
@@ -0,0 +1 @@
+../../../public/500.html
 \ No newline at end of file
@@ -64,7 +64,19 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     assert_response :missing
   end
-  should 'produce a download-like when article is not text/html' do
+  should 'produce a download-link when article is a uploaded file' do
+    profile = create_user('someone').person
+    html = UploadedFile.create! :uploaded_data => fixture_file_upload('/files/500.html', 'text/html'), :profile => profile
+    html.save!
+
+    get :view_page, :profile => 'someone', :page => [ '500.html' ]
+
+    assert_response :success
+    assert_match /^text\/html/, @response.headers['Content-Type']
+    assert @response.headers['Content-Disposition'].present?
+  end
+
+  should 'produce a download-link when article is not text/html' do
     # for example, RSS feeds
     profile = create_user('someone').person
@@ -1254,7 +1266,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     get 'view_page', :profile => profile.identifier, :page => article.path.split('/')
     assert_tag :tag => 'a', :attributes => { :href => "/#{profile.identifier}/#{article.path}?comment_page=2", :rel => 'next' }
-  end 
+  end
   should 'not escape acceptable HTML in list of blog posts' do
     login_as('testinguser')
	@@ -86,6 +86,12 @@ class UploadedFile < Article		@@ -86,6 +86,12 @@ class UploadedFile < Article
86	self.name = self.filename	86	self.name = self.filename
87	end	87	end
88		88
		89	+ def download_headers
		90	+ {
		91	+ 'Content-Disposition' => "attachment; filename=\"#{self.filename}\"",
		92	+ }
		93	+ end
		94	+
89	def data	95	def data
90	File.read(self.full_filename)	96	File.read(self.full_filename)
91	end	97	end
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+../../../public/500.html
0	\ No newline at end of file	2	\ No newline at end of file