ActionItem14: checkpoint; I'm getting there

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@682 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem14: checkpoint; I'm getting there
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@682 3f533792-8f58-4932-b0fe-aaf55b0a4547
AntonioTerceiro
1 parent 85914506
Showing 6 changed files with 168 additions and 17 deletions Show diff stats
app/controllers/profile_admin/membership_editor_controller.rb
app/models/create_enterprise.rb
app/models/organization.rb
db/migrate/003_create_profiles.rb
test/fixtures/environments.yml
test/unit/create_enterprise_test.rb
@@ -20,7 +20,6 @@ class MembershipEditorController &lt; ProfileAdminController
       redirect_to :action => 'index'
     else
       flash[:notice] = _('Enterprise was not created')
-      @vitual_communities = Environment.find(:all)
       @validation_entities = Organization.find(:all)
       render :action => 'register_form'
     end
 class CreateEnterprise < Task
-  DATA_FIELDS = %w[ name identifier address contact_phone contact_person acronym foundation_year legal_form economic_activity management_information ]
+  DATA_FIELDS = %w[ name identifier address contact_phone contact_person acronym foundation_year legal_form economic_activity management_information region_id ]
   serialize :data, Hash
   attr_protected :data
@@ -20,10 +20,63 @@ class CreateEnterprise &lt; Task
   end
   # checks for virtual attributes 
-  validates_presence_of :name, :identifier, :address, :contact_phone, :contact_person, :legal_form, :economic_activity
+  validates_presence_of :name, :identifier, :address, :contact_phone, :contact_person, :legal_form, :economic_activity, :region_id
   validates_format_of :foundation_year, :with => /^\d*$/
   # checks for actual attributes
-  validates_presence_of :requestor_id
+  validates_presence_of :requestor_id, :target_id
+
+  def validate
+    if self.region && self.target
+      unless self.region.validators.include?(self.target)
+        self.errors.add(:target, '%{fn} is not a validator for the chosen region')
+      end
+    end
+  end
+
+  # gets the associated region for the enterprise creation
+  def region(reload = false)
+    if self.region_id
+      if reload || @region.nil?
+        @region = Region.find(self.region_id)
+      end
+    end
+    @region
+  end
+
+  # sets the associated region for the enterprise creation
+  def region=(value)
+    raise ArgumentError.new("Region expected, but got #{value.class}") unless value.kind_of?(Region)
+
+    @region = value
+    self.region_id = value.id
+  end
+
+  # Rejects the enterprise registration request.
+  def reject
+    cancel
+  end
+
+  # Approves the enterprise registration request.
+  def approve
+    finish
+  end
+
+  # actually creates the enterprise after the request is approved.
+  def perform
+    enterprise = Enterprise.new
+
+    profile_fields = %w[ name identifier contact_phone address region_id ]
+    profile_fields.each do |field|
+      enterprise.send("#{field}=", self.send(field))
+    end
+
+    organization_info_data = self.data.delete_if do |key,value|
+      profile_fields.include?(key.to_s)
+    end
+
+    enterprise.organization_info = OrganizationInfo.new(organization_info_data)
+    enterprise.save!
+  end
 end
@@ -3,6 +3,8 @@ class Organization &lt; Profile
   has_one :organization_info
   has_many :validated_enterprises, :class_name => 'enterprise'
+  belongs_to :region
+
 #  def info
 #    organization_info
 #  end
 class CreateProfiles < ActiveRecord::Migration
   def self.up
     create_table :profiles do |t|
-      t.column :name,                                   :string
-      t.column :type,                                   :string
-      t.column :identifier,                             :string
-      t.column :environment_id,                   :integer
+      t.column :name,              :string
+      t.column :type,              :string
+      t.column :identifier,        :string
+      t.column :environment_id,    :integer
-      t.column :active,                                 :boolean, :default => true
-      t.column :address,                                :string
-      t.column :contact_phone,                          :string
+      t.column :active,            :boolean, :default => true
+      t.column :address,           :string
+      t.column :contact_phone,     :string
       #person fields
-      t.column :user_id,                                :integer
+      t.column :user_id,           :integer
       #enterprise fields
-      t.column :validation_entity_id,                   :integer
-      t.column :approved,                              :boolean
+      t.column :region_id,         :integer
+
     end
   end
@@ -2,8 +2,10 @@
 colivre_net:
   id: 1
   name: 'Colivre.net'
+  contact_email: 'colivre@localhost.localdomain'
   is_default: true
 anhetegua_net:
   id: 2
   name: 'Anheteguá'
   is_default: false
+  contact_email: 'anhetegua@localhost.localdomain'
@@ -34,11 +34,106 @@ class CreateEnterpriseTest &lt; Test::Unit::TestCase
   end
   should 'require a target (validator organization)' do
-    flunk 'need to write'
+    task = CreateEnterprise.new
+    task.valid?
+
+    assert task.errors.invalid?(:target_id)
+    task.target = Organization.create!(:name => "My organization", :identifier => 'validator_organization')
+
+    task.valid?
+    assert !task.errors.invalid?(:target_id)
+  end
+
+  should 'require that the informed target (validator organization) actually validates for the chosen region' do
+    environment = Environment.create!(:name => "My environment")
+    region = Region.create!(:name => 'My region', :environment_id => environment.id)
+    validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
+
+    task = CreateEnterprise.new
+
+    task.region = region
+    task.target = validator
+
+    task.valid?
+    assert task.errors.invalid?(:target)
+    
+    region.validators << validator
+
+    task.valid?
+    assert !task.errors.invalid?(:target)
+  end
+
+  should 'cancel task when rejected ' do
+    task = CreateEnterprise.new
+    task.expects(:cancel)
+    task.reject
   end
-  should 'associate task requestor as enterprise administrator when creating' do
-    flunk 'need to write'
+  should 'finish task when approved' do
+    task = CreateEnterprise.new
+    task.expects(:finish)
+    task.approve
+  end
+
+  should 'actually create an enterprise when finishing the task' do
+
+    Environment.destroy_all
+    environment = Environment.create!(:name => "My environment", :contact_email => 'test@localhost.localdomain', :is_default => true)
+    region = Region.create!(:name => 'My region', :environment_id => environment.id)
+    validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
+    region.validators << validator
+    person = User.create!(:login => 'testuser', :password => 'test', :password_confirmation => 'test', :email => 'testuser@localhost.localdomain').person
+
+    task = CreateEnterprise.create!({
+      :name => 'My new enterprise',
+      :identifier => 'mynewenterprise',
+      :address => 'satan street, 666',
+      :contact_phone => '1298372198',
+      :contact_person => 'random joe',
+      :legal_form => 'cooperative',
+      :economic_activity => 'free software',
+      :region_id => region.id,
+      :requestor_id => person.id,
+      :target_id => validator.id,
+    })
+
+    enterprise = Enterprise.new
+    Enterprise.expects(:new).returns(enterprise)
+
+    task.finish
+
+    assert !enterprise.new_record?
+  end
+
+  should 'associate task requestor as enterprise administrator upon enterprise creation' do
+
+    Environment.destroy_all
+    environment = Environment.create!(:name => "My environment", :contact_email => 'test@localhost.localdomain', :is_default => true)
+    region = Region.create!(:name => 'My region', :environment_id => environment.id)
+    validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
+    region.validators << validator
+    person = User.create!(:login => 'testuser', :password => 'test', :password_confirmation => 'test', :email => 'testuser@localhost.localdomain').person
+
+    task = CreateEnterprise.create!({
+      :name => 'My new enterprise',
+      :identifier => 'mynewenterprise',
+      :address => 'satan street, 666',
+      :contact_phone => '1298372198',
+      :contact_person => 'random joe',
+      :legal_form => 'cooperative',
+      :economic_activity => 'free software',
+      :region_id => region.id,
+      :requestor_id => person.id,
+      :target_id => validator.id,
+    })
+
+    enterprise = Enterprise.new
+    Enterprise.expects(:new).returns(enterprise)
+
+    task.finish
+
+
+    flunk "don't know howt to test it yet"
   end
 end
1	class CreateEnterprise < Task	1	class CreateEnterprise < Task
2		2
3	- DATA_FIELDS = %w[ name identifier address contact_phone contact_person acronym foundation_year legal_form economic_activity management_information ]	3	+ DATA_FIELDS = %w[ name identifier address contact_phone contact_person acronym foundation_year legal_form economic_activity management_information region_id ]
4		4
5	serialize :data, Hash	5	serialize :data, Hash
6	attr_protected :data	6	attr_protected :data
	@@ -20,10 +20,63 @@ class CreateEnterprise < Task		@@ -20,10 +20,63 @@ class CreateEnterprise < Task
20	end	20	end
21		21
22	# checks for virtual attributes	22	# checks for virtual attributes
23	- validates_presence_of :name, :identifier, :address, :contact_phone, :contact_person, :legal_form, :economic_activity	23	+ validates_presence_of :name, :identifier, :address, :contact_phone, :contact_person, :legal_form, :economic_activity, :region_id
24	validates_format_of :foundation_year, :with => /^\d*$/	24	validates_format_of :foundation_year, :with => /^\d*$/
25		25
26	# checks for actual attributes	26	# checks for actual attributes
27	- validates_presence_of :requestor_id	27	+ validates_presence_of :requestor_id, :target_id
		28	+
		29	+ def validate
		30	+ if self.region && self.target
		31	+ unless self.region.validators.include?(self.target)
		32	+ self.errors.add(:target, '%{fn} is not a validator for the chosen region')
		33	+ end
		34	+ end
		35	+ end
		36	+
		37	+ # gets the associated region for the enterprise creation
		38	+ def region(reload = false)
		39	+ if self.region_id
		40	+ if reload \|\| @region.nil?
		41	+ @region = Region.find(self.region_id)
		42	+ end
		43	+ end
		44	+ @region
		45	+ end
		46	+
		47	+ # sets the associated region for the enterprise creation
		48	+ def region=(value)
		49	+ raise ArgumentError.new("Region expected, but got #{value.class}") unless value.kind_of?(Region)
		50	+
		51	+ @region = value
		52	+ self.region_id = value.id
		53	+ end
		54	+
		55	+ # Rejects the enterprise registration request.
		56	+ def reject
		57	+ cancel
		58	+ end
		59	+
		60	+ # Approves the enterprise registration request.
		61	+ def approve
		62	+ finish
		63	+ end
		64	+
		65	+ # actually creates the enterprise after the request is approved.
		66	+ def perform
		67	+ enterprise = Enterprise.new
		68	+
		69	+ profile_fields = %w[ name identifier contact_phone address region_id ]
		70	+ profile_fields.each do \|field\|
		71	+ enterprise.send("#{field}=", self.send(field))
		72	+ end
		73	+
		74	+ organization_info_data = self.data.delete_if do \|key,value\|
		75	+ profile_fields.include?(key.to_s)
		76	+ end
		77	+
		78	+ enterprise.organization_info = OrganizationInfo.new(organization_info_data)
		79	+ enterprise.save!
		80	+ end
28		81
29	end	82	end
	@@ -34,11 +34,106 @@ class CreateEnterpriseTest < Test::Unit::TestCase		@@ -34,11 +34,106 @@ class CreateEnterpriseTest < Test::Unit::TestCase
34	end	34	end
35		35
36	should 'require a target (validator organization)' do	36	should 'require a target (validator organization)' do
37	- flunk 'need to write'	37	+ task = CreateEnterprise.new
		38	+ task.valid?
		39	+
		40	+ assert task.errors.invalid?(:target_id)
		41	+ task.target = Organization.create!(:name => "My organization", :identifier => 'validator_organization')
		42	+
		43	+ task.valid?
		44	+ assert !task.errors.invalid?(:target_id)
		45	+ end
		46	+
		47	+ should 'require that the informed target (validator organization) actually validates for the chosen region' do
		48	+ environment = Environment.create!(:name => "My environment")
		49	+ region = Region.create!(:name => 'My region', :environment_id => environment.id)
		50	+ validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
		51	+
		52	+ task = CreateEnterprise.new
		53	+
		54	+ task.region = region
		55	+ task.target = validator
		56	+
		57	+ task.valid?
		58	+ assert task.errors.invalid?(:target)
		59	+
		60	+ region.validators << validator
		61	+
		62	+ task.valid?
		63	+ assert !task.errors.invalid?(:target)
		64	+ end
		65	+
		66	+ should 'cancel task when rejected ' do
		67	+ task = CreateEnterprise.new
		68	+ task.expects(:cancel)
		69	+ task.reject
38	end	70	end
39		71
40	- should 'associate task requestor as enterprise administrator when creating' do
41	- flunk 'need to write'	72	+ should 'finish task when approved' do
		73	+ task = CreateEnterprise.new
		74	+ task.expects(:finish)
		75	+ task.approve
		76	+ end
		77	+
		78	+ should 'actually create an enterprise when finishing the task' do
		79	+
		80	+ Environment.destroy_all
		81	+ environment = Environment.create!(:name => "My environment", :contact_email => 'test@localhost.localdomain', :is_default => true)
		82	+ region = Region.create!(:name => 'My region', :environment_id => environment.id)
		83	+ validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
		84	+ region.validators << validator
		85	+ person = User.create!(:login => 'testuser', :password => 'test', :password_confirmation => 'test', :email => 'testuser@localhost.localdomain').person
		86	+
		87	+ task = CreateEnterprise.create!({
		88	+ :name => 'My new enterprise',
		89	+ :identifier => 'mynewenterprise',
		90	+ :address => 'satan street, 666',
		91	+ :contact_phone => '1298372198',
		92	+ :contact_person => 'random joe',
		93	+ :legal_form => 'cooperative',
		94	+ :economic_activity => 'free software',
		95	+ :region_id => region.id,
		96	+ :requestor_id => person.id,
		97	+ :target_id => validator.id,
		98	+ })
		99	+
		100	+ enterprise = Enterprise.new
		101	+ Enterprise.expects(:new).returns(enterprise)
		102	+
		103	+ task.finish
		104	+
		105	+ assert !enterprise.new_record?
		106	+ end
		107	+
		108	+ should 'associate task requestor as enterprise administrator upon enterprise creation' do
		109	+
		110	+ Environment.destroy_all
		111	+ environment = Environment.create!(:name => "My environment", :contact_email => 'test@localhost.localdomain', :is_default => true)
		112	+ region = Region.create!(:name => 'My region', :environment_id => environment.id)
		113	+ validator = Organization.create!(:name => "My organization", :identifier => 'myorg', :environment_id => environment.id)
		114	+ region.validators << validator
		115	+ person = User.create!(:login => 'testuser', :password => 'test', :password_confirmation => 'test', :email => 'testuser@localhost.localdomain').person
		116	+
		117	+ task = CreateEnterprise.create!({
		118	+ :name => 'My new enterprise',
		119	+ :identifier => 'mynewenterprise',
		120	+ :address => 'satan street, 666',
		121	+ :contact_phone => '1298372198',
		122	+ :contact_person => 'random joe',
		123	+ :legal_form => 'cooperative',
		124	+ :economic_activity => 'free software',
		125	+ :region_id => region.id,
		126	+ :requestor_id => person.id,
		127	+ :target_id => validator.id,
		128	+ })
		129	+
		130	+ enterprise = Enterprise.new
		131	+ Enterprise.expects(:new).returns(enterprise)
		132	+
		133	+ task.finish
		134	+
		135	+
		136	+ flunk "don't know howt to test it yet"
42	end	137	end
43		138
44	end	139	end