refactoring captcha tests

Evandro Junior
1 parent be8ecf2b
Showing 8 changed files with 51 additions and 54 deletions Show diff stats
lib/noosfero/api/helpers.rb
lib/noosfero/api/session.rb
lib/noosfero/api/v1/articles.rb
plugins/serpro_captcha/test/test_helper.rb
plugins/serpro_captcha/test/unit/serpro_captcha_verification_test.rb
test/unit/api/login_captcha_test.rb
test/unit/api/session_test.rb
test/unit/api/test_helper.rb
@@ -412,10 +412,6 @@ require &#39;grape&#39;
       #              captcha_helpers           #
       ##########################################
-      # def plugins
-      #   @plugins
-      # end
-
       def test_captcha(remote_ip, params, environment)
         captcha_plugin_enabled = @plugins.dispatch(:test_captcha, remote_ip, params, environment)
         return true if captcha_plugin_enabled.size == 0
@@ -59,6 +59,7 @@ module Noosfero
         #requires :password_confirmation, type: String, desc: _("Password confirmation")
       end
       post "/register" do
+        # binding.pry
         attrs = attributes_for_keys [:email, :login, :password, :password_confirmation] + environment.signup_person_fields
         remote_ip = (request.respond_to?(:remote_ip) && request.remote_ip) || (env && env['REMOTE_ADDR'])
         # test_captcha will render_api_error! and exit in case of any problem
@@ -138,7 +138,6 @@ module Noosfero
             named 'ArticleVote'
           end
           post ':id/vote' do
-            binding.pry
             ## The vote api should allow regular login or with captcha
             authenticate_allow_captcha!
             value = (params[:value] || 1).to_i
@@ -32,24 +32,7 @@ class ActiveSupport::TestCase
   ## Performs a login using the session.rb but mocking the
   ## real HTTP request to validate the captcha.
   def do_login_captcha_from_api
-    # Request mocking
-    #Net::HTTP::Post Mock
-    request = mock
-    #Net::HTTP Mock
-    http = mock
-    uri = URI(environment.api_captcha_settings[:verify_uri])
-    Net::HTTP.expects(:new).with(uri.host, uri.port).returns(http)
-    Net::HTTP::Post.expects(:new).with(uri.path).returns(request)
-
-    # Captcha required codes
-    request.stubs(:body=).with("0000000000000000&4324343&4030320")
-    http.stubs(:request).with(request).returns(http)
-
-    # Captcha validation success !!
-    http.stubs(:body).returns("1")
-
-    params = {:txtToken_captcha_serpro_gov_br => '4324343', :captcha_text => '4030320'}
-    post "#{@url}#{params.to_query}"
+    post "/api/v1/login-captcha"
     json = JSON.parse(last_response.body)
     json
   end
@@ -90,7 +90,6 @@ class SerproCaptchaVerificationTest &lt; ActiveSupport::TestCase
   end
   should 'perform a vote on an article identified by id' do
-    binding.pry
     login_with_captcha
     article = create_article('Article 1')
     params = {}
@@ -3,20 +3,20 @@ require File.dirname(__FILE__) + &#39;/test_helper&#39;
 class LoginCaptchaTest < ActiveSupport::TestCase
   def setup()
-    @environment = Environment.default
-    @environment.api_captcha_settings = {
-        enabled: true,
-        provider: 'serpro',
-        serpro_client_id:  '0000000000000000',
-        verify_uri:  'http://captcha.serpro.gov.br/validate',
-    }
-    @environment.save!
-  	@url = "/api/v1/login-captcha?"
+    # @environment = Environment.default
+    # @environment.api_captcha_settings = {
+    #     enabled: true,
+    #     provider: 'serpro',
+    #     serpro_client_id:  '0000000000000000',
+    #     verify_uri:  'http://captcha.serpro.gov.br/validate',
+    # }
+    # @environment.save!
+  	# @url = "/api/v1/login-captcha?"
   end
   def create_article(name)
     person = fast_create(Person, :environment_id => @environment.id)
-    fast_create(Article, :profile_id => person.id, :name => name)    
+    fast_create(Article, :profile_id => person.id, :name => name)
   end
   should 'not perform a vote without authentication' do
@@ -42,7 +42,7 @@ class LoginCaptchaTest &lt; ActiveSupport::TestCase
     post "/api/v1/articles/#{article.id}/vote?#{params.to_query}"
     json = JSON.parse(last_response.body)
-    
+
     assert_not_equal 401, last_response.status
     assert_equal true, json['vote']
   end
@@ -90,4 +90,9 @@ class LoginCaptchaTest &lt; ActiveSupport::TestCase
     assert ret == @private_token
   end
-end
 \ No newline at end of file
+  should 'do login captcha from api' do
+    pry
+    do_login_captcha_from_api
+  end
+
+end
@@ -4,6 +4,7 @@ class SessionTest &lt; ActiveSupport::TestCase
   def setup
     login_api
+    OutcomeCaptcha.outcome_captcha_test = true
   end
   should 'generate private token when login' do
@@ -76,13 +77,13 @@ class SessionTest &lt; ActiveSupport::TestCase
   end
   should 'not register a user without email' do
-    #binding.pry
     params = {:login => "newuserapi", :password => "newuserapi", :password_confirmation => "newuserapi", :email => nil }
     post "/api/v1/register?#{params.to_query}"
     assert_equal 400, last_response.status
   end
   should 'not register a duplicated user' do
+    # binding.pry
     params = {:login => "newuserapi", :password => "newuserapi", :password_confirmation => "newuserapi", :email => "newuserapi@email.com" }
     post "/api/v1/register?#{params.to_query}"
     post "/api/v1/register?#{params.to_query}"
@@ -90,22 +91,6 @@ class SessionTest &lt; ActiveSupport::TestCase
     json = JSON.parse(last_response.body)
   end
-  should 'detected error, Name or service not known, for Serpro captcha communication' do
-    environment = Environment.default
-    environment.api_captcha_settings = {
-        enabled: true,
-        provider: 'serpro',
-        serpro_client_id:  '0000000000000000',
-        verify_uri:  'http://someserverthatdoesnotexist.mycompanythatdoesnotexist.com/validate',
-    }
-    environment.save!
-    params = {:login => "newuserapi", :password => "newuserapi", :password_confirmation => "newuserapi", :email => "newuserapi@email.com",
-              :txtToken_captcha_serpro_gov_br => '4324343', :captcha_text => '4030320'}
-    post "/api/v1/register?#{params.to_query}"
-    message = JSON.parse(last_response.body)['javascript_console_message']
-    assert_equal "Serpro captcha error: getaddrinfo: Name or service not known", message
-  end
-
   # TODO: Add another test cases to check register situations
   should 'activate a user' do
     params = {
@@ -201,4 +186,12 @@ class SessionTest &lt; ActiveSupport::TestCase
     assert_equal 404, last_response.status
   end
+  should 'do not register a user if captcha fails' do
+    OutcomeCaptcha.outcome_captcha_test = false
+    Environment.default.enable('skip_new_user_email_confirmation')
+    params = {:login => "newuserapi_ewa ", :password => "newuserapi", :password_confirmation => "newuserapi", :email => "newuserapi@email.com" }
+    post "/api/v1/register?#{params.to_query}"
+    assert_equal 403, last_response.status
+  end
+
 end
 require File.dirname(__FILE__) + '/../../test_helper'
+require File.join(Rails.root, '/lib/noosfero/api/helpers.rb')
+
+class OutcomeCaptcha
+  class << self
+    attr_accessor :outcome_captcha_test
+  end
+  @outcome_captcha_test = true
+end
+
+module Noosfero
+  module API
+    module APIHelpers
+      def test_captcha(*args)
+        return true if OutcomeCaptcha.outcome_captcha_test
+        render_api_error!("Error testing captcha", 403)
+      end
+    end
+  end
+end
 class ActiveSupport::TestCase
   include Rack::Test::Methods
+  include Noosfero::API::APIHelpers
   def app
     Noosfero::API::API
@@ -16,7 +36,8 @@ class ActiveSupport::TestCase
   end
   def do_login_captcha_from_api
-    JSON.parse("1")
+    #JSON.parse("")
+    "sasadasdaasdasdadadsadassadas"
   end
   def login_api
	@@ -32,24 +32,7 @@ class ActiveSupport::TestCase		@@ -32,24 +32,7 @@ class ActiveSupport::TestCase
32	## Performs a login using the session.rb but mocking the	32	## Performs a login using the session.rb but mocking the
33	## real HTTP request to validate the captcha.	33	## real HTTP request to validate the captcha.
34	def do_login_captcha_from_api	34	def do_login_captcha_from_api
35	- # Request mocking
36	- #Net::HTTP::Post Mock
37	- request = mock
38	- #Net::HTTP Mock
39	- http = mock
40	- uri = URI(environment.api_captcha_settings[:verify_uri])
41	- Net::HTTP.expects(:new).with(uri.host, uri.port).returns(http)
42	- Net::HTTP::Post.expects(:new).with(uri.path).returns(request)
43	-
44	- # Captcha required codes
45	- request.stubs(:body=).with("0000000000000000&4324343&4030320")
46	- http.stubs(:request).with(request).returns(http)
47	-
48	- # Captcha validation success !!
49	- http.stubs(:body).returns("1")
50	-
51	- params = {:txtToken_captcha_serpro_gov_br => '4324343', :captcha_text => '4030320'}
52	- post "#{@url}#{params.to_query}"	35	+ post "/api/v1/login-captcha"
53	json = JSON.parse(last_response.body)	36	json = JSON.parse(last_response.body)
54	json	37	json
55	end	38	end
	@@ -90,7 +90,6 @@ class SerproCaptchaVerificationTest < ActiveSupport::TestCase		@@ -90,7 +90,6 @@ class SerproCaptchaVerificationTest < ActiveSupport::TestCase
90	end	90	end
91		91
92	should 'perform a vote on an article identified by id' do	92	should 'perform a vote on an article identified by id' do
93	- binding.pry
94	login_with_captcha	93	login_with_captcha
95	article = create_article('Article 1')	94	article = create_article('Article 1')
96	params = {}	95	params = {}
1	require File.dirname(__FILE__) + '/../../test_helper'	1	require File.dirname(__FILE__) + '/../../test_helper'
		2	+require File.join(Rails.root, '/lib/noosfero/api/helpers.rb')
		3	+
		4	+class OutcomeCaptcha
		5	+ class << self
		6	+ attr_accessor :outcome_captcha_test
		7	+ end
		8	+ @outcome_captcha_test = true
		9	+end
		10	+
		11	+module Noosfero
		12	+ module API
		13	+ module APIHelpers
		14	+ def test_captcha(*args)
		15	+ return true if OutcomeCaptcha.outcome_captcha_test
		16	+ render_api_error!("Error testing captcha", 403)
		17	+ end
		18	+ end
		19	+ end
		20	+end
2		21
3	class ActiveSupport::TestCase	22	class ActiveSupport::TestCase
4		23
5	include Rack::Test::Methods	24	include Rack::Test::Methods
		25	+ include Noosfero::API::APIHelpers
6		26
7	def app	27	def app
8	Noosfero::API::API	28	Noosfero::API::API
	@@ -16,7 +36,8 @@ class ActiveSupport::TestCase		@@ -16,7 +36,8 @@ class ActiveSupport::TestCase
16	end	36	end
17		37
18	def do_login_captcha_from_api	38	def do_login_captcha_from_api
19	- JSON.parse("1")	39	+ #JSON.parse("")
		40	+ "sasadasdaasdasdadadsadassadas"
20	end	41	end
21		42
22	def login_api	43	def login_api