ActionItem1183: better tests

Antonio Terceiro
1 parent 9cef4d2f
Showing 1 changed file with 6 additions and 4 deletions Show diff stats
test/unit/profile_test.rb
@@ -1353,13 +1353,15 @@ class ProfileTest &lt; Test::Unit::TestCase
   end
  
   should 'profile be valid when image is empty' do
-    profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => ""})
-    assert_valid profile
+    profile = Profile.new(:image_builder => {:uploaded_data => ""})
+    profile.valid?
+    assert_nil profile.errors[:image]
   end
  
   should 'profile be valid when has no image' do
-    profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting')
-    assert_valid profile
+    profile = Profile.new
+    profile.valid?
+    assert_nil profile.errors[:image]
   end
  
   should 'copy header and footer after create a person' do
...	...	@@ -1353,13 +1353,15 @@ class ProfileTest < Test::Unit::TestCase
1353	1353	end
1354	1354
1355	1355	should 'profile be valid when image is empty' do
1356		- profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => ""})
1357		- assert_valid profile
	1356	+ profile = Profile.new(:image_builder => {:uploaded_data => ""})
	1357	+ profile.valid?
	1358	+ assert_nil profile.errors[:image]
1358	1359	end
1359	1360
1360	1361	should 'profile be valid when has no image' do
1361		- profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting')
1362		- assert_valid profile
	1362	+ profile = Profile.new
	1363	+ profile.valid?
	1364	+ assert_nil profile.errors[:image]
1363	1365	end
1364	1366
1365	1367	should 'copy header and footer after create a person' do
...	...