[performance] Fixing broken tests

Rodrigo Souto
1 parent d482447c
Showing 4 changed files with 16 additions and 11 deletions Show diff stats
app/models/article.rb
test/functional/profile_design_controller_test.rb
test/unit/boxes_helper_test.rb
test/unit/enterprise_test.rb
@@ -192,7 +192,7 @@ class Article &lt; ActiveRecord::Base
         scoped_methods.last[:find] &&
         scoped_methods.last[:find][:joins] &&
         scoped_methods.last[:find][:joins].index('profiles') )
-      result.includes(:profile)
+      result = result.includes(:profile)
     end
     pagination ? result.paginate({:page => 1, :per_page => limit}) : result
@@ -322,11 +322,14 @@ class ProfileDesignControllerTest &lt; ActionController::TestCase
   should 'be able to save FeedReaderBlock configurations' do
     @box1.blocks << FeedReaderBlock.new(:address => 'feed address')
     holder.blocks(true)
+    block = @box1.blocks.last
-    post :save, :profile => 'designtestuser', :id => @box1.blocks[-1].id, :block => {:address => 'new feed address', :limit => '20'}
+    post :save, :profile => 'designtestuser', :id => block.id, :block => {:address => 'new feed address', :limit => '20'}
-    assert_equal 'new feed address', @box1.blocks[-1].address
-    assert_equal 20, @box1.blocks[-1].limit
+    block.reload
+
+    assert_equal 'new feed address', block.address
+    assert_equal 20, block.limit
   end
   should 'require login' do
@@ -46,7 +46,8 @@ class BoxesHelperTest &lt; ActiveSupport::TestCase
     b = p.blocks.select{|bk| !bk.kind_of?(MainBlock) }[0]
     b.display = 'never'; b.save!
     box = b.box
-    box.expects(:blocks).returns([b])
+    box.blocks = [b]
+    box.save!
     expects(:display_block).with(b, '')
     expects(:request).returns(request)
     stubs(:block_target).returns('')
@@ -64,7 +65,8 @@ class BoxesHelperTest &lt; ActiveSupport::TestCase
     b = p.blocks.select{|bk| !bk.kind_of?(MainBlock) }[0]
     b.display = 'never'; b.save!
     box = b.box
-    box.expects(:blocks).returns([b])
+    box.blocks = [b]
+    box.save!
     expects(:display_block).with(b, '').never
     expects(:request).returns(request)
     stubs(:block_target).returns('')
@@ -106,9 +108,7 @@ class BoxesHelperTest &lt; ActiveSupport::TestCase
   should 'fill context with the article, request_path and locale' do
     request = mock()
-    box = mock()
-
-    box.expects(:blocks).returns([])
+    box = Box.create!(:owner => fast_create(Profile))
     request.expects(:path).returns('/')
     expects(:request).returns(request)
     expects(:locale).returns('en')
@@ -482,9 +482,11 @@ class EnterpriseTest &lt; ActiveSupport::TestCase
   should 'reindex products with full category name after save' do
     product = mock
+    products = mock
     product.expects(:category_full_name)
-    Enterprise.any_instance.stubs(:products).returns([product])
-    Enterprise.expects(:solr_batch_add).with(includes(product))
+    products.stubs(:includes).returns([product])
+    Enterprise.any_instance.stubs(:products).returns(products)
+    Enterprise.expects(:solr_batch_add).with([products])
     ent = fast_create(Enterprise)
     ent.save!
   end
	@@ -192,7 +192,7 @@ class Article < ActiveRecord::Base		@@ -192,7 +192,7 @@ class Article < ActiveRecord::Base
192	scoped_methods.last[:find] &&	192	scoped_methods.last[:find] &&
193	scoped_methods.last[:find][:joins] &&	193	scoped_methods.last[:find][:joins] &&
194	scoped_methods.last[:find][:joins].index('profiles') )	194	scoped_methods.last[:find][:joins].index('profiles') )
195	- result.includes(:profile)	195	+ result = result.includes(:profile)
196	end	196	end
197		197
198	pagination ? result.paginate({:page => 1, :per_page => limit}) : result	198	pagination ? result.paginate({:page => 1, :per_page => limit}) : result