rails4: fix uploaded file tests

Braulio Bhavamitra
1 parent 2f568c12
Showing 4 changed files with 12 additions and 6 deletions Show diff stats
app/models/thumbnail.rb
test/factories.rb
test/test_helper.rb
test/unit/uploaded_file_test.rb
 class Thumbnail < ActiveRecord::Base
+
+  attr_accessible :uploaded_data
+  # mass assigned by attachment_fu
+  attr_accessible :content_type, :filename, :thumbnail_resize_options, :thumbnail, :parent_id
+
   has_attachment :storage => :file_system,
     :content_type => :image, :max_size => 5.megabytes, processor: 'Rmagick'
   validates_as_attachment
@@ -7,5 +12,4 @@ class Thumbnail &lt; ActiveRecord::Base
   postgresql_attachment_fu
-  attr_accessible :uploaded_data
 end
@@ -31,7 +31,8 @@ module Noosfero::Factory
     if respond_to?(target)
       send(target, attrs)
     else
-      obj = build(name, attrs)
+      obj = build name
+      attrs.each{ |a, v| obj.send "#{a}=", v }
       obj.save!
       obj
     end
@@ -138,6 +138,7 @@ class ActiveSupport::TestCase
   def find_tag_in_string text, options
     doc = Nokogiri::HTML.fragment text
     tag = doc.css(options[:tag]).first
+    return unless tag
     content = tag.text.strip
     attributes = {}; tag.attributes.each do |a, v|
@@ -146,7 +147,7 @@ class ActiveSupport::TestCase
       attributes[a] = v.value
     end
-    ret = tag.present?
+    ret = true
     ret &&= options[:attributes].blank? || attributes == options[:attributes]
     ret &&= options[:content].blank? || content == options[:content]
     ret
@@ -347,13 +347,13 @@ class UploadedFileTest &lt; ActiveSupport::TestCase
     'INVALID' => 5.megabytes,   # use default for invalid input
     '1ZYX'    => 5.megabytes,   # use default for invalid input
   }.each do |input,output|
-    test 'maximum upload size: convert %s into %s' % [input, output] do
+    should 'maximum upload size: convert %s into %s' % [input, output] do
       NOOSFERO_CONF.expects(:[]).with('max_upload_size').returns(input)
       assert_equal output, UploadedFile.max_size
     end
   end
-  test 'max_size should always return an integer' do
-    NOOSFERO_CONF.expects(:[]).with('max_upload_size').returns("0.5 GB")
+  should 'max_size should always return an integer' do
+    NOOSFERO_CONF.expects(:[]).with('max_upload_size').returns("0.5 GB").at_least_once
     assert_instance_of Fixnum, UploadedFile.max_size
   end