Download as
Browse Code »

Commit b5ecb6a4537a35fe50940e59b7e2f286937ebd91

Authored by Antonio Terceiro
1 parent 2bdb49ac
Exists in master and in 22 other branches angular_poc, api-article-archived, article-readonly, backup-7-jan-2016, captcha_serpro_plugin, content-manager-hostspot, export-comment-paragraph, fix_event_date_issue, login-captcha, master_rails3, new_video_plugin, pg_search_rank, production, refactor_with_role, refactor_with_role_scope, remove_profile_cat_icons, resend_confirmation_email, staging, staging_rails3, tasks_keep_filter_params, theme-brasil-digital-from-staging, travis

DEVELOPMENT.md: document expectations for the code review process

Showing 1 changed file with 20 additions and 0 deletions   Show diff stats
DEVELOPMENT.md
  Diff comments   View file @b5ecb6a
... ... @@ -19,6 +19,26 @@
19 19 * In the case the original author is a committer, he/she should feel free to
20 20 commit directly if after 1 week nobody has provided any kind of feedback.
21 21  
  22 + * Developers who are not committers should feel free to ping committers if
  23 + they do not get feedback on their contributions after 1 week.
  24 +
  25 + * On GitLab, one can just add a comment to the merge request; one can also
  26 + @-mention specific committers or other developers who have expertise on
  27 + the area of the contribution.
  28 +
  29 + * Committers should follow the activity of the project, and try to help
  30 + reviewing contributions from others as much as possible.
  31 +
  32 + * On GitLab one can get emails for all activity on a project by setting the
  33 + [notification settings](https://gitlab.com/profile/notifications) to
  34 + "watch".
  35 +
  36 + * Anyone can help by reviewing contributions. Committers are the only ones
  37 + who can give the final approval to a contribution, but everyone is welcome
  38 + to help with code review, testing, etc.
  39 +
  40 + * See note above about setting up notification on GitLab.
  41 +
22 42 * Committers should feel free to push trivial (or urgent) changes directly.
23 43 There are no strict rule on what makes a change trivial or urgent; committers
24 44 are expected to exercise good judgement on a case by case basis.
... ...