rails4: fix broken tests after merge

Braulio Bhavamitra
1 parent a3bfec81
Showing 18 changed files with 49 additions and 30 deletions Show diff stats
app/controllers/application_controller.rb
app/helpers/action_tracker_helper.rb
app/mailers/application_mailer.rb
app/models/person_notifier.rb
app/models/profile_list_block.rb
app/views/person_notifier/mailer/_create_product.html.erb
app/views/person_notifier/mailer/_favorite_enterprise.html.erb
app/views/person_notifier/mailer/_remove_product.html.erb
app/views/person_notifier/mailer/_update_product.html.erb
app/views/profile/_create_product.html.erb
app/views/profile/_favorite_enterprise.html.erb
app/views/profile/_remove_product.html.erb
app/views/profile/_update_product.html.erb
config/application.rb
lib/authenticated_system.rb
lib/noosfero/plugin.rb
test/functional/profile_controller_test.rb
test/unit/person_notifier_test.rb
@@ -65,8 +65,6 @@ class ApplicationController &lt; ActionController::Base
   helper :language
   include DesignHelper
-
-  # Be sure to include AuthenticationSystem in Application Controller instead
   include AuthenticatedSystem
   include PermissionCheck
@@ -67,19 +67,19 @@ module ActionTrackerHelper
     }
   end
-  def create_product_description
+  def create_product_description ta
     _('created the product %{title}') % {
       title: link_to(truncate(ta.get_name), ta.get_url),
     }
   end
-  def update_product_description
+  def update_product_description ta
     _('updated the product %{title}') % {
       title: link_to(truncate(ta.get_name), ta.get_url),
     }
   end
-  def remove_product_description
+  def remove_product_description ta
     _('removed the product %{title}') % {
       title: truncate(ta.get_name),
     }
+require_relative '../helpers/application_helper'
+
 class ApplicationMailer < ActionMailer::Base
+  include AuthenticatedSystem
+
+  helper ApplicationHelper
+
   attr_accessor :environment
   def default_url_options options = nil
@@ -77,9 +77,8 @@ class PersonNotifier
   end
-  class Mailer < ActionMailer::Base
+  class Mailer < ApplicationMailer
-    helper ApplicationHelper
     helper ActionTrackerHelper
     def session
@@ -88,8 +87,8 @@ class PersonNotifier
     def content_summary(person, notifications, tasks)
       if person.environment
-        ActionMailer::Base.asset_host = person.environment.top_url
-        ActionMailer::Base.default_url_options[:host] = person.environment.default_hostname
+        ApplicationMailer.asset_host = person.environment.top_url
+        ApplicationMailer.default_url_options[:host] = person.environment.default_hostname
       end
       @current_theme = 'default'
@@ -16,7 +16,7 @@ class ProfileListBlock &lt; Block
   def profile_list
     result = nil
-    public_profiles = profiles.public.includes([:image,:domains,:preferred_domain,:environment])
+    public_profiles = profiles.is_public.includes([:image,:domains,:preferred_domain,:environment])
     if !prioritize_profiles_with_image
 result = public_profiles.all(:limit => get_limit, :order => 'profiles.updated_at DESC').sort_by{ rand }
     elsif profiles.visible.with_image.count >= get_limit
@@ -28,7 +28,7 @@ result = public_profiles.all(:limit =&gt; get_limit, :order =&gt; &#39;profiles.updated_at
   end
   def profile_count
-    profiles.public.length
+    profiles.is_public.length
   end
   # the title of the block. Probably will be overriden in subclasses.
@@ -0,0 +1 @@
+../../profile/_create_product.html.erb
 \ No newline at end of file
@@ -0,0 +1 @@
+../../profile/_favorite_enterprise.html.erb
 \ No newline at end of file
@@ -0,0 +1 @@
+../../profile/_remove_product.html.erb
 \ No newline at end of file
@@ -0,0 +1 @@
+../../profile/_update_product.html.erb
 \ No newline at end of file
@@ -3,7 +3,7 @@
 </div>
 <div class='profile-activity-description'>
   <p class='profile-activity-text'><%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %></p>
-  <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>
+  <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
   <div class='profile-wall-actions'>
     <%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>
@@ -5,7 +5,7 @@
   <p class='profile-activity-text'>
     <%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %>
   </p>
-  <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>
+  <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
   <div class='profile-wall-actions'>
     <%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>
@@ -2,7 +2,7 @@
 </div>
 <div class='profile-activity-description'>
   <p class='profile-activity-text'><%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %></p>
-  <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>
+  <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
   <div class='profile-wall-actions'>
     <%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>
@@ -3,7 +3,7 @@
 </div>
 <div class='profile-activity-description'>
   <p class='profile-activity-text'><%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %></p>
-  <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>
+  <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
   <div class='profile-wall-actions'>
     <%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>
@@ -22,11 +22,10 @@ module Noosfero
     # -- all .rb files in that directory are automatically loaded.
     # Custom directories with classes and modules you want to be autoloadable.
-    config.autoload_paths += %W( #{Rails.root.join('app', 'sweepers')} )
+    config.autoload_paths += %W( #{config.root.join('app', 'sweepers')} )
     config.autoload_paths += Dir["#{config.root}/lib"]
     config.autoload_paths += Dir["#{config.root}/app/controllers/**/"]
-    config.autoload_paths += %W( #{Rails.root.join('test', 'mocks', Rails.env)} )
-
+    config.autoload_paths += %W( #{config.root.join('test', 'mocks', Rails.env)} )
     # Only load the plugins named here, in the order given (default is alphabetical).
     # :all can be used as a placeholder for all plugins not explicitly named.
@@ -3,7 +3,7 @@ module AuthenticatedSystem
   protected
     # See impl. from http://stackoverflow.com/a/2513456/670229
-    def self.included? base
+    def self.included base
       base.around_filter do
         begin
           User.current = current_user
@@ -12,7 +12,11 @@ module AuthenticatedSystem
           # to address the thread variable leak issues in Puma/Thin webserver
           User.current = nil
         end
-      end
+      end if base.is_a? ActionController::Base
+
+      # Inclusion hook to make #current_user and #logged_in?
+      # available as ActionView helper methods.
+      base.send :helper_method, :current_user, :logged_in?
     end
     # Returns true or false if the user is logged in.
@@ -134,12 +138,6 @@ module AuthenticatedSystem
       end
     end
-    # Inclusion hook to make #current_user and #logged_in?
-    # available as ActionView helper methods.
-    def self.included(base)
-      base.send :helper_method, :current_user, :logged_in?
-    end
-
     # When called with before_filter :login_from_cookie will check for an :auth_token
     # cookie and log the user back in if apropriate
     def login_from_cookie
@@ -713,5 +713,4 @@ end
 require 'noosfero/plugin/hot_spot'
 require 'noosfero/plugin/manager'
-require 'noosfero/plugin/mailer_base'
 require 'noosfero/plugin/settings'
@@ -1132,7 +1132,7 @@ class ProfileControllerTest &lt; ActionController::TestCase
     ActionTracker::Record.destroy_all
     40.times{ create(ActionTracker::Record, :user_id => profile.id, :user_type => 'Profile', :verb => 'create_article', :target_id => article.id, :target_type => 'Article', :params => {'name' => article.name, 'url' => article.url, 'lead' => article.lead, 'first_image' => article.first_image})}
     assert_equal 40, profile.tracked_actions.count
-    assert_equal 40, profile.activities.count
+    assert_equal 40, profile.activities.size
     get :view_more_activities, :profile => profile.identifier, :page => 2
     assert_response :success
     assert_template '_profile_activities_list'
@@ -163,6 +163,21 @@ class PersonNotifierTest &lt; ActiveSupport::TestCase
     end
   end
+  Targets = {
+    create_article: -> { create Forum, profile: @profile },
+    new_friendship: -> { create Friendship, person: @member, friend: @member },
+    join_community: -> { @member },
+    add_member_in_community: -> { create_user.person },
+    upload_image: -> { create Forum, profile: @profile },
+    leave_scrap: -> { create Scrap, sender: @member, receiver: @profile },
+    leave_scrap_to_self: -> { create Scrap, sender: @member, receiver: @profile },
+    reply_scrap_on_self: -> { create Scrap, sender: @member, receiver: @profile },
+    create_product: -> { create Product, profile: @profile, product_category: create(ProductCategory, environment: Environment.default) },
+    update_product: -> { create Product, profile: @profile, product_category: create(ProductCategory, environment: Environment.default) },
+    remove_product: -> { create Product, profile: @profile, product_category: create(ProductCategory, environment: Environment.default) },
+    favorite_enterprise: -> { create FavoriteEnterprisePerson, enterprise: create(Enterprise), person: @member },
+  }
+
   ActionTrackerConfig.verb_names.each do |verb|
     should "render notification for verb #{verb}" do
       @member.tracked_notifications = []
@@ -171,14 +186,15 @@ class PersonNotifierTest &lt; ActiveSupport::TestCase
       a.verb = verb
       a.user = @member
       a.created_at = @member.notifier.notify_from + 1.day
-      profile = create(Community)
-      a.target = create(Forum, profile: profile)
+      @profile = create(Community)
+      a.target = instance_exec &Targets[verb.to_sym]
       a.comments_count = 0
       a.params = {
         'name' => 'home', 'url' => '/', 'lead' => '',
         'receiver_url' => '/', 'content' => 'nothing',
         'friend_url' => '/', 'friend_profile_custom_icon' => [], 'friend_name' => ['joe'],
         'resource_name' => ['resource'], 'resource_profile_custom_icon' => [], 'resource_url' => ['/'],
+        'enterprise_name' => 'coop', 'enterprise_url' => '/coop',
         'view_url'=> ['/'], 'thumbnail_path' => ['1'],
       }
       a.get_url = ''
	@@ -65,8 +65,6 @@ class ApplicationController < ActionController::Base		@@ -65,8 +65,6 @@ class ApplicationController < ActionController::Base
65	helper :language	65	helper :language
66		66
67	include DesignHelper	67	include DesignHelper
68	-
69	- # Be sure to include AuthenticationSystem in Application Controller instead
70	include AuthenticatedSystem	68	include AuthenticatedSystem
71	include PermissionCheck	69	include PermissionCheck
72		70
	@@ -67,19 +67,19 @@ module ActionTrackerHelper		@@ -67,19 +67,19 @@ module ActionTrackerHelper
67	}	67	}
68	end	68	end
69		69
70	- def create_product_description	70	+ def create_product_description ta
71	_('created the product %{title}') % {	71	_('created the product %{title}') % {
72	title: link_to(truncate(ta.get_name), ta.get_url),	72	title: link_to(truncate(ta.get_name), ta.get_url),
73	}	73	}
74	end	74	end
75		75
76	- def update_product_description	76	+ def update_product_description ta
77	_('updated the product %{title}') % {	77	_('updated the product %{title}') % {
78	title: link_to(truncate(ta.get_name), ta.get_url),	78	title: link_to(truncate(ta.get_name), ta.get_url),
79	}	79	}
80	end	80	end
81		81
82	- def remove_product_description	82	+ def remove_product_description ta
83	_('removed the product %{title}') % {	83	_('removed the product %{title}') % {
84	title: truncate(ta.get_name),	84	title: truncate(ta.get_name),
85	}	85	}
		1	+require_relative '../helpers/application_helper'
		2	+
1	class ApplicationMailer < ActionMailer::Base	3	class ApplicationMailer < ActionMailer::Base
2		4
		5	+ include AuthenticatedSystem
		6	+
		7	+ helper ApplicationHelper
		8	+
3	attr_accessor :environment	9	attr_accessor :environment
4		10
5	def default_url_options options = nil	11	def default_url_options options = nil
	@@ -16,7 +16,7 @@ class ProfileListBlock < Block		@@ -16,7 +16,7 @@ class ProfileListBlock < Block
16		16
17	def profile_list	17	def profile_list
18	result = nil	18	result = nil
19	- public_profiles = profiles.public.includes([:image,:domains,:preferred_domain,:environment])	19	+ public_profiles = profiles.is_public.includes([:image,:domains,:preferred_domain,:environment])
20	if !prioritize_profiles_with_image	20	if !prioritize_profiles_with_image
21	result = public_profiles.all(:limit => get_limit, :order => 'profiles.updated_at DESC').sort_by{ rand }	21	result = public_profiles.all(:limit => get_limit, :order => 'profiles.updated_at DESC').sort_by{ rand }
22	elsif profiles.visible.with_image.count >= get_limit	22	elsif profiles.visible.with_image.count >= get_limit
	@@ -28,7 +28,7 @@ result = public_profiles.all(:limit => get_limit, :order => 'profiles.updated_at		@@ -28,7 +28,7 @@ result = public_profiles.all(:limit => get_limit, :order => 'profiles.updated_at
28	end	28	end
29		29
30	def profile_count	30	def profile_count
31	- profiles.public.length	31	+ profiles.is_public.length
32	end	32	end
33		33
34	# the title of the block. Probably will be overriden in subclasses.	34	# the title of the block. Probably will be overriden in subclasses.
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+../../profile/_create_product.html.erb
0	\ No newline at end of file	2	\ No newline at end of file
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+../../profile/_favorite_enterprise.html.erb
0	\ No newline at end of file	2	\ No newline at end of file
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+../../profile/_remove_product.html.erb
0	\ No newline at end of file	2	\ No newline at end of file
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+../../profile/_update_product.html.erb
0	\ No newline at end of file	2	\ No newline at end of file
	@@ -3,7 +3,7 @@		@@ -3,7 +3,7 @@
3	</div>	3	</div>
4	<div class='profile-activity-description'>	4	<div class='profile-activity-description'>
5	<p class='profile-activity-text'><%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %></p>	5	<p class='profile-activity-text'><%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %></p>
6	- <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>	6	+ <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
7		7
8	<div class='profile-wall-actions'>	8	<div class='profile-wall-actions'>
9	<%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>	9	<%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>
	@@ -5,7 +5,7 @@		@@ -5,7 +5,7 @@
5	<p class='profile-activity-text'>	5	<p class='profile-activity-text'>
6	<%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %>	6	<%= link_to activity.user.short_name(nil), activity.user.url %> <%= describe activity %>
7	</p>	7	</p>
8	- <p class='profile-activity-time'><%= time_ago_as_sentence activity.created_at %></p>	8	+ <p class='profile-activity-time'><%= time_ago_in_words activity.created_at %></p>
9		9
10	<div class='profile-wall-actions'>	10	<div class='profile-wall-actions'>
11	<%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>	11	<%= link_to_function(_('Remove'), 'remove_item_wall(this, \'%s\', \'%s\', \'%s\'); return false ;' % [".profile-activity-item", url_for(:profile => params[:profile], :action => :remove_activity, :activity_id => activity.id, :view => params[:view]), _('Are you sure you want to remove this activity and all its replies?')]) if logged_in? && current_person == @profile %>