Tasks: need to filter only on actual list of tasks

Let's quite this string programming there. We do not need to keep a list of all types of tasks, we just need to take the actual list of tasks, and create the filter list accordingly.

Tasks: need to filter only on actual list of tasks
Let's quite this string programming there. We do not need to keep a list of all types of tasks, we just need to take the actual list of tasks, and create the filter list accordingly.
Antonio Terceiro
1 parent e1d1cd19
Showing 2 changed files with 4 additions and 7 deletions Show diff stats
app/models/task.rb
app/views/tasks/index.html.erb
@@ -73,10 +73,6 @@ class Task &lt; ActiveRecord::Base
     end
   end
-  def self.all_types
-    %w[Invitation EnterpriseActivation AddMember Ticket SuggestArticle  AddFriend CreateCommunity AbuseComplaint ApproveComment ApproveArticle CreateEnterprise ChangePassword EmailActivation InviteFriend InviteMember]
-  end
-
   # this method finished the task. It calls #perform, which must be overriden
   # by subclasses. At the end a message (as returned by #finish_message) is
   # sent to the requestor with #notify_requestor.
@@ -3,9 +3,10 @@
 <h1><%= _("%s's pending tasks") % profile.name %></h1>
 <p>
-<% type_collection = [[nil, _('All')]] %>
-<% type_collection += Task.all_types.sort_by {|klass| klass.constantize.new.title}.map{|s| [s, s.constantize.new.title] } %>
-
+<%
+  type_collection = [[nil, _('All')]]
+  type_collection += @tasks.map { |t| [t.name, t.title] }.uniq
+%>
 <% if !@failed.blank? %>