curriculum_lattes_plugin: Refactorign plugin structure

- Indent files properly - Fix signup page changing lambda to proc - Create the needed plugin's hotspots - Fix academic_info attributes update - Fix hotspot to work in edit page

curriculum_lattes_plugin: Refactorign plugin structure
- Indent files properly - Fix signup page changing lambda to proc - Create the needed plugin's hotspots - Fix academic_info attributes update - Fix hotspot to work in edit page
Arthur Esposte · Daniela Feitosa
1 parent ba117529
Showing 16 changed files with 219 additions and 95 deletions Show diff stats
app/controllers/admin/features_controller.rb
app/controllers/my_profile/profile_editor_controller.rb
app/controllers/public/account_controller.rb
app/models/user.rb
app/views/profile_editor/_person_form.html.erb
lib/noosfero/plugin.rb
plugins/lattes_curriculum/db/migrate/20140415223448_add_url_lattes_to_person.rb
plugins/lattes_curriculum/db/migrate/20140814210103_create_academic_infos.rb
plugins/lattes_curriculum/features/lattes_curriculum.feature
plugins/lattes_curriculum/lib/academic_info.rb
plugins/lattes_curriculum/lib/ext/person.rb
plugins/lattes_curriculum/lib/html_parser.rb
plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb
plugins/lattes_curriculum/public/singup_complement.js
plugins/lattes_curriculum/test/unit/html_parser_test.rb
plugins/lattes_curriculum/test/unit/lattes_curriculum_test.rb
@@ -17,6 +17,10 @@ class FeaturesController &lt; AdminController
   def manage_fields
     @person_fields = Person.fields
+    @plugins.dispatch(:extra_person_fields).collect do |field|
+      @person_fields << field unless @person_fields.include?(field)
+    end
+
     @enterprise_fields = Enterprise.fields
     @community_fields = Community.fields
   end
@@ -15,14 +15,22 @@ class ProfileEditorController &lt; MyProfileController
     @possible_domains = profile.possible_domains
     if request.post?
       params[:profile_data][:fields_privacy] ||= {} if profile.person? && params[:profile_data].is_a?(Hash)
-      Profile.transaction do
-      Image.transaction do
-        if @profile_data.update_attributes(params[:profile_data])
-          redirect_to :action => 'index', :profile => profile.identifier
-        else
-          profile.identifier = params[:profile] if profile.identifier.blank?
+      begin
+        @plugins.dispatch(:profile_editor_transaction_extras)
+
+        Profile.transaction do
+          Image.transaction do
+            if @profile_data.update_attributes(params[:profile_data])
+              redirect_to :action => 'index', :profile => profile.identifier
+            else
+              profile.identifier = params[:profile] if profile.identifier.blank?
+            end
+          end
+        end
+      rescue Exception => ex
+        if profile.identifier.blank?
+          profile.identifier = params[:profile]
         end
-      end
       end
     end
   end
@@ -93,7 +93,13 @@ class AccountController &lt; ApplicationController
       @user.terms_of_use = environment.terms_of_use
       @user.environment = environment
       @terms_of_use = environment.terms_of_use
-      @user.person_data = params[:profile_data]
+
+      params_profile_data = params[:profile_data]
+      @plugins.dispatch(:extra_person_data_params).each do |data|
+        params_profile_data = params_profile_data.merge(data) unless params[:profile_data].blank?
+      end
+
+      @user.person_data = params_profile_data
       @user.return_to = session[:return_to]
       @person = Person.new(params[:profile_data])
       @person.environment = @user.environment
@@ -29,6 +29,8 @@ class User &lt; ActiveRecord::Base
     alias_method_chain :human_attribute_name, :customization
   end
+  include Noosfero::Plugin::HotSpot
+
   before_create do |user|
     if user.environment.nil?
       user.environment = Environment.default
@@ -46,6 +48,7 @@ class User &lt; ActiveRecord::Base
       p.environment = user.environment
       p.name ||= user.name || user.login
       p.visible = false unless user.activated?
+
       p.save!
       user.person = p
@@ -27,6 +27,10 @@
 <%= optional_field(@person, 'district', labelled_form_field(_('District'), text_field(:profile_data, :district, :rel => _('District')))) %>
 <%= optional_field(@person, 'image', labelled_form_field(_('Image'), file_field(:file, :image, :rel => _('Image')))) %>
+<% @plugins.dispatch(:extra_optional_fields).each do |field| %>
+  <%= optional_field(@person, field[:name], labelled_form_field(field[:label], text_field(field[:object_name], field[:method], :rel => field[:label], :value => field[:value]))) %>
+<% end %>
+
 <% optional_field(@person, 'schooling') do %>
   <div class="formfieldline">
     <label class='formlabel' for='profile_data_schooling'><%= _('Schooling') %></label>
@@ -531,6 +531,29 @@ class Noosfero::Plugin
     nil
   end
+  # -> Perform extra transactions related to profile in profile editor
+  # returns = true in success or raise and exception if it could not update the data
+  def profile_editor_transaction_extras
+    nil
+  end
+
+  # -> Return a list of extra person fields
+  # returns = a list of strings with fields' name
+  def extra_person_fields
+    []
+  end
+
+  # -> Return a list of hashs with the needed information to create optional fields
+  # returns = a list of hashs as {:name => "string", :label => "string", :object_name => :key, :method => :key}
+  def extra_optional_fields
+    []
+  end
+
+  # -> Return a hash with another object's params
+  def extra_person_data_params
+    {}
+  end
+
   # -> Adds additional blocks to profiles and environments.
   # Your plugin must implements a class method called 'extra_blocks'
   # that returns a hash with the following syntax.
@@ -1,9 +0,0 @@
-class AddUrlLattesToPerson < ActiveRecord::Migration
-  def self.up
-  	add_column :profiles, :lattes_url, :string
-  end
-
-  def self.down
-  	remove_column :profiles, :lattes_url
-  end
-end
@@ -0,0 +1,12 @@
+class CreateAcademicInfos < ActiveRecord::Migration
+  def self.up
+  	create_table :academic_infos do |t|
+  	  t.references :person
+      t.column :lattes_url, :string
+    end
+  end
+
+  def self.down
+    drop_table :academic_infos
+  end
+end
@@ -0,0 +1,24 @@
+Feature: import lattes information
+  As an user
+  I want to inform my lattes url address
+  So that I can import my academic informations automatically
+
+  Background:
+    Given "LattesCurriculumPlugin" plugin is enabled
+    And I am logged in as admin
+    And I go to /admin/plugins
+    And I check "LattesCurriculumPlugin"
+    And I press "Save changes"
+    And I am not logged in 
+
+  @selenium
+  Scenario: Import lattes informations after singup
+    Given I am on signup page
+    And I fill in "e-Mail" with "josesilva@example.com"
+    And I fill in "Username" with "josesilva"
+    And I fill in "Full name" with "João Silva"
+    And I fill in "Password" with "secret"
+    And I fill in "Password confirmation" with "secret"
+    And I fill in "URL Lattes" with "http://lattes.cnpq.br/2864976228727880"
+    And wait for the captcha signup time
+    And I press "Create my account"
 \ No newline at end of file
@@ -0,0 +1,14 @@
+class AcademicInfo < ActiveRecord::Base
+
+	belongs_to :person
+
+	attr_accessible :lattes_url
+  validate :lattes_url_validate?
+
+  def lattes_url_validate?
+    valid_url_start = 'http://lattes.cnpq.br/'
+    unless self.lattes_url.blank? || self.lattes_url =~ /http:\/\/lattes.cnpq.br\/\d+/ 
+      self.errors.add(:lattes_url, _("Sorry, the lattes url is not valid."))
+    end
+  end
+end
@@ -2,14 +2,17 @@ require_dependency &#39;person&#39;
 class Person
-	attr_accessible :lattes_url
-	validate :lattes_url_validate?
-
-  def lattes_url_validate?
-      valid_url_start = 'http://lattes.cnpq.br/'
-      unless self.lattes_url =~ /http:\/\/lattes.cnpq.br\/\d+/  
-			errors[:base] << "Sorry, the lattes url is not valid."      	
-      end
+  attr_accessible :lattes_url, :academic_info_attributes
+
+  has_one :academic_info, :dependent=>:delete
+
+  accepts_nested_attributes_for :academic_info
+
+  def lattes_url
+    self.academic_info.nil? ? nil : self.academic_info.lattes_url
   end
-end
 \ No newline at end of file
+  def lattes_url= value
+    self.academic_info.lattes_url = value unless self.academic_info.nil?
+  end
+end
@@ -6,55 +6,57 @@ Encoding.default_external = Encoding::UTF_8
 Encoding.default_internal = Encoding::UTF_8
 class Html_parser
-	def get_html(lattes_link = "")  
+	def get_html(lattes_link = "")
 		begin
-		    page = Nokogiri::HTML(open(lattes_link), nil, "UTF-8")
-		    page = page.css(".main-content").to_s()
-		    page = remove_class_tooltip(page)
-		    page = remove_img(page)
-		    page = remove_select(page)
-		    page = remove_footer(page)
-		    page = remove_further_informations(page)
+      page = Nokogiri::HTML(open(lattes_link), nil, "UTF-8")
+      page = page.css(".main-content").to_s()
+      page = remove_class_tooltip(page)
+      page = remove_img(page)
+      page = remove_select(page)
+      page = remove_footer(page)
+      page = remove_further_informations(page)
 		rescue
-		    page = ""
-		end 
+      page = ""
+		end
 	end
-    def remove_class_tooltip(string = "")
-        while string.include? 'class="tooltip"' do 
-            string['class="tooltip"'] = 'class="link_not_to_mark"'
-        end
-        return string
-   end
-
-    def remove_img(string = "")
-            fist_part_to_keep, *rest = string.split('<img')
-            second_part = rest.join(" ")
-            part_to_throw_away, *after_img = second_part.split('>',2)
-            string = fist_part_to_keep + after_img.join(" ")
+  def remove_class_tooltip(page = "")
+    while page.include? 'class="tooltip"' do
+      page['class="tooltip"'] = 'class="link_not_to_mark"'
     end
-    def remove_select(string = "")
-        while string.include? '<label' do
-            first_part_to_keep, *rest = string.split('<label')
-            second_part = rest.join(" ")
-            part_to_throw_away, *after_img = second_part.split('</select>')
-            string = first_part_to_keep + after_img.join(" ")
-        end
-        return string
-    end
+    return page
+  end
-    def remove_footer(string = "")
-        first_part_to_keep, *rest = string.split('<div class="rodape-cv">')
-        second_part = rest.join(" ")
-        part_to_throw_away, *after_img = second_part.split('Imprimir Curr&iacute;culo</a>')
-        string = first_part_to_keep + after_img.join(" ")
-    end
+  def remove_img(page = "")
+    fist_part_to_keep, *rest = page.split('<img')
+    second_part = rest.join(" ")
+    part_to_throw_away, *after_img = second_part.split('>',2)
+    page = fist_part_to_keep + after_img.join(" ")
+  end
-    def remove_further_informations(string = "")
-        first_part_to_keep, *rest = string.split('<a name="OutrasI')
-        second_part = rest.join(" ")
-        part_to_throw_away, *after_img = second_part.split('</div>',2)
-        string = first_part_to_keep + after_img.join(" ")
+  def remove_select(page = "")
+    while page.include? '<label' do
+      first_part_to_keep, *rest = page.split('<label')
+      second_part = rest.join(" ")
+      part_to_throw_away, *after_img = second_part.split('</select>')
+      page = first_part_to_keep + after_img.join(" ")
     end
+
+    return page
+  end
+
+  def remove_footer(page = "")
+    first_part_to_keep, *rest = page.split('<div class="rodape-cv">')
+    second_part = rest.join(" ")
+    part_to_throw_away, *after_img = second_part.split('Imprimir Curr&iacute;culo</a>')
+    page = first_part_to_keep + after_img.join(" ")
+  end
+
+  def remove_further_informations(page = "")
+    first_part_to_keep, *rest = page.split('<a name="OutrasI')
+    second_part = rest.join(" ")
+    part_to_throw_away, *after_img = second_part.split('</div>',2)
+    page = first_part_to_keep + after_img.join(" ")
+  end
 end
@@ -16,34 +16,65 @@ class LattesCurriculumPlugin &lt; Noosfero::Plugin
     true
   end
-  def signup_extra_contents
-    lambda {
-      content_tag(:div, labelled_form_field(_('URL Lattes'), text_field(:profile_data, :lattes_url, :id => 'lattes_id_field')) +
-      content_tag(:small, _('The Lattes url is the link for your own curriculum so it\'ll be shown on your profile.'), 
-        :class => 'signup-form', :id => 'lattes-id-balloon'), :id => 'signup-lattes-id') 
+  def extra_optional_fields
+    if context.profile && context.profile.person? && context.profile.academic_info.nil?
+      context.profile.academic_info = AcademicInfo.new
+    end
+
+    fields = []
+
+    lattes_url = {
+      :name => 'lattes_url',
+      :label => 'Lattes URL',
+      :object_name => :academic_infos,
+      :method => :lattes_url,
+      :value => context.profile.nil? ? "" : context.profile.academic_info.lattes_url
     }
+
+    fields << lattes_url
+
+    return fields
   end
-  def profile_info_extra_contents
-    if context.profile.person?
-      lattes_url = context.profile.lattes_url
-      lambda {
-        content_tag('div', labelled_form_field(_('URL Lattes'), text_field_tag('profile_data[lattes_url]', lattes_url, :id => 'lattes_url_field', :disabled => false)) +
-        content_tag(:small, _('The url lattes is the link for your lattes curriculum.')))
-      }
-    end
+  def extra_person_fields
+    fields = []
+
+    fields << "lattes_url"
+
+    return fields
+  end
+
+  def extra_person_data_params
+    {"academic_info_attributes" => context.params[:academic_infos]}
   end
   def profile_tabs
-    unless context.profile.lattes_url.nil?    
-      href = context.profile.lattes_url
+    unless context.profile.academic_info.nil? || context.profile.academic_info.lattes_url.nil?
+      href = context.profile.academic_info.lattes_url
       html_parser = Html_parser.new
-      { 
-        :title => _("Lattes"), 
-        :id => 'lattes_tab', 
-        :content => lambda{html_parser.get_html(href)}, 
-        :start => false 
+      {
+        :title => _("Lattes"),
+        :id => 'lattes_tab',
+        :content => lambda{html_parser.get_html(href)},
+        :start => false
       }
     end
   end
+
+  def profile_editor_transaction_extras
+    if context.profile.person?
+      if context.params.has_key?(:academic_infos)
+        academic_info_transaction
+      end
+    end
+  end
+
+  protected
+
+  def academic_info_transaction
+    AcademicInfo.transaction do
+      context.profile.academic_info.update_attributes!(context.params[:academic_infos])
+    end
+  end
+
 end
-jQuery(function($) {
+jQuery(function($){
 	$(document).ready(function(){
-		$('#lattes_id_field').blur(function() { 
+		$('#lattes_id_field').blur(function(){
 			var value = this.value
-			
 		})
-		$('#lattes_id_field').focus(function() { 
+		$('#lattes_id_field').focus(function(){
 			$('#lattes-id-balloon').fadeIn('slow')
 		})
-		$('#lattes_id_field').blur(function() {
+		$('#lattes_id_field').blur(function(){
 			$('#lattes-id-balloon').fadeOut('slow')
 		})
 	})
@@ -5,7 +5,7 @@ class HtmlParserTest &lt; ActiveSupport::TestCase
   def setup
     @parser = Html_parser.new
   end
- 
+
   should 'be not nil the instance' do
     assert_not_nil @parser
   end
@@ -5,7 +5,7 @@ class LattesCurriculumPluginTest &lt; ActiveSupport::TestCase
   def setup
     @plugin = LattesCurriculumPlugin.new
   end
- 
+
   should 'be a noosfero plugin' do
     assert_kind_of Noosfero::Plugin, @plugin
   end
	@@ -15,14 +15,22 @@ class ProfileEditorController < MyProfileController		@@ -15,14 +15,22 @@ class ProfileEditorController < MyProfileController
15	@possible_domains = profile.possible_domains	15	@possible_domains = profile.possible_domains
16	if request.post?	16	if request.post?
17	params[:profile_data][:fields_privacy] \|\|= {} if profile.person? && params[:profile_data].is_a?(Hash)	17	params[:profile_data][:fields_privacy] \|\|= {} if profile.person? && params[:profile_data].is_a?(Hash)
18	- Profile.transaction do
19	- Image.transaction do
20	- if @profile_data.update_attributes(params[:profile_data])
21	- redirect_to :action => 'index', :profile => profile.identifier
22	- else
23	- profile.identifier = params[:profile] if profile.identifier.blank?	18	+ begin
		19	+ @plugins.dispatch(:profile_editor_transaction_extras)
		20	+
		21	+ Profile.transaction do
		22	+ Image.transaction do
		23	+ if @profile_data.update_attributes(params[:profile_data])
		24	+ redirect_to :action => 'index', :profile => profile.identifier
		25	+ else
		26	+ profile.identifier = params[:profile] if profile.identifier.blank?
		27	+ end
		28	+ end
		29	+ end
		30	+ rescue Exception => ex
		31	+ if profile.identifier.blank?
		32	+ profile.identifier = params[:profile]
24	end	33	end
25	- end
26	end	34	end
27	end	35	end
28	end	36	end
	@@ -531,6 +531,29 @@ class Noosfero::Plugin		@@ -531,6 +531,29 @@ class Noosfero::Plugin
531	nil	531	nil
532	end	532	end
533		533
		534	+ # -> Perform extra transactions related to profile in profile editor
		535	+ # returns = true in success or raise and exception if it could not update the data
		536	+ def profile_editor_transaction_extras
		537	+ nil
		538	+ end
		539	+
		540	+ # -> Return a list of extra person fields
		541	+ # returns = a list of strings with fields' name
		542	+ def extra_person_fields
		543	+ []
		544	+ end
		545	+
		546	+ # -> Return a list of hashs with the needed information to create optional fields
		547	+ # returns = a list of hashs as {:name => "string", :label => "string", :object_name => :key, :method => :key}
		548	+ def extra_optional_fields
		549	+ []
		550	+ end
		551	+
		552	+ # -> Return a hash with another object's params
		553	+ def extra_person_data_params
		554	+ {}
		555	+ end
		556	+
534	# -> Adds additional blocks to profiles and environments.	557	# -> Adds additional blocks to profiles and environments.
535	# Your plugin must implements a class method called 'extra_blocks'	558	# Your plugin must implements a class method called 'extra_blocks'
536	# that returns a hash with the following syntax.	559	# that returns a hash with the following syntax.
	@@ -1,9 +0,0 @@	@@ -1,9 +0,0 @@
1	-class AddUrlLattesToPerson < ActiveRecord::Migration
2	- def self.up
3	- add_column :profiles, :lattes_url, :string
4	- end
5	-
6	- def self.down
7	- remove_column :profiles, :lattes_url
8	- end
9	-end
@@ -0,0 +1,12 @@		@@ -0,0 +1,12 @@
	1	+class CreateAcademicInfos < ActiveRecord::Migration
	2	+ def self.up
	3	+ create_table :academic_infos do \|t\|
	4	+ t.references :person
	5	+ t.column :lattes_url, :string
	6	+ end
	7	+ end
	8	+
	9	+ def self.down
	10	+ drop_table :academic_infos
	11	+ end
	12	+end
	@@ -0,0 +1,24 @@		@@ -0,0 +1,24 @@
		1	+Feature: import lattes information
		2	+ As an user
		3	+ I want to inform my lattes url address
		4	+ So that I can import my academic informations automatically
		5	+
		6	+ Background:
		7	+ Given "LattesCurriculumPlugin" plugin is enabled
		8	+ And I am logged in as admin
		9	+ And I go to /admin/plugins
		10	+ And I check "LattesCurriculumPlugin"
		11	+ And I press "Save changes"
		12	+ And I am not logged in
		13	+
		14	+ @selenium
		15	+ Scenario: Import lattes informations after singup
		16	+ Given I am on signup page
		17	+ And I fill in "e-Mail" with "josesilva@example.com"
		18	+ And I fill in "Username" with "josesilva"
		19	+ And I fill in "Full name" with "João Silva"
		20	+ And I fill in "Password" with "secret"
		21	+ And I fill in "Password confirmation" with "secret"
		22	+ And I fill in "URL Lattes" with "http://lattes.cnpq.br/2864976228727880"
		23	+ And wait for the captcha signup time
		24	+ And I press "Create my account"
0	\ No newline at end of file	25	\ No newline at end of file
@@ -0,0 +1,14 @@		@@ -0,0 +1,14 @@
	1	+class AcademicInfo < ActiveRecord::Base
	2	+
	3	+ belongs_to :person
	4	+
	5	+ attr_accessible :lattes_url
	6	+ validate :lattes_url_validate?
	7	+
	8	+ def lattes_url_validate?
	9	+ valid_url_start = 'http://lattes.cnpq.br/'
	10	+ unless self.lattes_url.blank? \|\| self.lattes_url =~ /http:\/\/lattes.cnpq.br\/\d+/
	11	+ self.errors.add(:lattes_url, _("Sorry, the lattes url is not valid."))
	12	+ end
	13	+ end
	14	+end
	@@ -16,34 +16,65 @@ class LattesCurriculumPlugin < Noosfero::Plugin		@@ -16,34 +16,65 @@ class LattesCurriculumPlugin < Noosfero::Plugin
16	true	16	true
17	end	17	end
18		18
19	- def signup_extra_contents
20	- lambda {
21	- content_tag(:div, labelled_form_field(_('URL Lattes'), text_field(:profile_data, :lattes_url, :id => 'lattes_id_field')) +
22	- content_tag(:small, _('The Lattes url is the link for your own curriculum so it\'ll be shown on your profile.'),
23	- :class => 'signup-form', :id => 'lattes-id-balloon'), :id => 'signup-lattes-id')	19	+ def extra_optional_fields
		20	+ if context.profile && context.profile.person? && context.profile.academic_info.nil?
		21	+ context.profile.academic_info = AcademicInfo.new
		22	+ end
		23	+
		24	+ fields = []
		25	+
		26	+ lattes_url = {
		27	+ :name => 'lattes_url',
		28	+ :label => 'Lattes URL',
		29	+ :object_name => :academic_infos,
		30	+ :method => :lattes_url,
		31	+ :value => context.profile.nil? ? "" : context.profile.academic_info.lattes_url
24	}	32	}
		33	+
		34	+ fields << lattes_url
		35	+
		36	+ return fields
25	end	37	end
26		38
27	- def profile_info_extra_contents
28	- if context.profile.person?
29	- lattes_url = context.profile.lattes_url
30	- lambda {
31	- content_tag('div', labelled_form_field(_('URL Lattes'), text_field_tag('profile_data[lattes_url]', lattes_url, :id => 'lattes_url_field', :disabled => false)) +
32	- content_tag(:small, _('The url lattes is the link for your lattes curriculum.')))
33	- }
34	- end	39	+ def extra_person_fields
		40	+ fields = []
		41	+
		42	+ fields << "lattes_url"
		43	+
		44	+ return fields
		45	+ end
		46	+
		47	+ def extra_person_data_params
		48	+ {"academic_info_attributes" => context.params[:academic_infos]}
35	end	49	end
36		50
37	def profile_tabs	51	def profile_tabs
38	- unless context.profile.lattes_url.nil?
39	- href = context.profile.lattes_url	52	+ unless context.profile.academic_info.nil? \|\| context.profile.academic_info.lattes_url.nil?
		53	+ href = context.profile.academic_info.lattes_url
40	html_parser = Html_parser.new	54	html_parser = Html_parser.new
41	- {
42	- :title => _("Lattes"),
43	- :id => 'lattes_tab',
44	- :content => lambda{html_parser.get_html(href)},
45	- :start => false	55	+ {
		56	+ :title => _("Lattes"),
		57	+ :id => 'lattes_tab',
		58	+ :content => lambda{html_parser.get_html(href)},
		59	+ :start => false
46	}	60	}
47	end	61	end
48	end	62	end
		63	+
		64	+ def profile_editor_transaction_extras
		65	+ if context.profile.person?
		66	+ if context.params.has_key?(:academic_infos)
		67	+ academic_info_transaction
		68	+ end
		69	+ end
		70	+ end
		71	+
		72	+ protected
		73	+
		74	+ def academic_info_transaction
		75	+ AcademicInfo.transaction do
		76	+ context.profile.academic_info.update_attributes!(context.params[:academic_infos])
		77	+ end
		78	+ end
		79	+
49	end	80	end
	@@ -5,7 +5,7 @@ class HtmlParserTest < ActiveSupport::TestCase		@@ -5,7 +5,7 @@ class HtmlParserTest < ActiveSupport::TestCase
5	def setup	5	def setup
6	@parser = Html_parser.new	6	@parser = Html_parser.new
7	end	7	end
8	-	8	+
9	should 'be not nil the instance' do	9	should 'be not nil the instance' do
10	assert_not_nil @parser	10	assert_not_nil @parser
11	end	11	end
	@@ -5,7 +5,7 @@ class LattesCurriculumPluginTest < ActiveSupport::TestCase		@@ -5,7 +5,7 @@ class LattesCurriculumPluginTest < ActiveSupport::TestCase
5	def setup	5	def setup
6	@plugin = LattesCurriculumPlugin.new	6	@plugin = LattesCurriculumPlugin.new
7	end	7	end
8	-	8	+
9	should 'be a noosfero plugin' do	9	should 'be a noosfero plugin' do
10	assert_kind_of Noosfero::Plugin, @plugin	10	assert_kind_of Noosfero::Plugin, @plugin
11	end	11	end