adding uni tests for points type and points categorization

Leandro Santos
1 parent 27f9186b
Showing 4 changed files with 77 additions and 8 deletions Show diff stats
models/gamification_plugin/points_categorization.rb
models/gamification_plugin/points_type.rb
test/unit/gamification_plugin_points_categorizations_test.rb
test/unit/gamification_plugin_points_types_test.rb
@@ -3,7 +3,9 @@ class GamificationPlugin::PointsCategorization &lt; Noosfero::Plugin::ActiveRecord
   belongs_to :point_type, class_name: 'GamificationPlugin::PointsType', foreign_key: :point_type_id
   attr_accessible :profile_id, :profile, :point_type_id, :weight
  
-  validates_presence_of :point_type_id, :weight
+  validates_presence_of :weight
+  validates :point_type_id, presence: true, uniqueness: { scope: :profile_id, message: _("should have only one point type per profile") } 
+#  validates :point_type_id, presence: true, uniqueness: true
  
   scope :for_type, lambda { |p_type| joins(:point_type).where(gamification_plugin_points_types: {name: p_type}) }
   scope :for_profile, lambda { |p_profile| joins(:profile).where(profiles: {identifier: p_profile}) }
 class GamificationPlugin::PointsType < Noosfero::Plugin::ActiveRecord
   attr_accessible :description, :name
  
-  validates_presence_of :name
+  validates :name, presence: true, uniqueness: true
+
 end
 require 'test_helper'
  
 class GamificationPluginPointsCategorizationsTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+
+  should 'require value for weight' do
+    p = GamificationPlugin::PointsCategorization.new
+    p.valid?
+    assert p.errors[:weight].present?
+
+    p.weight = 12
+    p.valid?
+    refute p.errors[:weight].present?
+  end
+
+  should 'require value for point type' do
+    p = GamificationPlugin::PointsCategorization.new
+    p.valid?
+    assert p.errors[:point_type_id].present?
+
+    p.point_type = GamificationPlugin::PointsType.create!(:name => 'some')
+    p.valid?
+    refute p.errors[:point_type_id].present?
+  end
+
+  should 'the point type be unique in profile scope' do
+    point_type = GamificationPlugin::PointsType.create!(:name => 'some')
+    profile = fast_create(Community)
+    GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => profile.id).save!
+
+    p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => profile.id)
+    p.valid?
+    assert p.errors[:point_type_id].present?
+  end
+  
+  
+  should 'the point type be unique in profile scope when profile is nil' do
+    point_type = GamificationPlugin::PointsType.create!(:name => 'some')
+    GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id).save!
+
+    p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id)
+    p.valid?
+    assert p.errors[:point_type_id].present?
+  end
+  
+  should 'the point type be used in differente profile scopes' do
+    point_type = GamificationPlugin::PointsType.create!(:name => 'some')
+    p1 = fast_create(Community)
+    GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => p1.id).save!
+
+    p2 = fast_create(Community)
+    p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => p2.id)
+    p.valid?
+    refute p.errors[:point_type_id].present?
+  end
+  
 end
 require 'test_helper'
  
 class GamificationPluginPointsTypesTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+
+  should 'require value for name' do
+    p = GamificationPlugin::PointsType.new
+    p.valid?
+    assert p.errors[:name].present?
+
+    p.name = 'some'
+    p.valid?
+    refute p.errors[:name].present?
+  end
+
+  should 'the name be unique' do
+    GamificationPlugin::PointsType.new(:name => 'some').save!
+
+    p = GamificationPlugin::PointsType.new(:name => 'some')
+    p.valid?
+    assert p.errors[:name].present?
+  end
+
+
 end
...	...	@@ -3,7 +3,9 @@ class GamificationPlugin::PointsCategorization < Noosfero::Plugin::ActiveRecord
3	3	belongs_to :point_type, class_name: 'GamificationPlugin::PointsType', foreign_key: :point_type_id
4	4	attr_accessible :profile_id, :profile, :point_type_id, :weight
5	5
6		- validates_presence_of :point_type_id, :weight
	6	+ validates_presence_of :weight
	7	+ validates :point_type_id, presence: true, uniqueness: { scope: :profile_id, message: _("should have only one point type per profile") }
	8	+# validates :point_type_id, presence: true, uniqueness: true
7	9
8	10	scope :for_type, lambda { \|p_type\| joins(:point_type).where(gamification_plugin_points_types: {name: p_type}) }
9	11	scope :for_profile, lambda { \|p_profile\| joins(:profile).where(profiles: {identifier: p_profile}) }
...	...
1	1	class GamificationPlugin::PointsType < Noosfero::Plugin::ActiveRecord
2	2	attr_accessible :description, :name
3	3
4		- validates_presence_of :name
	4	+ validates :name, presence: true, uniqueness: true
	5	+
5	6	end
...	...
1	1	require 'test_helper'
2	2
3	3	class GamificationPluginPointsCategorizationsTest < ActiveSupport::TestCase
4		- # test "the truth" do
5		- # assert true
6		- # end
	4	+
	5	+ should 'require value for weight' do
	6	+ p = GamificationPlugin::PointsCategorization.new
	7	+ p.valid?
	8	+ assert p.errors[:weight].present?
	9	+
	10	+ p.weight = 12
	11	+ p.valid?
	12	+ refute p.errors[:weight].present?
	13	+ end
	14	+
	15	+ should 'require value for point type' do
	16	+ p = GamificationPlugin::PointsCategorization.new
	17	+ p.valid?
	18	+ assert p.errors[:point_type_id].present?
	19	+
	20	+ p.point_type = GamificationPlugin::PointsType.create!(:name => 'some')
	21	+ p.valid?
	22	+ refute p.errors[:point_type_id].present?
	23	+ end
	24	+
	25	+ should 'the point type be unique in profile scope' do
	26	+ point_type = GamificationPlugin::PointsType.create!(:name => 'some')
	27	+ profile = fast_create(Community)
	28	+ GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => profile.id).save!
	29	+
	30	+ p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => profile.id)
	31	+ p.valid?
	32	+ assert p.errors[:point_type_id].present?
	33	+ end
	34	+
	35	+
	36	+ should 'the point type be unique in profile scope when profile is nil' do
	37	+ point_type = GamificationPlugin::PointsType.create!(:name => 'some')
	38	+ GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id).save!
	39	+
	40	+ p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id)
	41	+ p.valid?
	42	+ assert p.errors[:point_type_id].present?
	43	+ end
	44	+
	45	+ should 'the point type be used in differente profile scopes' do
	46	+ point_type = GamificationPlugin::PointsType.create!(:name => 'some')
	47	+ p1 = fast_create(Community)
	48	+ GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => p1.id).save!
	49	+
	50	+ p2 = fast_create(Community)
	51	+ p = GamificationPlugin::PointsCategorization.new(:weight => 10, :point_type_id => point_type.id, :profile_id => p2.id)
	52	+ p.valid?
	53	+ refute p.errors[:point_type_id].present?
	54	+ end
	55	+
7	56	end
...	...
1	1	require 'test_helper'
2	2
3	3	class GamificationPluginPointsTypesTest < ActiveSupport::TestCase
4		- # test "the truth" do
5		- # assert true
6		- # end
	4	+
	5	+ should 'require value for name' do
	6	+ p = GamificationPlugin::PointsType.new
	7	+ p.valid?
	8	+ assert p.errors[:name].present?
	9	+
	10	+ p.name = 'some'
	11	+ p.valid?
	12	+ refute p.errors[:name].present?
	13	+ end
	14	+
	15	+ should 'the name be unique' do
	16	+ GamificationPlugin::PointsType.new(:name => 'some').save!
	17	+
	18	+ p = GamificationPlugin::PointsType.new(:name => 'some')
	19	+ p.valid?
	20	+ assert p.errors[:name].present?
	21	+ end
	22	+
	23	+
7	24	end
...	...