Fixed compound and metric configuration tests

Signed off by: Daniel Alves <danpaulalves@gmail.com>

Fixed compound and metric configuration tests
Signed off by: Daniel Alves <danpaulalves@gmail.com>
Heitor · Diego Camarinha
1 parent c99fce96
Showing 9 changed files with 15 additions and 15 deletions Show diff stats
features/compound_metric_configuration/edition.feature
features/metric_configuration/delete.feature
features/metric_configuration/listing.feature
features/step_definitions/metric_configuration_steps.rb
spec/models/validators/beginning_uniqueness_validator_spec.rb
spec/models/validators/code_uniqueness_validator_spec.rb
spec/models/validators/greater_than_beginning_validator_spec.rb
spec/models/validators/kalibro_uniqueness_validator_spec.rb
spec/models/validators/range_overlapping_validator_spec.rb
@@ -59,5 +59,5 @@ Feature: Compound Metric Configuration edition
     When I visit the sample compound metric configuration edit page
     And I fill the Code field with "Another_Code"
     And I press the Save button
-    Then I should see "Code There's already"
+    Then I should see "Code There is already a MetricConfiguration with code Another_Code! Please, choose another one."
@@ -12,7 +12,7 @@ Feature: Metric Configuration Deletion
     And I have a sample metric configuration within the given mezuro configuration
     When I am at the Sample Configuration page
     And I click the Destroy link
-    Then I should see "There are no metric configurations yet!"
+    Then I should see "There are no Metric Configurations yet!"
   @kalibro_restart
   Scenario: Should not see the destroy metric configuration link in the mezuro configuration that I not own
@@ -22,4 +22,4 @@ Feature: Metric Configuration Deletion
     And I have a sample reading group
     And I have a sample metric configuration within the given mezuro configuration
     When I am at the Sample Configuration page
-    Then I should not see "Destroy"
 \ No newline at end of file
+    Then I should not see "Destroy"
@@ -4,13 +4,13 @@ Feature: Configuration listing
   I should see the metric configurations of a given configuration
   @kalibro_restart
-  Scenario: When there is no metric configurations
+  Scenario: When there are no metric configurations
     Given I have a sample configuration
     When I am at the Sample Configuration page
     Then I should see "Metric Name"
     And I should see "Code"
     And I should see "Weight"
-    And I should see "There are no metric configurations yet!"
+    And I should see "There are no Metric Configurations yet!"
   @kalibro_restart
   Scenario: When there are metric configurations
@@ -34,4 +34,4 @@ Feature: Configuration listing
     And I am signed in
     And I have a sample configuration
     When I am at the Sample Configuration page
-    Then I should not see Add Metric link
 \ No newline at end of file
+    Then I should not see Add Metric link
@@ -38,5 +38,5 @@ Then(/^I should be at metric configuration sample page$/) do
 end
 Then(/^I should be at the choose metric page$/) do
-  expect(page).to have_content("Choose a metric from a base tool:")
+  expect(page).to have_content("Choose a metric from a Base Tool:")
 end
@@ -28,7 +28,7 @@ describe BeginningUniquenessValidator, :type =&gt; :model do
         it 'should contain errors' do
           @subject.save
-          expect(@subject.errors[:beginning]).to eq(["There's already a MezuroRange with beginning #{@subject.beginning}! Please, choose another one."])
+          expect(@subject.errors[:beginning]).to eq(["There is already a MezuroRange with beginning #{@subject.beginning}! Please, choose another one."])
         end
       end
     end
@@ -24,9 +24,9 @@ describe CodeUniquenessValidator, :type =&gt; :model do
         it 'should contain errors' do
           @subject.save
-          expect(@subject.errors[:code]).to eq(["There's already a MetricConfiguration with code #{@subject.code}! Please, choose another one."])
+          expect(@subject.errors[:code]).to eq(["There is already a MetricConfiguration with code #{@subject.code}! Please, choose another one."])
         end
       end
     end
   end
-end
 \ No newline at end of file
+end
@@ -11,7 +11,7 @@ describe GreaterThanBeginningValidator, :type =&gt; :model do
         subject { FactoryGirl.build(:mezuro_range, end: "-INF") }
         it 'is expected to return an error' do
           subject.save
-          expect(subject.errors[:end]).to eq(["The end value should be greater than the beginning value."])
+          expect(subject.errors[:end]).to eq(["The End value should be greater than the Beginning value."])
         end
       end
       context 'when beginning is -INF or end is INF' do
@@ -25,7 +25,7 @@ describe GreaterThanBeginningValidator, :type =&gt; :model do
         subject { FactoryGirl.build(:mezuro_range, beginning: 1.0, end: 0.0) }
         it 'is expected to return an error' do
           subject.save
-          expect(subject.errors[:end]).to eq(["The end value should be greater than the beginning value."])
+          expect(subject.errors[:end]).to eq(["The End value should be greater than the Beginning value."])
         end
       end
       context 'when beginning is smaller than end' do
@@ -24,9 +24,9 @@ describe KalibroUniquenessValidator, :type =&gt; :model do
         it 'should contain errors' do
           @subject.save
-          expect(@subject.errors[:name]).to eq(["There's already a Project with name #{@subject.name}! Please, choose another one."])
+          expect(@subject.errors[:name]).to eq(["There is already a Project with name #{@subject.name}! Please, choose another one."])
         end
       end
     end
   end
-end
 \ No newline at end of file
+end
@@ -34,7 +34,7 @@ describe RangeOverlappingValidator, :type =&gt; :model do
         it 'is expected to return errors' do
           range.save
-          expect(range.errors[:beginning]).to eq(["There's already a #{range.class} within these boundaries! Please, choose another ones."])
+          expect(range.errors[:beginning]).to eq(["There is already a #{range.class} within these boundaries! Please, choose another interval."])
         end
       end
     end
	@@ -59,5 +59,5 @@ Feature: Compound Metric Configuration edition		@@ -59,5 +59,5 @@ Feature: Compound Metric Configuration edition
59	When I visit the sample compound metric configuration edit page	59	When I visit the sample compound metric configuration edit page
60	And I fill the Code field with "Another_Code"	60	And I fill the Code field with "Another_Code"
61	And I press the Save button	61	And I press the Save button
62	- Then I should see "Code There's already"	62	+ Then I should see "Code There is already a MetricConfiguration with code Another_Code! Please, choose another one."
63		63
	@@ -38,5 +38,5 @@ Then(/^I should be at metric configuration sample page$/) do		@@ -38,5 +38,5 @@ Then(/^I should be at metric configuration sample page$/) do
38	end	38	end
39		39
40	Then(/^I should be at the choose metric page$/) do	40	Then(/^I should be at the choose metric page$/) do
41	- expect(page).to have_content("Choose a metric from a base tool:")	41	+ expect(page).to have_content("Choose a metric from a Base Tool:")
42	end	42	end
	@@ -28,7 +28,7 @@ describe BeginningUniquenessValidator, :type => :model do		@@ -28,7 +28,7 @@ describe BeginningUniquenessValidator, :type => :model do
28		28
29	it 'should contain errors' do	29	it 'should contain errors' do
30	@subject.save	30	@subject.save
31	- expect(@subject.errors[:beginning]).to eq(["There's already a MezuroRange with beginning #{@subject.beginning}! Please, choose another one."])	31	+ expect(@subject.errors[:beginning]).to eq(["There is already a MezuroRange with beginning #{@subject.beginning}! Please, choose another one."])
32	end	32	end
33	end	33	end
34	end	34	end
	@@ -11,7 +11,7 @@ describe GreaterThanBeginningValidator, :type => :model do		@@ -11,7 +11,7 @@ describe GreaterThanBeginningValidator, :type => :model do
11	subject { FactoryGirl.build(:mezuro_range, end: "-INF") }	11	subject { FactoryGirl.build(:mezuro_range, end: "-INF") }
12	it 'is expected to return an error' do	12	it 'is expected to return an error' do
13	subject.save	13	subject.save
14	- expect(subject.errors[:end]).to eq(["The end value should be greater than the beginning value."])	14	+ expect(subject.errors[:end]).to eq(["The End value should be greater than the Beginning value."])
15	end	15	end
16	end	16	end
17	context 'when beginning is -INF or end is INF' do	17	context 'when beginning is -INF or end is INF' do
	@@ -25,7 +25,7 @@ describe GreaterThanBeginningValidator, :type => :model do		@@ -25,7 +25,7 @@ describe GreaterThanBeginningValidator, :type => :model do
25	subject { FactoryGirl.build(:mezuro_range, beginning: 1.0, end: 0.0) }	25	subject { FactoryGirl.build(:mezuro_range, beginning: 1.0, end: 0.0) }
26	it 'is expected to return an error' do	26	it 'is expected to return an error' do
27	subject.save	27	subject.save
28	- expect(subject.errors[:end]).to eq(["The end value should be greater than the beginning value."])	28	+ expect(subject.errors[:end]).to eq(["The End value should be greater than the Beginning value."])
29	end	29	end
30	end	30	end
31	context 'when beginning is smaller than end' do	31	context 'when beginning is smaller than end' do
	@@ -34,7 +34,7 @@ describe RangeOverlappingValidator, :type => :model do		@@ -34,7 +34,7 @@ describe RangeOverlappingValidator, :type => :model do
34		34
35	it 'is expected to return errors' do	35	it 'is expected to return errors' do
36	range.save	36	range.save
37	- expect(range.errors[:beginning]).to eq(["There's already a #{range.class} within these boundaries! Please, choose another ones."])	37	+ expect(range.errors[:beginning]).to eq(["There is already a #{range.class} within these boundaries! Please, choose another interval."])
38	end	38	end
39	end	39	end
40	end	40	end