Coveralls removed from Cucumber tests and better approach to strong params with Devise

Rafael Manzo
1 parent ce2f073d
Showing 2 changed files with 2 additions and 7 deletions Show diff stats
app/controllers/application_controller.rb
features/support/env.rb
@@ -13,7 +13,7 @@ class ApplicationController &lt; ActionController::Base
   # Since creating the controllers looks wronger than not testing this two
   # lines. I think we can live without 100% of coverage
   def configure_permitted_parameters
-    devise_parameter_sanitizer.for(:sign_up) { |u| u.permit(:name, :email, :password, :password_confirmation) }
-    devise_parameter_sanitizer.for(:account_update) { |u| u.permit(:name, :email, :password, :password_confirmation, :current_password) }
+    devise_parameter_sanitizer.for(:sign_up) << :name
+    devise_parameter_sanitizer.for(:account_update) << :name
   end
 end
 require 'simplecov'
-require 'coveralls'
  
 SimpleCov.start do
-  formatter SimpleCov::Formatter::MultiFormatter[
-                Coveralls::SimpleCov::Formatter,
-                SimpleCov::Formatter::HTMLFormatter
-              ]
   coverage_dir 'coverage/cucumber'
  
   add_group "Models", "app/models"
...	...	@@ -13,7 +13,7 @@ class ApplicationController < ActionController::Base
13	13	# Since creating the controllers looks wronger than not testing this two
14	14	# lines. I think we can live without 100% of coverage
15	15	def configure_permitted_parameters
16		- devise_parameter_sanitizer.for(:sign_up) { \|u\| u.permit(:name, :email, :password, :password_confirmation) }
17		- devise_parameter_sanitizer.for(:account_update) { \|u\| u.permit(:name, :email, :password, :password_confirmation, :current_password) }
	16	+ devise_parameter_sanitizer.for(:sign_up) << :name
	17	+ devise_parameter_sanitizer.for(:account_update) << :name
18	18	end
19	19	end
...	...
1	1	require 'simplecov'
2		-require 'coveralls'
3	2
4	3	SimpleCov.start do
5		- formatter SimpleCov::Formatter::MultiFormatter[
6		- Coveralls::SimpleCov::Formatter,
7		- SimpleCov::Formatter::HTMLFormatter
8		- ]
9	4	coverage_dir 'coverage/cucumber'
10	5
11	6	add_group "Models", "app/models"
...	...