Fixed module name formating for the tree

Rafael Manzo
1 parent dd333bfe
Showing 3 changed files with 39 additions and 1 deletions Show diff stats
app/helpers/processings_helper.rb
app/views/repositories/_module_result.html.erb
spec/helpers/processings_helper_spec.rb
@@ -14,4 +14,14 @@ module ProcessingsHelper
       return range_snapshot if (range_snapshot.beginning <= metric_result.value && range_snapshot.end >= metric_result.value)
     end
   end
+
+  def format_module_name(module_name)
+    if module_name.is_a?(Array)
+      module_name.last
+    elsif module_name.is_a?(String)
+      module_name
+    else
+      module_name.to_s
+    end
+  end
 end
 \ No newline at end of file
@@ -5,7 +5,7 @@
     <% else %>
       <i class="icon-file"></i>
     <% end %>
-    <%= link_to module_result.module.name, project_repository_module_path(repository.project_id, repository.id, module_result.id) %>
+    <%= link_to format_module_name(module_result.module.name), project_repository_module_path(repository.project_id, repository.id, module_result.id) %>
   </td>
 	<td><%= module_result.module.granularity %></td>
 	<td><%= format_grade(module_result.grade) %></td>
@@ -31,4 +31,32 @@ describe ProcessingsHelper do
       helper.find_range_snapshot(metric_result).should eq(range_snapshot_5dot1_to_10)
     end
   end
+
+  describe 'format_module_name' do
+    context 'when it is a String' do
+      let(:name) { 'org' }
+
+      it 'should not make any change' do
+        helper.format_module_name(name).should eq(name)
+      end
+    end
+
+    context 'when it is a Array' do
+      let(:name) { ['org', 'mezuro'] }
+
+      it "should return it's last element" do
+        helper.format_module_name(name).should eq(name.last)
+      end
+    end
+
+    context 'when it is a neither Array or String' do
+      let(:name) { Object.new }
+
+      it "should try to convert it to String" do
+        name.expects(:to_s)
+
+        helper.format_module_name(name)
+      end
+    end
+  end
 end
 \ No newline at end of file
...	...	@@ -14,4 +14,14 @@ module ProcessingsHelper
14	14	return range_snapshot if (range_snapshot.beginning <= metric_result.value && range_snapshot.end >= metric_result.value)
15	15	end
16	16	end
	17	+
	18	+ def format_module_name(module_name)
	19	+ if module_name.is_a?(Array)
	20	+ module_name.last
	21	+ elsif module_name.is_a?(String)
	22	+ module_name
	23	+ else
	24	+ module_name.to_s
	25	+ end
	26	+ end
17	27	end
18	28	\ No newline at end of file
...	...
...	...	@@ -5,7 +5,7 @@
5	5	<% else %>
6	6	<i class="icon-file"></i>
7	7	<% end %>
8		- <%= link_to module_result.module.name, project_repository_module_path(repository.project_id, repository.id, module_result.id) %>
	8	+ <%= link_to format_module_name(module_result.module.name), project_repository_module_path(repository.project_id, repository.id, module_result.id) %>
9	9	</td>
10	10	<td><%= module_result.module.granularity %></td>
11	11	<td><%= format_grade(module_result.grade) %></td>
...	...
...	...	@@ -31,4 +31,32 @@ describe ProcessingsHelper do
31	31	helper.find_range_snapshot(metric_result).should eq(range_snapshot_5dot1_to_10)
32	32	end
33	33	end
	34	+
	35	+ describe 'format_module_name' do
	36	+ context 'when it is a String' do
	37	+ let(:name) { 'org' }
	38	+
	39	+ it 'should not make any change' do
	40	+ helper.format_module_name(name).should eq(name)
	41	+ end
	42	+ end
	43	+
	44	+ context 'when it is a Array' do
	45	+ let(:name) { ['org', 'mezuro'] }
	46	+
	47	+ it "should return it's last element" do
	48	+ helper.format_module_name(name).should eq(name.last)
	49	+ end
	50	+ end
	51	+
	52	+ context 'when it is a neither Array or String' do
	53	+ let(:name) { Object.new }
	54	+
	55	+ it "should try to convert it to String" do
	56	+ name.expects(:to_s)
	57	+
	58	+ helper.format_module_name(name)
	59	+ end
	60	+ end
	61	+ end
34	62	end
35	63	\ No newline at end of file
...	...