Dealt with the caser where there is no processing for a given repository

Rafael Manzo · Paulo Meireles
1 parent 329cd2d3
Showing 6 changed files with 44 additions and 7 deletions Show diff stats
app/controllers/repositories_controller.rb
app/models/repository.rb
app/views/repositories/_unstarted_processing.html.erb
app/views/repositories/unprocessed.js.erb
spec/controllers/repositories_controller_spec.rb
spec/models/repository_spec.rb
@@ -31,7 +31,7 @@ class RepositoriesController &lt; ApplicationController
   # POST /projects/1/repositories.json
   def create
     @repository = Repository.new(repository_params)
-    @repository.project_id = params[:project_id] 
+    @repository.project_id = params[:project_id]
     respond_to do |format|
       create_and_redir(format)
@@ -62,12 +62,14 @@ class RepositoriesController &lt; ApplicationController
   end
   # POST /projects/1/repositories/1/state
-  def state 
+  def state
     if params[:last_state] != 'READY'
       @processing = @repository.last_processing
       respond_to do |format|
-        if @processing.state == 'READY'
+        if @processing.nil?
+          format.js { render action: 'unprocessed' }
+        elsif @processing.state == 'READY'
           format.js { render action: 'load_ready_processing' }
         else
           format.js { render action: 'reload_processing' }
@@ -83,7 +85,7 @@ private
   def failed_action(format, destiny_action)
     @project_id = params[:project_id]
     @repository_types = Repository.repository_types
-    
+
     format.html { render action: destiny_action }
     format.json { render json: @repository.errors, status: :unprocessable_entity }
   end
@@ -5,6 +5,10 @@ class Repository &lt; KalibroGem::Entities::Repository
   validates :address, presence: true
   def last_processing
-    Processing.processing_of(@id)
+    if Processing.has_processing(@id)
+      Processing.processing_of(@id)
+    else
+      nil
+    end
   end
 end
@@ -0,0 +1,3 @@
+<p>This repository has no processings yet. Please hold tight that as soon as possible we'll start it!</p>
+
+<div id="processing_information"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
 \ No newline at end of file
@@ -0,0 +1,3 @@
+$('div#processing_information').html('<%= escape_javascript(render partial: "unstarted_processing") %>');
+repository = new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)
+repository.schedule_poll_state('')
 \ No newline at end of file
@@ -255,6 +255,19 @@ describe RepositoriesController do
   describe 'state' do
     let(:repository) { FactoryGirl.build(:repository) }
+    context 'with no processing at all' do
+      before :each do
+        repository.expects(:last_processing).returns(nil)
+        Repository.expects(:find).at_least_once.with(repository.id).returns(repository)
+
+        request.env["HTTP_ACCEPT"] = 'application/javascript' # FIXME: there should be a better way to force JS
+        get :state, project_id: project.id.to_s, id: repository.id, last_state: ''
+      end
+
+      it { should respond_with(:success) }
+      it { should render_template(:unprocessed) }
+    end
+
     context 'with a READY state' do
       let(:ready_processing) { FactoryGirl.build(:processing) }
@@ -5,10 +5,21 @@ describe Repository do
     describe 'last_processing' do
       subject { FactoryGirl.build(:repository) }
+      context 'with no processing at all' do
+        before :each do
+          Processing.expects(:has_processing).with(subject.id).returns(false)
+        end
+
+        it 'should return nil' do
+          subject.last_processing.should be_nil
+        end
+      end
+
       context 'with a ready processing' do
         let(:processing) { FactoryGirl.build(:processing) }
         before :each do
+          Processing.expects(:has_processing).with(subject.id).returns(true)
           Processing.expects(:has_ready_processing).with(subject.id).returns(true)
         end
@@ -23,6 +34,7 @@ describe Repository do
         let(:processing) { FactoryGirl.build(:processing, state: 'COLLECTING') }
         before :each do
+          Processing.expects(:has_processing).with(subject.id).returns(true)
           Processing.expects(:has_ready_processing).with(subject.id).returns(false)
         end
@@ -37,8 +49,8 @@ describe Repository do
   describe 'validations' do
     subject {FactoryGirl.build(:repository)}
-    
-    context 'active model validations' do  
+
+    context 'active model validations' do
       before :each do
         Repository.expects(:all).at_least_once.returns([])
       end
	@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
		1	+<p>This repository has no processings yet. Please hold tight that as soon as possible we'll start it!</p>
		2	+
		3	+<div id="processing_information"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
0	\ No newline at end of file	4	\ No newline at end of file
	@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
		1	+$('div#processing_information').html('<%= escape_javascript(render partial: "unstarted_processing") %>');
		2	+repository = new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)
		3	+repository.schedule_poll_state('')
0	\ No newline at end of file	4	\ No newline at end of file
	@@ -255,6 +255,19 @@ describe RepositoriesController do		@@ -255,6 +255,19 @@ describe RepositoriesController do
255	describe 'state' do	255	describe 'state' do
256	let(:repository) { FactoryGirl.build(:repository) }	256	let(:repository) { FactoryGirl.build(:repository) }
257		257
		258	+ context 'with no processing at all' do
		259	+ before :each do
		260	+ repository.expects(:last_processing).returns(nil)
		261	+ Repository.expects(:find).at_least_once.with(repository.id).returns(repository)
		262	+
		263	+ request.env["HTTP_ACCEPT"] = 'application/javascript' # FIXME: there should be a better way to force JS
		264	+ get :state, project_id: project.id.to_s, id: repository.id, last_state: ''
		265	+ end
		266	+
		267	+ it { should respond_with(:success) }
		268	+ it { should render_template(:unprocessed) }
		269	+ end
		270	+
258	context 'with a READY state' do	271	context 'with a READY state' do
259	let(:ready_processing) { FactoryGirl.build(:processing) }	272	let(:ready_processing) { FactoryGirl.build(:processing) }
260		273