Add Hotspot metric result accordion

* Includes translations * Replaces "Metric Results" with "Tree Metric Results" * Creates a feature for hotspot metric results * Handles the view when the processing fails Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>

Add Hotspot metric result accordion
* Includes translations * Replaces "Metric Results" with "Tree Metric Results" * Creates a feature for hotspot metric results * Handles the view when the processing fails Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>
Diego Camarinha · Heitor
1 parent fea6e25b
Showing 9 changed files with 40 additions and 11 deletions Show diff stats
app/views/repositories/_hotspot_metric_results_error.html.erb
app/views/repositories/load_error.js.erb
app/views/repositories/show.html.erb
config/locales/views/repository/en.yml
config/locales/views/repository/pt.yml
features/repository/show/hotspot_metric_results.feature
features/repository/show/independent.feature
features/repository/show/metric_results.feature
features/repository/show/repository_info.feature
@@ -0,0 +1 @@
+<p><%= t('activemodel.errors.repository.no_hotspot_metric_results') %></p>
 $('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
 $('div#module_tree').html('<%= escape_javascript(render partial: "module_tree_error") %>');
-$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results_error") %>');
 \ No newline at end of file
+$('div#hotspot_metric_results').html('<%= escape_javascript(render partial: "hotspot_metric_results_error") %>');
+$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results_error") %>');
@@ -64,6 +64,11 @@
     <div id="module_tree"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
   </div>
  
+  <div id="hotspot-metric-accordion">
+    <h3 class="jquery-ui-accordion"><%= t('repository.show.hotspot_metric_results') %></h3>
+    <div id="hotspot_metric_results"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
+  </div>
+
   <div id="metric-accordion">
     <h3 class="jquery-ui-accordion"><%= t('repository.show.metric_results') %></h3>
     <div id="metric_results"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
@@ -81,6 +86,7 @@
       collapsible: true,
     });
     $("#module-accordion").accordion({active: false})
+    $("#hotspot-metric-accordion").accordion({active: false})
     $("#metric-accordion").accordion({active: false})
   });
 </script>
@@ -25,7 +25,8 @@ en:
         branch: "The branch to be analyzed."
     errors:
       repository:
-        no_metric_results: "Repository process returned with error. There are no metric results."
+        no_metric_results: "Repository process returned with error. There are no tree metric results."
+        no_hotspot_metric_results: "Repository process returned with error. There are no hotspot metric results."
         no_modeule_tree: "Repository process returned with error. There is no module tree."
         unstarted_processing: "This Repository has no processings yet. Please, wait an instant as we start it."
   repository:
@@ -33,6 +34,7 @@ en:
       reprocess: "Reprocess"
       processing_information: "Processing Information"
       modules_tree: "Modules Tree"
-      metric_results: "Metric Results"
+      hotspot_metric_results: "Hotspot Metric Results"
+      metric_results: "Tree Metric Results"
       loading: "Loading data. Please, wait."
       date_processing: "Retrieve the closest processing information from"
@@ -26,6 +26,7 @@ pt:
     errors:
       repository:
         no_metric_results: "O processamento do Repósitório retornou um erro. Não há Resultados de Métrica."
+        no_hotspot_metric_results: "O processamento do Repósitório retornou um erro. Não há Resultados de Métricas de Hotspot."
         no_modeule_tree: "Repository process returned with error. Não há uma Árvore de Módulos."
         unstarted_processing: "Este Repositório ainda não tem Processamentos. Por favor, aguarde um instante enquanto o iniciamos."
   repository:
@@ -33,6 +34,7 @@ pt:
       reprocess: "Reprocessar"
       processing_information: "Informação do Processamento"
       modules_tree: "Árvore de Módulos"
+      hotspot_metric_results: "Resultados de Métricas de Hotspot"
       metric_results: "Resultados de Métrica"
       loading: "Carregando os dados. Por favor, aguarde."
       date_processing: "Obtenha a informação de processamento mais próxima a"
@@ -0,0 +1,17 @@
+Feature: Repository hotspot metric results
+  In order to better understand the results of the analysis
+  As a regular user
+  I should see the hotspot metric results list
+
+  @kalibro_configuration_restart @kalibro_processor_restart @javascript
+  Scenario: Should show the error message when the process fails
+    Given I am a regular user
+    And I am signed in
+    And I have a sample project
+    And I have a sample configuration with native metrics
+    And I have a sample of an invalid repository within the sample project
+    And I start to process that repository
+    And I wait up for a error processing
+    When I visit the repository show page
+    And I click the "Hotspot Metric Results" h3
+    Then I should see "Repository process returned with error. There are no hotspot metric results."
@@ -22,7 +22,7 @@ Feature: Date Select
     And I should see "AGGREGATING time"
     And I should see "CALCULATING time"
     And I should see "INTERPRETING time"
-    When I click the "Metric Results" h3
+    When I click the "Tree Metric Results" h3
     And I click the "Modules Tree" h3
     Then I should see "Metric"
     And I should see "Value"
@@ -35,4 +35,4 @@ Feature: Date Select
     Then I should see "PREPARING"
     When I click the Back link
     And I wait for "5" seconds
-    Then I should be at the Repositories index
 \ No newline at end of file
+    Then I should be at the Repositories index
@@ -16,7 +16,7 @@ Feature: Repository metric results
     And I ask for the module result of the given processing
     And I ask for the metric results of the given module result
     When I visit the repository show page
-    And I click the "Metric Results" h3
+    And I click the "Tree Metric Results" h3
     And I see a sample metric's name
     And I click on the sample metric's name
     Then I should see "Loading data. Please, wait."
@@ -34,7 +34,7 @@ Feature: Repository metric results
     And I ask for the module result of the given processing
     And I ask for the metric results of the given module result
     When I visit the repository show page
-    And I click the "Metric Results" h3
+    And I click the "Tree Metric Results" h3
     And I see a sample metric's name
     Then I should see "Missing range"
  
@@ -48,8 +48,8 @@ Feature: Repository metric results
     And I start to process that repository
     And I wait up for a error processing
     When I visit the repository show page
-    And I click the "Metric Results" h3
-    Then I should see "Repository process returned with error. There are no metric results."
+    And I click the "Tree Metric Results" h3
+    Then I should see "Repository process returned with error. There are no tree metric results."
  
   # TODO: Scenario: Should show the graphic of a given metric
   #         It was getting really difficult to test this because of Poltergeist's timeouts
@@ -40,7 +40,7 @@ Feature: Show Repository
     And I should see "AGGREGATING time"
     And I should see "CALCULATING time"
     And I should see "INTERPRETING time"
-    When I click the "Metric Results" h3
+    When I click the "Tree Metric Results" h3
     And I click the "Modules Tree" h3
     Then I should see "Metric"
     And I should see "Value"
@@ -67,7 +67,7 @@ Feature: Show Repository
     And I should see "Configuration"
     And I should see "State"
     And I should see "Creation Date"
-    When I click the "Metric Results" h3
+    When I click the "Tree Metric Results" h3
     Then I should see "Loading data. Please, wait."
     When I click the "Modules Tree" h3
     Then I should see "Loading data. Please, wait."
...	...	@@ -0,0 +1 @@
	1	+<p><%= t('activemodel.errors.repository.no_hotspot_metric_results') %></p>
...	...
1	1	$('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
2	2	$('div#module_tree').html('<%= escape_javascript(render partial: "module_tree_error") %>');
3		-$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results_error") %>');
4	3	\ No newline at end of file
	4	+$('div#hotspot_metric_results').html('<%= escape_javascript(render partial: "hotspot_metric_results_error") %>');
	5	+$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results_error") %>');
...	...
...	...	@@ -64,6 +64,11 @@
64	64	<div id="module_tree"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
65	65	</div>
66	66
	67	+ <div id="hotspot-metric-accordion">
	68	+ <h3 class="jquery-ui-accordion"><%= t('repository.show.hotspot_metric_results') %></h3>
	69	+ <div id="hotspot_metric_results"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
	70	+ </div>
	71	+
67	72	<div id="metric-accordion">
68	73	<h3 class="jquery-ui-accordion"><%= t('repository.show.metric_results') %></h3>
69	74	<div id="metric_results"><%= image_tag 'loader.gif' %> <%= t('repository.show.loading') %></div>
...	...	@@ -81,6 +86,7 @@
81	86	collapsible: true,
82	87	});
83	88	$("#module-accordion").accordion({active: false})
	89	+ $("#hotspot-metric-accordion").accordion({active: false})
84	90	$("#metric-accordion").accordion({active: false})
85	91	});
86	92	</script>
...	...
...	...	@@ -25,7 +25,8 @@ en:
25	25	branch: "The branch to be analyzed."
26	26	errors:
27	27	repository:
28		- no_metric_results: "Repository process returned with error. There are no metric results."
	28	+ no_metric_results: "Repository process returned with error. There are no tree metric results."
	29	+ no_hotspot_metric_results: "Repository process returned with error. There are no hotspot metric results."
29	30	no_modeule_tree: "Repository process returned with error. There is no module tree."
30	31	unstarted_processing: "This Repository has no processings yet. Please, wait an instant as we start it."
31	32	repository:
...	...	@@ -33,6 +34,7 @@ en:
33	34	reprocess: "Reprocess"
34	35	processing_information: "Processing Information"
35	36	modules_tree: "Modules Tree"
36		- metric_results: "Metric Results"
	37	+ hotspot_metric_results: "Hotspot Metric Results"
	38	+ metric_results: "Tree Metric Results"
37	39	loading: "Loading data. Please, wait."
38	40	date_processing: "Retrieve the closest processing information from"
...	...
...	...	@@ -26,6 +26,7 @@ pt:
26	26	errors:
27	27	repository:
28	28	no_metric_results: "O processamento do Repósitório retornou um erro. Não há Resultados de Métrica."
	29	+ no_hotspot_metric_results: "O processamento do Repósitório retornou um erro. Não há Resultados de Métricas de Hotspot."
29	30	no_modeule_tree: "Repository process returned with error. Não há uma Árvore de Módulos."
30	31	unstarted_processing: "Este Repositório ainda não tem Processamentos. Por favor, aguarde um instante enquanto o iniciamos."
31	32	repository:
...	...	@@ -33,6 +34,7 @@ pt:
33	34	reprocess: "Reprocessar"
34	35	processing_information: "Informação do Processamento"
35	36	modules_tree: "Árvore de Módulos"
	37	+ hotspot_metric_results: "Resultados de Métricas de Hotspot"
36	38	metric_results: "Resultados de Métrica"
37	39	loading: "Carregando os dados. Por favor, aguarde."
38	40	date_processing: "Obtenha a informação de processamento mais próxima a"
...	...
...	...	@@ -0,0 +1,17 @@
	1	+Feature: Repository hotspot metric results
	2	+ In order to better understand the results of the analysis
	3	+ As a regular user
	4	+ I should see the hotspot metric results list
	5	+
	6	+ @kalibro_configuration_restart @kalibro_processor_restart @javascript
	7	+ Scenario: Should show the error message when the process fails
	8	+ Given I am a regular user
	9	+ And I am signed in
	10	+ And I have a sample project
	11	+ And I have a sample configuration with native metrics
	12	+ And I have a sample of an invalid repository within the sample project
	13	+ And I start to process that repository
	14	+ And I wait up for a error processing
	15	+ When I visit the repository show page
	16	+ And I click the "Hotspot Metric Results" h3
	17	+ Then I should see "Repository process returned with error. There are no hotspot metric results."
...	...
...	...	@@ -22,7 +22,7 @@ Feature: Date Select
22	22	And I should see "AGGREGATING time"
23	23	And I should see "CALCULATING time"
24	24	And I should see "INTERPRETING time"
25		- When I click the "Metric Results" h3
	25	+ When I click the "Tree Metric Results" h3
26	26	And I click the "Modules Tree" h3
27	27	Then I should see "Metric"
28	28	And I should see "Value"
...	...	@@ -35,4 +35,4 @@ Feature: Date Select
35	35	Then I should see "PREPARING"
36	36	When I click the Back link
37	37	And I wait for "5" seconds
38		- Then I should be at the Repositories index
39	38	\ No newline at end of file
	39	+ Then I should be at the Repositories index
...	...
...	...	@@ -16,7 +16,7 @@ Feature: Repository metric results
16	16	And I ask for the module result of the given processing
17	17	And I ask for the metric results of the given module result
18	18	When I visit the repository show page
19		- And I click the "Metric Results" h3
	19	+ And I click the "Tree Metric Results" h3
20	20	And I see a sample metric's name
21	21	And I click on the sample metric's name
22	22	Then I should see "Loading data. Please, wait."
...	...	@@ -34,7 +34,7 @@ Feature: Repository metric results
34	34	And I ask for the module result of the given processing
35	35	And I ask for the metric results of the given module result
36	36	When I visit the repository show page
37		- And I click the "Metric Results" h3
	37	+ And I click the "Tree Metric Results" h3
38	38	And I see a sample metric's name
39	39	Then I should see "Missing range"
40	40
...	...	@@ -48,8 +48,8 @@ Feature: Repository metric results
48	48	And I start to process that repository
49	49	And I wait up for a error processing
50	50	When I visit the repository show page
51		- And I click the "Metric Results" h3
52		- Then I should see "Repository process returned with error. There are no metric results."
	51	+ And I click the "Tree Metric Results" h3
	52	+ Then I should see "Repository process returned with error. There are no tree metric results."
53	53
54	54	# TODO: Scenario: Should show the graphic of a given metric
55	55	# It was getting really difficult to test this because of Poltergeist's timeouts
...	...
...	...	@@ -40,7 +40,7 @@ Feature: Show Repository
40	40	And I should see "AGGREGATING time"
41	41	And I should see "CALCULATING time"
42	42	And I should see "INTERPRETING time"
43		- When I click the "Metric Results" h3
	43	+ When I click the "Tree Metric Results" h3
44	44	And I click the "Modules Tree" h3
45	45	Then I should see "Metric"
46	46	And I should see "Value"
...	...	@@ -67,7 +67,7 @@ Feature: Show Repository
67	67	And I should see "Configuration"
68	68	And I should see "State"
69	69	And I should see "Creation Date"
70		- When I click the "Metric Results" h3
	70	+ When I click the "Tree Metric Results" h3
71	71	Then I should see "Loading data. Please, wait."
72	72	When I click the "Modules Tree" h3
73	73	Then I should see "Loading data. Please, wait."
...	...