[Colab] Implement callbacks and initial tests for Omniauth Remote User

Signed-off-by: Heitor Reis Ribeiro <marcheing@gmail.com>

[Colab] Implement callbacks and initial tests for Omniauth Remote User
Signed-off-by: Heitor Reis Ribeiro <marcheing@gmail.com>
Daniel · Eduardo Silva Araújo
1 parent ffb9d386
Showing 8 changed files with 64 additions and 7 deletions Show diff stats
app/controllers/users/omniauth_callbacks_controller.rb
app/views/devise/shared/_links.erb
config/initializers/devise.rb
config/routes.rb
features/step_definitions/user_steps.rb
features/support/hooks.rb
features/users/omniauth.feature
spec/factories/users.rb
@@ -0,0 +1,16 @@
+module Users
+  class OmniauthCallbacksController < Devise::OmniauthCallbacksController
+    def all
+      auth = request.env["omniauth.auth"]
+      user = User.find_or_create_by(email: auth.info.email, name: auth.info.name, provider: auth.provider, uid: auth.uid)
+
+      if user.valid?
+        sign_in_and_redirect user
+      else
+        raise "Fuck you: #{user.errors.full_messages}"
+      end
+    end
+
+    alias_method :RemoteUser, :all
+  end
+end
 \ No newline at end of file
@@ -20,6 +20,6 @@
  
 <%- if devise_mapping.omniauthable? %>
   <%- resource_class.omniauth_providers.each do |provider| %>
-  <%= link_to t('.sign_in_with_provider', :provider => provider.to_s.titleize, :default => "Sign in with #{provider.to_s.titleize}"), omniauth_authorize_path(resource_name, provider), class: 'btn btn-info' %>
+  <%= link_to t('.sign_in_with_provider', :provider => provider.to_s.titleize, :default => "Sign in with #{provider.to_s.titleize}"), user_omniauth_authorize_path(provider), class: 'btn btn-info' %>
   <% end -%>
 <% end -%>
 \ No newline at end of file
@@ -231,6 +231,7 @@ Devise.setup do |config|
   # Add a new OmniAuth provider. Check the wiki for more information on setting
   # up on your models and hooks.
   # config.omniauth :github, 'APP_ID', 'APP_SECRET', :scope => 'user,public_repo'
+  config.omniauth :RemoteUser
  
   # ==> Warden configuration
   # If you want to use other strategies, that are not supported by Devise, or
@@ -51,7 +51,7 @@ Rails.application.routes.draw do
  
  
   # See comment above for devise_for
-  devise_for :users, only: :omniauth_callbacks
+  devise_for :users, only: :omniauth_callbacks, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" }
   # The priority is based upon order of creation: first created -> highest priority.
   # See how all your routes lay out with "rake routes".
  
@@ -31,3 +31,25 @@ When(/^I click the &quot;(.*?)&quot; icon$/) do |icon|
   find('#' + icon).click # the hashtag symbol is necessary to find the id of a HTML element
   sleep(1) #This sleep is essential to make the popup visible when we take a picture of the page
 end
+
+Given(/^I am logged in as a Colab user$/) do
+  colab_user = FactoryGirl.build(:colab_user)
+  first_name, last_name = colab_user.name.partition(' ')
+
+  set_header('HTTP_REMOTE_USER', colab_user.uid)
+  set_header('HTTP_REMOTE_USER_DATA', {
+    'nickname': colab_user.uid,
+    'name': colab_user.name,
+    'firstname': first_name,
+    'lastname': last_name,
+    'email': colab_user.email
+  }.to_json)
+end
+
+Then(/^I should be at the Home page$/) do
+  expect(current_path).to be("/")
+end
+
+Then(/^I should be logged in$/) do
+  expect(page).to have_no_link("Sign In")
+end
 \ No newline at end of file
+require_relative 'header'
+
 After do |scenario|
   # Do something after each scenario.
   # The +scenario+ argument is optional, but
@@ -8,11 +10,7 @@ end
  
 # Run all acceptance tests on the default language
 Before do |scenario|
-  if defined?(page) && ! page.driver.nil?
-    header_method = [:add_header, :header].find(&page.driver.method(:respond_to?))
-    page.driver.send(header_method, 'Accept-Language', I18n.default_locale) if header_method
-  end
-
+  set_header('Accept-Language', I18n.default_locale)
   I18n.locale = I18n.default_locale
 end
  
@@ -0,0 +1,12 @@
+Feature: Omniauth authentication
+  In order to sign in more easily
+  As a regular user
+  I want to authenticate with an external provider
+
+  Scenario: through Colab
+    Given I am logged in as a Colab user
+    And I am at the homepage
+    And I click the Sign In link
+    When I click the Sign in with Remote User link
+    Then I should be at the Home page
+    And I should be logged in
 \ No newline at end of file
@@ -16,4 +16,12 @@ FactoryGirl.define do
       sequence(:id, 1)
     end
   end
+
+  factory :colab_user, class: User do
+    id 2
+    name "Eric Clapton"
+    email "eric@clapton.com"
+    provider "colab"
+    uid "eric_clapton"
+  end
 end
...	...	@@ -0,0 +1,16 @@
	1	+module Users
	2	+ class OmniauthCallbacksController < Devise::OmniauthCallbacksController
	3	+ def all
	4	+ auth = request.env["omniauth.auth"]
	5	+ user = User.find_or_create_by(email: auth.info.email, name: auth.info.name, provider: auth.provider, uid: auth.uid)
	6	+
	7	+ if user.valid?
	8	+ sign_in_and_redirect user
	9	+ else
	10	+ raise "Fuck you: #{user.errors.full_messages}"
	11	+ end
	12	+ end
	13	+
	14	+ alias_method :RemoteUser, :all
	15	+ end
	16	+end
0	17	\ No newline at end of file
...	...
...	...	@@ -20,6 +20,6 @@
20	20
21	21	<%- if devise_mapping.omniauthable? %>
22	22	<%- resource_class.omniauth_providers.each do \|provider\| %>
23		- <%= link_to t('.sign_in_with_provider', :provider => provider.to_s.titleize, :default => "Sign in with #{provider.to_s.titleize}"), omniauth_authorize_path(resource_name, provider), class: 'btn btn-info' %>
	23	+ <%= link_to t('.sign_in_with_provider', :provider => provider.to_s.titleize, :default => "Sign in with #{provider.to_s.titleize}"), user_omniauth_authorize_path(provider), class: 'btn btn-info' %>
24	24	<% end -%>
25	25	<% end -%>
26	26	\ No newline at end of file
...	...
...	...	@@ -231,6 +231,7 @@ Devise.setup do \|config\|
231	231	# Add a new OmniAuth provider. Check the wiki for more information on setting
232	232	# up on your models and hooks.
233	233	# config.omniauth :github, 'APP_ID', 'APP_SECRET', :scope => 'user,public_repo'
	234	+ config.omniauth :RemoteUser
234	235
235	236	# ==> Warden configuration
236	237	# If you want to use other strategies, that are not supported by Devise, or
...	...
...	...	@@ -51,7 +51,7 @@ Rails.application.routes.draw do
51	51
52	52
53	53	# See comment above for devise_for
54		- devise_for :users, only: :omniauth_callbacks
	54	+ devise_for :users, only: :omniauth_callbacks, :controllers => { :omniauth_callbacks => "users/omniauth_callbacks" }
55	55	# The priority is based upon order of creation: first created -> highest priority.
56	56	# See how all your routes lay out with "rake routes".
57	57
...	...
...	...	@@ -31,3 +31,25 @@ When(/^I click the "(.*?)" icon$/) do \|icon\|
31	31	find('#' + icon).click # the hashtag symbol is necessary to find the id of a HTML element
32	32	sleep(1) #This sleep is essential to make the popup visible when we take a picture of the page
33	33	end
	34	+
	35	+Given(/^I am logged in as a Colab user$/) do
	36	+ colab_user = FactoryGirl.build(:colab_user)
	37	+ first_name, last_name = colab_user.name.partition(' ')
	38	+
	39	+ set_header('HTTP_REMOTE_USER', colab_user.uid)
	40	+ set_header('HTTP_REMOTE_USER_DATA', {
	41	+ 'nickname': colab_user.uid,
	42	+ 'name': colab_user.name,
	43	+ 'firstname': first_name,
	44	+ 'lastname': last_name,
	45	+ 'email': colab_user.email
	46	+ }.to_json)
	47	+end
	48	+
	49	+Then(/^I should be at the Home page$/) do
	50	+ expect(current_path).to be("/")
	51	+end
	52	+
	53	+Then(/^I should be logged in$/) do
	54	+ expect(page).to have_no_link("Sign In")
	55	+end
34	56	\ No newline at end of file
...	...
	1	+require_relative 'header'
	2	+
1	3	After do \|scenario\|
2	4	# Do something after each scenario.
3	5	# The +scenario+ argument is optional, but
...	...	@@ -8,11 +10,7 @@ end
8	10
9	11	# Run all acceptance tests on the default language
10	12	Before do \|scenario\|
11		- if defined?(page) && ! page.driver.nil?
12		- header_method = [:add_header, :header].find(&page.driver.method(:respond_to?))
13		- page.driver.send(header_method, 'Accept-Language', I18n.default_locale) if header_method
14		- end
15		-
	13	+ set_header('Accept-Language', I18n.default_locale)
16	14	I18n.locale = I18n.default_locale
17	15	end
18	16
...	...
...	...	@@ -0,0 +1,12 @@
	1	+Feature: Omniauth authentication
	2	+ In order to sign in more easily
	3	+ As a regular user
	4	+ I want to authenticate with an external provider
	5	+
	6	+ Scenario: through Colab
	7	+ Given I am logged in as a Colab user
	8	+ And I am at the homepage
	9	+ And I click the Sign In link
	10	+ When I click the Sign in with Remote User link
	11	+ Then I should be at the Home page
	12	+ And I should be logged in
0	13	\ No newline at end of file
...	...
...	...	@@ -16,4 +16,12 @@ FactoryGirl.define do
16	16	sequence(:id, 1)
17	17	end
18	18	end
	19	+
	20	+ factory :colab_user, class: User do
	21	+ id 2
	22	+ name "Eric Clapton"
	23	+ email "eric@clapton.com"
	24	+ provider "colab"
	25	+ uid "eric_clapton"
	26	+ end
19	27	end
...	...