Compound metric configuration creation.

Diego Camarinha · Rafael Manzo
1 parent abf3503c
Showing 5 changed files with 125 additions and 11 deletions Show diff stats
app/controllers/compound_metric_configurations_controller.rb
app/views/compound_metric_configurations/new.html.erb
features/compound_metric_configuration/create.feature
features/step_definitions/compound_metric_configuration_steps.rb
spec/controllers/compound_metric_configurations_controller_spec.rb
@@ -2,12 +2,46 @@ include OwnershipAuthentication
  
 class CompoundMetricConfigurationsController < ApplicationController
   before_action :authenticate_user!, except: [:index]
-  before_action :mezuro_configuration_owner?, only: [:new]
+  before_action :mezuro_configuration_owner?, only: [:new, :create]
  
   # GET mezuro_configurations/1/compound_metric_configurations/new
   def new
     @compound_metric_configuration = MetricConfiguration.new
     @compound_metric_configuration.configuration_id = params[:mezuro_configuration_id].to_i
+    @metric_configurations = MetricConfiguration.metric_configurations_of(params[:mezuro_configuration_id].to_i)
+  end
+
+  def create
+    @compound_metric_configuration = MetricConfiguration.new(metric_configuration_params)
+    @compound_metric_configuration.configuration_id = params[:mezuro_configuration_id].to_i
+    @compound_metric_configuration.metric.compound = true
+    respond_to do |format|
+      create_and_redir(format)
+    end
+  end
+
+  private
+
+  # Never trust parameters from the scary internet, only allow the white list through.
+  def metric_configuration_params
+    params[:metric_configuration]
+  end
+
+  # Duplicated code on create and update actions extracted here
+  def failed_action(format, destiny_action)
+    @mezuro_configuration_id = params[:mezuro_configuration_id]
+
+    format.html { render action: destiny_action }
+    format.json { render json: @compound_metric_configuration.errors, status: :unprocessable_entity }
+  end
+
+  #Code extracted from create action
+  def create_and_redir(format)
+    if @compound_metric_configuration.save
+      format.html { redirect_to mezuro_configuration_path(@compound_metric_configuration.configuration_id), notice: 'Compound Metric Configuration was successfully created.' }
+    else
+      failed_action(format, 'new')
+    end
   end
  
 end
@@ -2,8 +2,38 @@
   <h1>New Compound Metric Configuration</h1>
 </div>
  
+<div id="created-metrics-accordion">
+    <h3> Created Metrics </h3>
+    <div>
+    <table class="table table-hover">
+      <thead>
+        <th>Name</th>
+        <th>Code</th>
+      </thead>
+      <tbody>
+        <% @metric_configurations.each do |metric_configuration| %>
+          <tr>
+            <td><%= metric_configuration.metric.name %></td>
+            <td><%= metric_configuration.code %></td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+    </div>
+</div>
+
 <br>
  
-<%= form_for(@compound_metric_configuration, :url => mezuro_configuration_metric_configurations_path(@compound_metric_configuration.configuration_id)) do |f| %>
+<%= form_for(@compound_metric_configuration, :url => mezuro_configuration_compound_metric_configurations_path(@compound_metric_configuration.configuration_id)) do |f| %>
   <%= render partial: 'form', locals: {f: f} %>
 <% end %>
+
+<script type="text/javascript">
+  //Loads the accordion
+  $(function() {
+    $( "#created-metrics-accordion" ).accordion({
+      heightStyle: "content",
+      collapsible: true,
+    });
+  });
+</script>
@@ -3,25 +3,28 @@ Feature: Compound Metric Configuration Creation
   As a regular user
   I should be able to create compound metric configurations
  
-  #Missing create action and native metrics name and code
-  @kalibro_restart @wip
+  @kalibro_restart @javascript
     Scenario: compound metric configuration creation
     Given I am a regular user
     And I am signed in
     And I own a sample configuration
     And I have a reading group named "Scholar"
+    And I have a sample metric configuration within the given mezuro configuration
     And I am at the Sample Configuration page
     And I click the Add Metric link
     And I click the Compound Metric link
-    And I fill the Name field with "My Compound Metric"    
+    When I click the "Created Metrics" h3
+    Then I see the sample metric configuration name
+    And I see the sample metric configuration code
+    When I fill the Name field with "My Compound Metric"
     And I fill the Description field with "Some description"
-    And I fill the Code field with "My Code"
+    And I fill the Code field with "mcm"
     And I fill the Script field with "8*8;"
-    And I fill the Weight field with "2"
+    And I fill the Weight field with "8"
     And I set the select field "Scope" as "Class"
     And I set the select field "Aggregation Form" as "Average"
     And I set the select field "Reading Group" as "Scholar"
-    When I press the Save button
-    #Then I should see "My Code"
-    #Then I should see "Total Lines of Code"
-    #Then I should see "2"
+    And I press the Save button
+    Then I should see "My Compound Metric"
+    And I should see "mcm"
+    And I should see "8"
@@ -0,0 +1,8 @@
+Given(/^I see the sample metric configuration name$/) do
+  page.should have_content(@metric_configuration.metric.name)
+end
+
+Given(/^I see the sample metric configuration code$/) do
+  page.should have_content(@metric_configuration.code)
+end
+
@@ -9,8 +9,10 @@ describe CompoundMetricConfigurationsController do
     end
  
     context 'when the current user owns the mezuro configuration' do
+      let!(:metric_configuration) { FactoryGirl.build(:metric_configuration) }
       before :each do
         subject.expects(:mezuro_configuration_owner?).returns true
+        MetricConfiguration.expects(:metric_configurations_of).with(mezuro_configuration.id).returns([metric_configuration])
         get :new, mezuro_configuration_id: mezuro_configuration.id
       end
  
@@ -27,4 +29,41 @@ describe CompoundMetricConfigurationsController do
       it { should respond_with(:redirect) }
     end
   end
+
+  describe 'create' do
+    let!(:metric_configuration_params) { Hash[FactoryGirl.attributes_for(:metric_configuration).map { |k,v| [k.to_s, v.to_s] }] }  #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with symbols and integers
+    let!(:metric_params) { Hash[FactoryGirl.attributes_for(:metric).map { |k,v| [k.to_s, v.to_s] }] }  #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with symbols and integers
+    let(:mezuro_configuration) { FactoryGirl.build(:mezuro_configuration) }
+
+    before do
+      sign_in FactoryGirl.create(:user)
+      metric_configuration_params["metric"] = metric_params
+    end
+
+    context 'when the current user owns the reading group' do
+      before :each do
+        subject.expects(:mezuro_configuration_owner?).returns true
+      end
+
+      context 'with valid fields' do
+        before :each do
+          MetricConfiguration.any_instance.expects(:save).returns(true)
+
+          post :create, mezuro_configuration_id: mezuro_configuration.id, metric_configuration: metric_configuration_params
+        end
+
+        it { should respond_with(:redirect) }
+      end
+
+      context 'with invalid fields' do
+        before :each do
+          MetricConfiguration.any_instance.expects(:save).returns(false)
+
+          post :create, mezuro_configuration_id: mezuro_configuration.id, metric_configuration: metric_configuration_params
+        end
+
+        it { should render_template(:new) }
+      end
+    end
+  end
 end
...	...	@@ -2,12 +2,46 @@ include OwnershipAuthentication
2	2
3	3	class CompoundMetricConfigurationsController < ApplicationController
4	4	before_action :authenticate_user!, except: [:index]
5		- before_action :mezuro_configuration_owner?, only: [:new]
	5	+ before_action :mezuro_configuration_owner?, only: [:new, :create]
6	6
7	7	# GET mezuro_configurations/1/compound_metric_configurations/new
8	8	def new
9	9	@compound_metric_configuration = MetricConfiguration.new
10	10	@compound_metric_configuration.configuration_id = params[:mezuro_configuration_id].to_i
	11	+ @metric_configurations = MetricConfiguration.metric_configurations_of(params[:mezuro_configuration_id].to_i)
	12	+ end
	13	+
	14	+ def create
	15	+ @compound_metric_configuration = MetricConfiguration.new(metric_configuration_params)
	16	+ @compound_metric_configuration.configuration_id = params[:mezuro_configuration_id].to_i
	17	+ @compound_metric_configuration.metric.compound = true
	18	+ respond_to do \|format\|
	19	+ create_and_redir(format)
	20	+ end
	21	+ end
	22	+
	23	+ private
	24	+
	25	+ # Never trust parameters from the scary internet, only allow the white list through.
	26	+ def metric_configuration_params
	27	+ params[:metric_configuration]
	28	+ end
	29	+
	30	+ # Duplicated code on create and update actions extracted here
	31	+ def failed_action(format, destiny_action)
	32	+ @mezuro_configuration_id = params[:mezuro_configuration_id]
	33	+
	34	+ format.html { render action: destiny_action }
	35	+ format.json { render json: @compound_metric_configuration.errors, status: :unprocessable_entity }
	36	+ end
	37	+
	38	+ #Code extracted from create action
	39	+ def create_and_redir(format)
	40	+ if @compound_metric_configuration.save
	41	+ format.html { redirect_to mezuro_configuration_path(@compound_metric_configuration.configuration_id), notice: 'Compound Metric Configuration was successfully created.' }
	42	+ else
	43	+ failed_action(format, 'new')
	44	+ end
11	45	end
12	46
13	47	end
...	...
...	...	@@ -2,8 +2,38 @@
2	2	<h1>New Compound Metric Configuration</h1>
3	3	</div>
4	4
	5	+<div id="created-metrics-accordion">
	6	+ <h3> Created Metrics </h3>
	7	+ <div>
	8	+ <table class="table table-hover">
	9	+ <thead>
	10	+ <th>Name</th>
	11	+ <th>Code</th>
	12	+ </thead>
	13	+ <tbody>
	14	+ <% @metric_configurations.each do \|metric_configuration\| %>
	15	+ <tr>
	16	+ <td><%= metric_configuration.metric.name %></td>
	17	+ <td><%= metric_configuration.code %></td>
	18	+ </tr>
	19	+ <% end %>
	20	+ </tbody>
	21	+ </table>
	22	+ </div>
	23	+</div>
	24	+
5	25	<br>
6	26
7		-<%= form_for(@compound_metric_configuration, :url => mezuro_configuration_metric_configurations_path(@compound_metric_configuration.configuration_id)) do \|f\| %>
	27	+<%= form_for(@compound_metric_configuration, :url => mezuro_configuration_compound_metric_configurations_path(@compound_metric_configuration.configuration_id)) do \|f\| %>
8	28	<%= render partial: 'form', locals: {f: f} %>
9	29	<% end %>
	30	+
	31	+<script type="text/javascript">
	32	+ //Loads the accordion
	33	+ $(function() {
	34	+ $( "#created-metrics-accordion" ).accordion({
	35	+ heightStyle: "content",
	36	+ collapsible: true,
	37	+ });
	38	+ });
	39	+</script>
...	...
...	...	@@ -3,25 +3,28 @@ Feature: Compound Metric Configuration Creation
3	3	As a regular user
4	4	I should be able to create compound metric configurations
5	5
6		- #Missing create action and native metrics name and code
7		- @kalibro_restart @wip
	6	+ @kalibro_restart @javascript
8	7	Scenario: compound metric configuration creation
9	8	Given I am a regular user
10	9	And I am signed in
11	10	And I own a sample configuration
12	11	And I have a reading group named "Scholar"
	12	+ And I have a sample metric configuration within the given mezuro configuration
13	13	And I am at the Sample Configuration page
14	14	And I click the Add Metric link
15	15	And I click the Compound Metric link
16		- And I fill the Name field with "My Compound Metric"
	16	+ When I click the "Created Metrics" h3
	17	+ Then I see the sample metric configuration name
	18	+ And I see the sample metric configuration code
	19	+ When I fill the Name field with "My Compound Metric"
17	20	And I fill the Description field with "Some description"
18		- And I fill the Code field with "My Code"
	21	+ And I fill the Code field with "mcm"
19	22	And I fill the Script field with "8*8;"
20		- And I fill the Weight field with "2"
	23	+ And I fill the Weight field with "8"
21	24	And I set the select field "Scope" as "Class"
22	25	And I set the select field "Aggregation Form" as "Average"
23	26	And I set the select field "Reading Group" as "Scholar"
24		- When I press the Save button
25		- #Then I should see "My Code"
26		- #Then I should see "Total Lines of Code"
27		- #Then I should see "2"
	27	+ And I press the Save button
	28	+ Then I should see "My Compound Metric"
	29	+ And I should see "mcm"
	30	+ And I should see "8"
...	...
...	...	@@ -0,0 +1,8 @@
	1	+Given(/^I see the sample metric configuration name$/) do
	2	+ page.should have_content(@metric_configuration.metric.name)
	3	+end
	4	+
	5	+Given(/^I see the sample metric configuration code$/) do
	6	+ page.should have_content(@metric_configuration.code)
	7	+end
	8	+
...	...
...	...	@@ -9,8 +9,10 @@ describe CompoundMetricConfigurationsController do
9	9	end
10	10
11	11	context 'when the current user owns the mezuro configuration' do
	12	+ let!(:metric_configuration) { FactoryGirl.build(:metric_configuration) }
12	13	before :each do
13	14	subject.expects(:mezuro_configuration_owner?).returns true
	15	+ MetricConfiguration.expects(:metric_configurations_of).with(mezuro_configuration.id).returns([metric_configuration])
14	16	get :new, mezuro_configuration_id: mezuro_configuration.id
15	17	end
16	18
...	...	@@ -27,4 +29,41 @@ describe CompoundMetricConfigurationsController do
27	29	it { should respond_with(:redirect) }
28	30	end
29	31	end
	32	+
	33	+ describe 'create' do
	34	+ let!(:metric_configuration_params) { Hash[FactoryGirl.attributes_for(:metric_configuration).map { \|k,v\| [k.to_s, v.to_s] }] } #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with symbols and integers
	35	+ let!(:metric_params) { Hash[FactoryGirl.attributes_for(:metric).map { \|k,v\| [k.to_s, v.to_s] }] } #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with symbols and integers
	36	+ let(:mezuro_configuration) { FactoryGirl.build(:mezuro_configuration) }
	37	+
	38	+ before do
	39	+ sign_in FactoryGirl.create(:user)
	40	+ metric_configuration_params["metric"] = metric_params
	41	+ end
	42	+
	43	+ context 'when the current user owns the reading group' do
	44	+ before :each do
	45	+ subject.expects(:mezuro_configuration_owner?).returns true
	46	+ end
	47	+
	48	+ context 'with valid fields' do
	49	+ before :each do
	50	+ MetricConfiguration.any_instance.expects(:save).returns(true)
	51	+
	52	+ post :create, mezuro_configuration_id: mezuro_configuration.id, metric_configuration: metric_configuration_params
	53	+ end
	54	+
	55	+ it { should respond_with(:redirect) }
	56	+ end
	57	+
	58	+ context 'with invalid fields' do
	59	+ before :each do
	60	+ MetricConfiguration.any_instance.expects(:save).returns(false)
	61	+
	62	+ post :create, mezuro_configuration_id: mezuro_configuration.id, metric_configuration: metric_configuration_params
	63	+ end
	64	+
	65	+ it { should render_template(:new) }
	66	+ end
	67	+ end
	68	+ end
30	69	end
...	...