Finished Mezuro Range integration

Heitor · Rafael Manzo
1 parent e4998ac7
Showing 5 changed files with 3 additions and 110 deletions Show diff stats
app/models/mezuro_range.rb
spec/models/mezuro_range_spec.rb
spec/models/validators/beginning_uniqueness_validator_spec.rb
spec/models/validators/greater_than_beginning_validator_spec.rb
spec/models/validators/kalibro_uniqueness_validator_spec.rb
-require "validators/beginning_uniqueness_validator.rb"
-require "validators/greater_than_beginning_validator.rb"
-require "validators/range_overlapping_validator.rb"
-
 class MezuroRange < KalibroGatekeeperClient::Entities::Range
-  include KalibroRecord
-
-  attr_accessor :beginning, :end, :reading_id, :mezuro_configuration_id, :comments
-
-  validates :beginning, presence: true, beginning_uniqueness: true
-  validates :beginning, numericality: true, if: :non_infinite_beginning?
-  validates :end, presence: true
-  validates :end, numericality: true, if: :non_infinite_end?
-  validates :end, greater_than_beginning: true
-  validates :reading_id, presence: true
-  validates_with RangeOverlappingValidator
-
-  private
-
-  def non_infinite_end?
-    !(self.end == '-INF' || self.end == 'INF')
-  end
-
-  def non_infinite_beginning?
-    val = !(self.beginning == '-INF' || self.beginning == 'INF')
-  end
 end
@@ -1,85 +0,0 @@
-require 'rails_helper'
-
-describe MezuroRange, :type => :model do
-  pending 'waiting for kalibro configurations integration' do
-    subject { FactoryGirl.build(:mezuro_range, { metric_configuration_id: 42 }) }
-    describe 'validations' do
-      context 'active model validations' do
-        before :each do
-          BeginningUniquenessValidator.any_instance.stubs(:validate_each)
-          GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
-          RangeOverlappingValidator.any_instance.stubs(:validate)
-        end
-
-        it { is_expected.to validate_presence_of(:beginning) }
-        it { is_expected.to validate_presence_of(:end) }
-        it { is_expected.to validate_presence_of(:reading_id) }
-
-        context 'beginning and end numericality' do
-          it { is_expected.to validate_numericality_of(:beginning) }
-          it { is_expected.to validate_numericality_of(:end) }
-
-          it 'should allow -INF and INF to beginning' do
-            subject.beginning = '-INF'
-            subject.save
-
-            expect(subject.errors.messages).to be_empty
-
-            subject.beginning = 'INF'
-            subject.save
-
-            expect(subject.errors.messages).to be_empty
-          end
-
-          it 'should allow -INF and INF to end' do
-            subject.end = '-INF'
-            subject.save
-
-            expect(subject.errors.messages).to be_empty
-
-            subject.end = 'INF'
-            subject.save
-
-            expect(subject.errors.messages).to be_empty
-          end
-        end
-      end
-
-      context 'beginning validations' do
-        before :each do
-          GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
-          RangeOverlappingValidator.any_instance.stubs(:validate)
-        end
-
-        it 'should validate uniqueness' do
-          BeginningUniquenessValidator.any_instance.expects(:validate_each).with(subject, :beginning, subject.beginning)
-          subject.save
-        end
-      end
-
-      context 'end validations' do
-        before :each do
-          BeginningUniquenessValidator.any_instance.stubs(:validate_each)
-          RangeOverlappingValidator.any_instance.stubs(:validate)
-        end
-
-        it 'should validate that end is greater than beginning' do
-          GreaterThanBeginningValidator.any_instance.expects(:validate_each).with(subject, :end, subject.end)
-          subject.save
-        end
-      end
-
-      context 'overlapping validations' do
-        before :each do
-          GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
-          BeginningUniquenessValidator.any_instance.stubs(:validate_each)
-        end
-
-        it 'is expected to validate if this range overlaps the existing ones' do
-          RangeOverlappingValidator.any_instance.expects(:validate).with(subject)
-          subject.save
-        end
-      end
-    end
-  end
-end
 require 'rails_helper'
+require 'validators/beginning_uniqueness_validator'
 describe BeginningUniquenessValidator, :type => :model do
   pending 'waiting for kalibro configurations integration' do
 require 'rails_helper'
+require 'validators/greater_than_beginning_validator'
 describe GreaterThanBeginningValidator, :type => :model do
   pending 'waiting for kalibro configurations integration' do
 require 'rails_helper'
+require 'validators/range_overlapping_validator'
 describe KalibroUniquenessValidator, :type => :model do
   pending 'waiting for kalibro configurations integration' do
1	-require "validators/beginning_uniqueness_validator.rb"
2	-require "validators/greater_than_beginning_validator.rb"
3	-require "validators/range_overlapping_validator.rb"
4	-
5	class MezuroRange < KalibroGatekeeperClient::Entities::Range	1	class MezuroRange < KalibroGatekeeperClient::Entities::Range
6	- include KalibroRecord
7	-
8	- attr_accessor :beginning, :end, :reading_id, :mezuro_configuration_id, :comments
9	-
10	- validates :beginning, presence: true, beginning_uniqueness: true
11	- validates :beginning, numericality: true, if: :non_infinite_beginning?
12	- validates :end, presence: true
13	- validates :end, numericality: true, if: :non_infinite_end?
14	- validates :end, greater_than_beginning: true
15	- validates :reading_id, presence: true
16	- validates_with RangeOverlappingValidator
17	-
18	- private
19	-
20	- def non_infinite_end?
21	- !(self.end == '-INF' \|\| self.end == 'INF')
22	- end
23	-
24	- def non_infinite_beginning?
25	- val = !(self.beginning == '-INF' \|\| self.beginning == 'INF')
26	- end
27	end	2	end
	@@ -1,85 +0,0 @@	@@ -1,85 +0,0 @@
1	-require 'rails_helper'
2	-
3	-describe MezuroRange, :type => :model do
4	- pending 'waiting for kalibro configurations integration' do
5	- subject { FactoryGirl.build(:mezuro_range, { metric_configuration_id: 42 }) }
6	- describe 'validations' do
7	- context 'active model validations' do
8	- before :each do
9	- BeginningUniquenessValidator.any_instance.stubs(:validate_each)
10	- GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
11	- RangeOverlappingValidator.any_instance.stubs(:validate)
12	- end
13	-
14	- it { is_expected.to validate_presence_of(:beginning) }
15	- it { is_expected.to validate_presence_of(:end) }
16	- it { is_expected.to validate_presence_of(:reading_id) }
17	-
18	- context 'beginning and end numericality' do
19	- it { is_expected.to validate_numericality_of(:beginning) }
20	- it { is_expected.to validate_numericality_of(:end) }
21	-
22	- it 'should allow -INF and INF to beginning' do
23	- subject.beginning = '-INF'
24	- subject.save
25	-
26	- expect(subject.errors.messages).to be_empty
27	-
28	- subject.beginning = 'INF'
29	- subject.save
30	-
31	- expect(subject.errors.messages).to be_empty
32	- end
33	-
34	- it 'should allow -INF and INF to end' do
35	- subject.end = '-INF'
36	- subject.save
37	-
38	- expect(subject.errors.messages).to be_empty
39	-
40	- subject.end = 'INF'
41	- subject.save
42	-
43	- expect(subject.errors.messages).to be_empty
44	- end
45	- end
46	- end
47	-
48	- context 'beginning validations' do
49	- before :each do
50	- GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
51	- RangeOverlappingValidator.any_instance.stubs(:validate)
52	- end
53	-
54	- it 'should validate uniqueness' do
55	- BeginningUniquenessValidator.any_instance.expects(:validate_each).with(subject, :beginning, subject.beginning)
56	- subject.save
57	- end
58	- end
59	-
60	- context 'end validations' do
61	- before :each do
62	- BeginningUniquenessValidator.any_instance.stubs(:validate_each)
63	- RangeOverlappingValidator.any_instance.stubs(:validate)
64	- end
65	-
66	- it 'should validate that end is greater than beginning' do
67	- GreaterThanBeginningValidator.any_instance.expects(:validate_each).with(subject, :end, subject.end)
68	- subject.save
69	- end
70	- end
71	-
72	- context 'overlapping validations' do
73	- before :each do
74	- GreaterThanBeginningValidator.any_instance.stubs(:validate_each)
75	- BeginningUniquenessValidator.any_instance.stubs(:validate_each)
76	- end
77	-
78	- it 'is expected to validate if this range overlaps the existing ones' do
79	- RangeOverlappingValidator.any_instance.expects(:validate).with(subject)
80	- subject.save
81	- end
82	- end
83	- end
84	- end
85	-end
1	require 'rails_helper'	1	require 'rails_helper'
		2	+require 'validators/beginning_uniqueness_validator'
2		3
3	describe BeginningUniquenessValidator, :type => :model do	4	describe BeginningUniquenessValidator, :type => :model do
4	pending 'waiting for kalibro configurations integration' do	5	pending 'waiting for kalibro configurations integration' do
1	require 'rails_helper'	1	require 'rails_helper'
		2	+require 'validators/greater_than_beginning_validator'
2		3
3	describe GreaterThanBeginningValidator, :type => :model do	4	describe GreaterThanBeginningValidator, :type => :model do
4	pending 'waiting for kalibro configurations integration' do	5	pending 'waiting for kalibro configurations integration' do
1	require 'rails_helper'	1	require 'rails_helper'
		2	+require 'validators/range_overlapping_validator'
2		3
3	describe KalibroUniquenessValidator, :type => :model do	4	describe KalibroUniquenessValidator, :type => :model do
4	pending 'waiting for kalibro configurations integration' do	5	pending 'waiting for kalibro configurations integration' do