Merge pull request #227 from mezuro/tutorials_not_found

Handle invalid tutorial names

Merge pull request #227 from mezuro/tutorials_not_found
Handle invalid tutorial names
Diego Camarinha
2 parents 1c82f9f1 9bc3ce85
Showing 2 changed files with 19 additions and 5 deletions Show diff stats
app/controllers/tutorials_controller.rb
spec/controllers/tutorials_controller_spec.rb
 class TutorialsController < ApplicationController
+  rescue_from ActionView::MissingTemplate, with: :not_found
+
   def view
     render params[:name]
   end
@@ -2,13 +2,25 @@ require &#39;rails_helper&#39;
 describe TutorialsController do
   describe 'view' do
-    let!(:name) { "analyzing" }
+    context 'with a valid name' do
+      let!(:name) { "analyzing" }
-    before :each do
-      get :view, name: name
+      before :each do
+        get :view, name: name
+      end
+
+      it { is_expected.to render_template(name) }
+      it { is_expected.to respond_with(:success) }
     end
-    it { is_expected.to render_template(name) }
-    it { is_expected.to respond_with(:success) }
+    context 'with a invalid name' do
+      let!(:name) { "invalid_name" }
+
+      before :each do
+        get :view, name: name
+      end
+
+      it { is_expected.to respond_with(:not_found) }
+    end
   end
 end
1	class TutorialsController < ApplicationController	1	class TutorialsController < ApplicationController
		2	+ rescue_from ActionView::MissingTemplate, with: :not_found
		3	+
2	def view	4	def view
3	render params[:name]	5	render params[:name]
4	end	6	end
	@@ -2,13 +2,25 @@ require 'rails_helper'		@@ -2,13 +2,25 @@ require 'rails_helper'
2		2
3	describe TutorialsController do	3	describe TutorialsController do
4	describe 'view' do	4	describe 'view' do
5	- let!(:name) { "analyzing" }	5	+ context 'with a valid name' do
		6	+ let!(:name) { "analyzing" }
6		7
7	- before :each do
8	- get :view, name: name	8	+ before :each do
		9	+ get :view, name: name
		10	+ end
		11	+
		12	+ it { is_expected.to render_template(name) }
		13	+ it { is_expected.to respond_with(:success) }
9	end	14	end
10		15
11	- it { is_expected.to render_template(name) }
12	- it { is_expected.to respond_with(:success) }	16	+ context 'with a invalid name' do
		17	+ let!(:name) { "invalid_name" }
		18	+
		19	+ before :each do
		20	+ get :view, name: name
		21	+ end
		22	+
		23	+ it { is_expected.to respond_with(:not_found) }
		24	+ end
13	end	25	end
14	end	26	end