Choose metric page sends data using post method

Instead of send data via get: it causes error when the metric name had special characters. signed-off-by: Diego Araújo <diegoamc90@gmail.com>

Choose metric page sends data using post method
Instead of send data via get: it causes error when the metric name had special characters. signed-off-by: Diego Araújo <diegoamc90@gmail.com>
Guilherme Rojas V. de Lima · Rafael Manzo
1 parent c5df944d
Showing 5 changed files with 31 additions and 34 deletions Show diff stats
app/assets/javascripts/base_tool.js.coffee
app/controllers/metric_configurations_controller.rb
app/views/metric_configurations/choose_metric.html.erb
features/metric_configuration/create.feature
spec/controllers/metric_configurations_controller_spec.rb
 class @BaseTool
   # Static Method
-  @choose_metric: (mezuro_configuration_id, metric_name, base_tool_name) ->
-    $.post '/mezuro_configurations/' + mezuro_configuration_id + '/metric_configurations/new',
-          {
-            mezuro_configuration_id: mezuro_configuration_id,
-            metric_name: metric_name,
-            base_tool_name: base_tool_name
-          }
+  @choose_metric: (metric_name, base_tool_name) ->
+    $("#metric_name").val(metric_name)
+    $("#base_tool_name").val(base_tool_name)
+    $("form").submit()
@@ -9,6 +9,7 @@ class MetricConfigurationsController &lt; ApplicationController
   def choose_metric
     @mezuro_configuration_id = params[:mezuro_configuration_id].to_i
+    @metric_configuration_id = params[:metric_configuration_id].to_i
     @base_tools = KalibroGem::Entities::BaseTool.all
   end
@@ -17,8 +18,6 @@ class MetricConfigurationsController &lt; ApplicationController
     @metric_configuration.configuration_id = params[:mezuro_configuration_id].to_i
     @metric_configuration.base_tool_name = params[:base_tool_name]
     @metric_configuration.metric = KalibroGem::Entities::BaseTool.find_by_name(params[:base_tool_name]).metric params[:metric_name]
-    format.html { redirect_to mezuro_configuration_path(@metric_configuration.configuration_id), notice: 'Metric Configuration was successfully created.' }
-
   end
   def create
@@ -2,14 +2,17 @@
   <h1>Choose a metric from a base tool:</h1>
 </div>
+<%= form_tag mezuro_configuration_new_metric_configuration_path(@mezuro_configuration_id) do %>
+  <%= hidden_field_tag(:base_tool_name,) %>
+  <%= hidden_field_tag(:metric_name) %>
+<% end %>
+
 <div id="base-tool-accordion">
-  <% @base_tools.each do |base_tool| %>
+ <% @base_tools.each do |base_tool| %>
       <h3><%= base_tool.name %></h3>
       <div>
         <% base_tool.supported_metrics.each do |metric| %>
-          <%= link_to metric.name, '',
-                onclick: "BaseTool.choose_metric(#{@mezuro_configuration_id}, '#{metric.name}', '#{base_tool.name}')",
-                remote: true%><br>
+          <%= link_to metric.name, '#', onclick: "BaseTool.choose_metric('#{metric.name}', '#{base_tool.name}')", remote: true %><br>
         <% end %>
       </div>
   <% end %>
@@ -9,7 +9,7 @@ Feature: Metric Configuration Creation
     And I am at the Sample Configuration page
     Then I should not see New Metric Configuration
-  @kalibro_restart
+  @kalibro_restart @javascript
   Scenario: metric configuration creation
     Given I am a regular user
     And I am signed in
@@ -20,32 +20,30 @@ describe MetricConfigurationsController do
     end
   end
-  pending 'testing the js behavior first' do
-    describe 'new' do
-      let(:base_tool) { FactoryGirl.build(:base_tool) }
+  describe 'new' do
+    let(:base_tool) { FactoryGirl.build(:base_tool) }
+    before :each do
+      sign_in FactoryGirl.create(:user)
+    end
+
+    context 'when the current user owns the mezuro configuration' do
       before :each do
-        sign_in FactoryGirl.create(:user)
+        subject.expects(:mezuro_configuration_owner?).returns true
+        KalibroGem::Entities::BaseTool.expects(:find_by_name).with(base_tool.name).returns(base_tool)
+        post :new, mezuro_configuration_id: mezuro_configuration.id, metric_name: "Lines of Code", base_tool_name: base_tool.name
       end
-      context 'when the current user owns the mezuro configuration' do
-        before :each do
-          subject.expects(:mezuro_configuration_owner?).returns true
-          KalibroGem::Entities::BaseTool.expects(:find_by_name).with(base_tool.name).returns(base_tool)
-          get :new, mezuro_configuration_id: mezuro_configuration.id, metric_name: "Lines of Code", base_tool_name: base_tool.name
-        end
+      it { should respond_with(:success) }
+      it { should render_template(:new) }
+    end
-        it { should respond_with(:success) }
-        it { should render_template(:new) }
+    context "when the current user doesn't owns the mezuro configuration" do
+      before :each do
+        post :new, mezuro_configuration_id: mezuro_configuration.id, metric_name: "Lines of Code", base_tool_name: base_tool.name
       end
-      context "when the current user doesn't owns the mezuro configuration" do
-        before :each do
-          get :new, mezuro_configuration_id: mezuro_configuration.id, metric_name: "Lines of Code", base_tool_name: base_tool.name
-        end
-
-        it { should redirect_to(mezuro_configurations_url) }
-        it { should respond_with(:redirect) }
-      end
+      it { should redirect_to(mezuro_configurations_url) }
+      it { should respond_with(:redirect) }
     end
   end
	@@ -9,7 +9,7 @@ Feature: Metric Configuration Creation		@@ -9,7 +9,7 @@ Feature: Metric Configuration Creation
9	And I am at the Sample Configuration page	9	And I am at the Sample Configuration page
10	Then I should not see New Metric Configuration	10	Then I should not see New Metric Configuration
11		11
12	- @kalibro_restart	12	+ @kalibro_restart @javascript
13	Scenario: metric configuration creation	13	Scenario: metric configuration creation
14	Given I am a regular user	14	Given I am a regular user
15	And I am signed in	15	And I am signed in