Refactored "I should see" cucumber step

Rafael Manzo
1 parent d7212652
Showing 7 changed files with 28 additions and 28 deletions Show diff stats
features/homepage.feature
features/project/create.feature
features/project/edition.feature
features/project/listing.feature
features/step_definitions/homepage_steps.rb
features/user_update.feature
spec/factories/repositories.rb
@@ -5,16 +5,16 @@ Feature: Homepage
   Scenario: Before signing in
     Given I am at the homepage
-    Then I should see Login
-    And I should see Sign Up
-    And I should see Latest projects
-    And I should see Project
+    Then I should see "Login"
+    And I should see "Sign Up"
+    And I should see "Latest projects"
+    And I should see "Project"
   Scenario: Signed in
     Given I am a regular user
     And I am signed in
     And I am at the homepage
-    Then I should see Edit
-    And I should see Logout
-    And I should see Latest projects
-    And I should see Project
 \ No newline at end of file
+    Then I should see "Edit"
+    And I should see "Logout"
+    And I should see "Latest projects"
+    And I should see "Project"
 \ No newline at end of file
@@ -8,7 +8,7 @@ Feature: Project Creation
     Given I am at the All Projects page
     When I click the New Project link
     Then I should be in the Login page
-    And I should see You need to sign in or sign up before continuing.
+    And I should see "You need to sign in or sign up before continuing."
   @kalibro_restart
   Scenario: project creation
@@ -18,8 +18,8 @@ Feature: Project Creation
     And I fill the Name field with "Kalibro"
     And I fill the Description field with "Web Service to collect metrics"
     When I press the Save button
-    Then I should see Kalibro
-    And I should see Web Service to collect metrics
+    Then I should see "Kalibro"
+    And I should see "Web Service to collect metrics"
   @kalibro_restart
   Scenario: project creation with already taken name
@@ -30,7 +30,7 @@ Feature: Project Creation
     And I fill the Name field with "Kalibro"
     And I fill the Description field with "Web Service to collect metrics"
     When I press the Save button
-    Then I should see There's already
+    Then I should see "There's already"
   @kalibro_restart
   Scenario: project creation with blank name
@@ -40,4 +40,4 @@ Feature: Project Creation
     And I fill the Name field with " "
     And I fill the Description field with "Web Service to collect metrics"
     When I press the Save button
-    Then I should see Name can't be blank
 \ No newline at end of file
+    Then I should see "Name can't be blank"
 \ No newline at end of file
@@ -27,7 +27,7 @@ Feature: Project
     And I have a sample project
     And I am at the All Projects page
     When I visit the sample project edit page
-    Then I should see You're not allowed to do this operation
+    Then I should see "You're not allowed to do this operation"
   @kalibro_restart
   Scenario: Filling up the form
@@ -48,8 +48,8 @@ Feature: Project
     And I fill the Name field with "Kalibro"
     And I fill the Description field with "Web Service to collect metrics"
     When I press the Save button
-    Then I should see Kalibro
-    And I should see Web Service to collect metrics
+    Then I should see "Kalibro"
+    And I should see "Web Service to collect metrics"
   @kalibro_restart
   Scenario: With project name already taken
@@ -60,7 +60,7 @@ Feature: Project
     And I am at the sample project edit page
     And I fill the Name field with "Qt-Calculator"
     When I press the Save button
-    Then I should see There's already
+    Then I should see "There's already"
   @kalibro_restart
   Scenario: Editing just the description
@@ -70,7 +70,7 @@ Feature: Project
     And I am at the sample project edit page
     And I fill the Description field with "Web Service to collect metrics"
     When I press the Save button
-    And I should see Web Service to collect metrics
+    And I should see "Web Service to collect metrics"
   @kalibro_restart
   Scenario: With blank project name
@@ -80,4 +80,4 @@ Feature: Project
     And I am at the sample project edit page
     And I fill the Name field with " "
     When I press the Save button
-    Then I should see Name can't be blank
+    Then I should see "Name can't be blank"
@@ -6,9 +6,9 @@ Feature: Project listing
   Scenario: Listing projects
     Given I am at the homepage
     When I click the Project link
-    Then I should see Listing Projects
-    And I should see Name
-    And I should see Description
+    Then I should see "Listing Projects"
+    And I should see "Name"
+    And I should see "Description"
   @kalibro_restart
   Scenario: Should list the existing projects
@@ -25,6 +25,6 @@ Feature: Project listing
     And I have a sample project
     And I am at the All Projects page
     When I click the Show link
-    Then I should see Name
-    And I should see Description
+    Then I should see "Name"
+    And I should see "Description"
     And the sample project should be there
 \ No newline at end of file
@@ -10,6 +10,6 @@ Given(/^I am a regular user$/) do
   @user = FactoryGirl.create(:user)
 end
-Then(/^I should see (.+)$/) do |text|
+Then(/^I should see "(.+)"$/) do |text|
   page.should have_content(text)
 end
 \ No newline at end of file
@@ -11,5 +11,5 @@ Feature: User update
     And I fill the Name field with "Rafael Manzo"
     And I fill the Current password field with "password"
     And I press the Update button
-    Then I should see You updated your account successfully
+    Then I should see "You updated your account successfully"
     And my name should have changed to Rafael Manzo
 \ No newline at end of file
@@ -5,14 +5,14 @@ FactoryGirl.define do
     description "A simple calculator"
     license "GPLv3"
     process_period 1
-    type "SVN"
+    type "SUBVERSION"
     address "svn://svn.code.sf.net/p/qt-calculator/code/trunk"
     configuration_id 1
     project_id 1
     send_email "test@test.com"
   end
-  factory :another_repository, class: KalibroEntities::Entities::Repository, parent: :repository do
+  factory :another_repository, class: Repository, parent: :repository do
     id 2
   end
 end
 \ No newline at end of file
	@@ -10,6 +10,6 @@ Given(/^I am a regular user$/) do		@@ -10,6 +10,6 @@ Given(/^I am a regular user$/) do
10	@user = FactoryGirl.create(:user)	10	@user = FactoryGirl.create(:user)
11	end	11	end
12		12
13	-Then(/^I should see (.+)$/) do \|text\|	13	+Then(/^I should see "(.+)"$/) do \|text\|
14	page.should have_content(text)	14	page.should have_content(text)
15	end	15	end
16	\ No newline at end of file	16	\ No newline at end of file
	@@ -11,5 +11,5 @@ Feature: User update		@@ -11,5 +11,5 @@ Feature: User update
11	And I fill the Name field with "Rafael Manzo"	11	And I fill the Name field with "Rafael Manzo"
12	And I fill the Current password field with "password"	12	And I fill the Current password field with "password"
13	And I press the Update button	13	And I press the Update button
14	- Then I should see You updated your account successfully	14	+ Then I should see "You updated your account successfully"
15	And my name should have changed to Rafael Manzo	15	And my name should have changed to Rafael Manzo
16	\ No newline at end of file	16	\ No newline at end of file
	@@ -5,14 +5,14 @@ FactoryGirl.define do		@@ -5,14 +5,14 @@ FactoryGirl.define do
5	description "A simple calculator"	5	description "A simple calculator"
6	license "GPLv3"	6	license "GPLv3"
7	process_period 1	7	process_period 1
8	- type "SVN"	8	+ type "SUBVERSION"
9	address "svn://svn.code.sf.net/p/qt-calculator/code/trunk"	9	address "svn://svn.code.sf.net/p/qt-calculator/code/trunk"
10	configuration_id 1	10	configuration_id 1
11	project_id 1	11	project_id 1
12	send_email "test@test.com"	12	send_email "test@test.com"
13	end	13	end
14		14
15	- factory :another_repository, class: KalibroEntities::Entities::Repository, parent: :repository do	15	+ factory :another_repository, class: Repository, parent: :repository do
16	id 2	16	id 2
17	end	17	end
18	end	18	end
19	\ No newline at end of file	19	\ No newline at end of file