Download as
Browse Code »

Commit bf6dc7f3b536d104013d38822cf07a7c1f792306

Authored by Rafael Manzo
2 parents 6074f631 6dabfd31
Exists in colab and in 4 other branches master, spb-master, spb-stable, stable

Merge pull request #160 from beatrizrezener/issue40 

Removing useless methods. Closes issue #40.
Showing 6 changed files with 0 additions and 76 deletions   Show diff stats
app/models/mezuro_configuration_ownership.rb
  Diff comments   View file @bf6dc7f
1 1 class MezuroConfigurationOwnership < ActiveRecord::Base
2 2 belongs_to :user
3 3 validates :mezuro_configuration_id, presence: true
4   -
5   - def mezuro_configuration
6   - MezuroConfiguration.find(mezuro_configuration_id)
7   - end
8 4 end
... ...
app/models/reading_group_ownership.rb
  Diff comments   View file @bf6dc7f
1 1 class ReadingGroupOwnership < ActiveRecord::Base
2 2 belongs_to :user
3 3 validates :reading_group_id, presence: true
4   -
5   - def reading_group
6   - ReadingGroup.find(reading_group_id)
7   - end
8 4 end
... ...
app/models/user.rb
  Diff comments   View file @bf6dc7f
... ... @@ -16,12 +16,4 @@ class User &lt; ActiveRecord::Base
16 16 def projects
17 17 project_ownerships.map { |project_ownership| project_ownership.project }
18 18 end
19   -
20   - def reading_groups
21   - reading_group_ownerships.map { |reading_group_ownership| reading_group_ownership.reading_group }
22   - end
23   -
24   - def mezuro_configurations
25   - mezuro_configuration_ownerships.map { |mezuro_configuration_ownership| mezuro_configuration_ownership.mezuro_configuration }
26   - end
27 19 end
... ...
spec/models/mezuro_configuration_ownership_spec.rb
  Diff comments   View file @bf6dc7f
... ... @@ -4,19 +4,4 @@ describe MezuroConfigurationOwnership, :type =&gt; :model do
4 4 describe 'associations' do
5 5 it { is_expected.to belong_to(:user) }
6 6 end
7   -
8   - describe 'methods' do
9   - describe 'mezuro_configuration' do
10   - subject {FactoryGirl.build(:mezuro_configuration_ownership)}
11   - let(:mezuro_configuration) {FactoryGirl.build(:mezuro_configuration)}
12   -
13   - before :each do
14   - MezuroConfiguration.expects(:find).with(subject.mezuro_configuration_id).returns(mezuro_configuration)
15   - end
16   -
17   - it 'should return the mezuro_configuration' do
18   - expect(subject.mezuro_configuration).to eq(mezuro_configuration)
19   - end
20   - end
21   - end
22 7 end
... ...
spec/models/reading_group_ownership_spec.rb
  Diff comments   View file @bf6dc7f
... ... @@ -4,19 +4,4 @@ describe ReadingGroupOwnership, :type =&gt; :model do
4 4 describe 'associations' do
5 5 it { is_expected.to belong_to(:user) }
6 6 end
7   -
8   - describe 'methods' do
9   - describe 'reading_group' do
10   - subject {FactoryGirl.build(:reading_group_ownership)}
11   - let(:reading_group) {FactoryGirl.build(:reading_group)}
12   -
13   - before :each do
14   - ReadingGroup.expects(:find).with(subject.reading_group_id).returns(reading_group)
15   - end
16   -
17   - it 'should return the reading_group' do
18   - expect(subject.reading_group).to eq(reading_group)
19   - end
20   - end
21   - end
22 7 end
... ...
spec/models/user_spec.rb
  Diff comments   View file @bf6dc7f
... ... @@ -30,35 +30,5 @@ describe User, :type =&gt; :model do
30 30 expect(subject.projects).to eq([project])
31 31 end
32 32 end
33   -
34   - describe 'reading_groups' do
35   - subject { FactoryGirl.build(:user) }
36   - let(:reading_group) {FactoryGirl.build(:reading_group)}
37   - let(:reading_group_ownership) {FactoryGirl.build(:reading_group_ownership)}
38   -
39   - before :each do
40   - reading_group_ownership.expects(:reading_group).returns(reading_group)
41   - subject.expects(:reading_group_ownerships).returns([reading_group_ownership])
42   - end
43   -
44   - it 'should return a list of reading groups owned by the user' do
45   - expect(subject.reading_groups).to eq([reading_group])
46   - end
47   - end
48   -
49   - describe 'mezuro_configurations' do
50   - subject { FactoryGirl.build(:user) }
51   - let(:mezuro_configuration) { FactoryGirl.build(:mezuro_configuration) }
52   - let(:mezuro_configuration_ownership) { FactoryGirl.build(:mezuro_configuration_ownership) }
53   -
54   - before :each do
55   - mezuro_configuration_ownership.expects(:mezuro_configuration).returns(mezuro_configuration)
56   - subject.expects(:mezuro_configuration_ownerships).returns([mezuro_configuration_ownership])
57   - end
58   -
59   - it 'should return a list of mezuro configurations owned by the user' do
60   - expect(subject.mezuro_configurations).to eq([mezuro_configuration])
61   - end
62   - end
63 33 end
64 34 end
... ...