Commit c0fc627fc67b9db5bd29a268269956e7093b400b
1 parent
454d15ea
Exists in
colab
and in
4 other branches
Remove metric configuration listing table ambiguity
* The acceptance test got ambiguous when trying to assert for links inside metric configuration tables. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Showing
3 changed files
with
8 additions
and
4 deletions
Show diff stats
app/views/kalibro_configurations/show.html.erb
... | ... | @@ -14,7 +14,7 @@ |
14 | 14 | <div id="tree_metrics"> |
15 | 15 | <h2><%= t('tree_metric').pluralize %></h2> |
16 | 16 | |
17 | -<table class="table table-hover"> | |
17 | +<table class="table table-hover" id="tree_metric_configurations"> | |
18 | 18 | <thead> |
19 | 19 | <tr> |
20 | 20 | <th><%= t('metric') %></th> |
... | ... | @@ -38,7 +38,7 @@ |
38 | 38 | <div id="hotspot_metrics"> |
39 | 39 | <h2><%= t('hotspot_metric').pluralize %></h2> |
40 | 40 | |
41 | -<table class="table table-hover"> | |
41 | +<table class="table table-hover" id="hotspot_metric_configurations"> | |
42 | 42 | <thead> |
43 | 43 | <tr> |
44 | 44 | <th><%= t('metric') %></th> | ... | ... |
features/compound_metric_configuration/edition.feature
... | ... | @@ -3,7 +3,7 @@ Feature: Compound Metric Configuration edition |
3 | 3 | As a regular user |
4 | 4 | I should edit the informations of compound metric configurations |
5 | 5 | |
6 | - @kalibro_configuration_restart @wip | |
6 | + @kalibro_configuration_restart | |
7 | 7 | Scenario: the configuration is not mine |
8 | 8 | Given I am a regular user |
9 | 9 | And I am signed in |
... | ... | @@ -12,7 +12,7 @@ Feature: Compound Metric Configuration edition |
12 | 12 | And I have a sample metric configuration within the given mezuro configuration |
13 | 13 | And I have a sample compound metric configuration within the given mezuro configuration |
14 | 14 | When I am at the Sample Configuration page |
15 | - Then I should not see Edit within table | |
15 | + Then I should not find "Edit" within "table#tree_metric_configurations" | |
16 | 16 | |
17 | 17 | @kalibro_configuration_restart |
18 | 18 | Scenario: editing a compound metric configuration successfully | ... | ... |
features/step_definitions/project_steps.rb
... | ... | @@ -50,6 +50,10 @@ Then(/^I should not see (.+) within (.+)$/) do |text, selector| |
50 | 50 | expect(page.find(selector)).to_not have_content(text) |
51 | 51 | end |
52 | 52 | |
53 | +Then(/^I should not find "(.+)" within "(.+)"$/) do |text, selector| | |
54 | + step "I should not see #{text} within #{selector}" | |
55 | +end | |
56 | + | |
53 | 57 | Then(/^the sample project should be there$/) do |
54 | 58 | expect(page).to have_content(@project.name) |
55 | 59 | expect(page).to have_content(@project.description) | ... | ... |