Assynchornous loading and updating repository state and time

Missing acceptance tests

Assynchornous loading and updating repository state and time
Missing acceptance tests
Rafael Manzo · Paulo Meireles
1 parent cc07efdd
Showing 8 changed files with 47 additions and 38 deletions Show diff stats
app/assets/javascripts/repository.js.coffee
app/controllers/repositories_controller.rb
app/views/repositories/_processing_information.html.erb
app/views/repositories/load_ready_processing.js.erb
app/views/repositories/reload_processing.js.erb
app/views/repositories/show.html.erb
features/repository/show.feature
spec/controllers/repositories_controller_spec.rb
@@ -0,0 +1,13 @@
+class Module.Repository
+  constructor: (@project_id, @repository_id) ->
+
+  poll_state: (last_state) ->
+    $.post '/projects/' + @project_id + '/repositories/' + @repository_id + '/state',
+          last_state: last_state
+
+  schedule_poll_state: (last_state) ->
+    context = this
+    call = () ->
+              context.poll_state(last_state)
+
+    setTimeout( call, 15000 ) # Delays in 15s the next call
@@ -12,7 +12,6 @@ class RepositoriesController &lt; ApplicationController
   # GET /projects/1/repositories/1/modules/1.json
   def show
     @configuration = KalibroGem::Entities::Configuration.find(@repository.configuration_id) #FIXME: As soon as the Configuration model gets created refactor this!
-    @processing = @repository.last_processing
   end
  
   # GET projects/1/repositories/new
@@ -0,0 +1,18 @@
+<p>
+  <strong>State:</strong>
+  <%= @processing.state %>
+</p>
+
+<p>
+  <strong>Creation date:</strong>
+  <%= @processing.date.strftime("%Y/%m/%d at %Hh%M (%z)") %>
+</p>
+
+<% unless @processing.process_times.nil? %>
+  <% @processing.process_times.each do |process_time| %>
+    <p>
+      <strong><%= process_time.state %> time:</strong>
+      <%= humanize_eplased_time(process_time.time) %>
+    </p>
+  <% end %>
+<% end %>
 \ No newline at end of file
@@ -0,0 +1,2 @@
+$('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
+Module.Tree.load("<%= escape_javascript(image_tag 'loader.gif') %> Loading data. Please, wait.", <%= @processing.results_root_id %>)
 \ No newline at end of file
@@ -0,0 +1,3 @@
+$('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
+repository = new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)
+repository.schedule_poll_state('<%= @processing.state %>')
 \ No newline at end of file
@@ -36,44 +36,20 @@
  
 <div id="repository-accordion">
   <h3>Processing information</h3>
-  <div>
-    <p>
-      <strong>State:</strong>
-      <%= @processing.state %>
-    </p>
+  <div id="processing_information"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
  
-    <p>
-      <strong>Creation date:</strong>
-      <%= @processing.date.strftime("%Y/%m/%d at %Hh%M (%z)") %>
-    </p>
+  <h3>Modules Tree</h3>
+  <div id="module_tree"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
  
-    <% unless @processing.process_times.nil? %>
-      <% @processing.process_times.each do |process_time| %>
-        <p>
-          <strong><%= process_time.state %> time:</strong>
-          <%= humanize_eplased_time(process_time.time) %>
-        </p>
-      <% end %>
-    <% end %>
-  </div>
-
-  <% if @processing.ready? %>
-    <h3>Modules Tree</h3>
-    <div id="module_tree"></div>
-
-    <h3>Metric Results</h3>
-    <div id="metric_results"></div>
-
-  <% end %>
+  <h3>Metric Results</h3>
+  <div id="metric_results"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
 </div>
 <script type="text/javascript">
-  <% if @processing.ready? %>
     $(document).ready(function () {
-        Module.Tree.load("<%= escape_javascript(image_tag 'loader.gif') %> Loading data. Please, wait.", <%= @processing.results_root_id %>);
+      (new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)).poll_state('')
     });
-  <% end %>
  
-  //Loads the accorcion
+  //Loads the accordion
   $(function() {
     $( "#repository-accordion" ).accordion({
       heightStyle: "content"
@@ -59,10 +59,10 @@ Feature: Show Repository
     And I should see "Configuration"
     And I should see "State"
     And I should see "Creation date"
-    And I should not see Metric
-    And I should not see Value
-    And I should not see Weight
-    And I should not see Threshold
+    When I click the "Metric Results" h3
+    Then I should see "Loading data. Please, wait."
+    When I click the "Modules Tree" h3
+    Then I should see "Loading data. Please, wait."
  
   @kalibro_restart @javascript
   Scenario: Should show modules directories root when the process has been finished
@@ -86,7 +86,6 @@ describe RepositoriesController do
       before :each do
         processing = FactoryGirl.build(:processing)
  
-        repository.expects(:last_processing).returns(processing)
         KalibroGem::Entities::Configuration.expects(:find).with(repository.id).returns(FactoryGirl.build(:configuration))
         Repository.expects(:find).with(repository.id).returns(repository)
  
@@ -101,7 +100,6 @@ describe RepositoriesController do
       before :each do
         processing = FactoryGirl.build(:processing)
  
-        repository.expects(:last_processing).returns(processing)
         KalibroGem::Entities::Configuration.expects(:find).with(repository.id).returns(FactoryGirl.build(:configuration))
         Repository.expects(:find).with(repository.id).returns(repository)
...	...	@@ -0,0 +1,13 @@
	1	+class Module.Repository
	2	+ constructor: (@project_id, @repository_id) ->
	3	+
	4	+ poll_state: (last_state) ->
	5	+ $.post '/projects/' + @project_id + '/repositories/' + @repository_id + '/state',
	6	+ last_state: last_state
	7	+
	8	+ schedule_poll_state: (last_state) ->
	9	+ context = this
	10	+ call = () ->
	11	+ context.poll_state(last_state)
	12	+
	13	+ setTimeout( call, 15000 ) # Delays in 15s the next call
...	...
...	...	@@ -12,7 +12,6 @@ class RepositoriesController < ApplicationController
12	12	# GET /projects/1/repositories/1/modules/1.json
13	13	def show
14	14	@configuration = KalibroGem::Entities::Configuration.find(@repository.configuration_id) #FIXME: As soon as the Configuration model gets created refactor this!
15		- @processing = @repository.last_processing
16	15	end
17	16
18	17	# GET projects/1/repositories/new
...	...
...	...	@@ -0,0 +1,18 @@
	1	+<p>
	2	+ <strong>State:</strong>
	3	+ <%= @processing.state %>
	4	+</p>
	5	+
	6	+<p>
	7	+ <strong>Creation date:</strong>
	8	+ <%= @processing.date.strftime("%Y/%m/%d at %Hh%M (%z)") %>
	9	+</p>
	10	+
	11	+<% unless @processing.process_times.nil? %>
	12	+ <% @processing.process_times.each do \|process_time\| %>
	13	+ <p>
	14	+ <strong><%= process_time.state %> time:</strong>
	15	+ <%= humanize_eplased_time(process_time.time) %>
	16	+ </p>
	17	+ <% end %>
	18	+<% end %>
0	19	\ No newline at end of file
...	...
...	...	@@ -0,0 +1,2 @@
	1	+$('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
	2	+Module.Tree.load("<%= escape_javascript(image_tag 'loader.gif') %> Loading data. Please, wait.", <%= @processing.results_root_id %>)
0	3	\ No newline at end of file
...	...
...	...	@@ -0,0 +1,3 @@
	1	+$('div#processing_information').html('<%= escape_javascript(render partial: "processing_information") %>');
	2	+repository = new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)
	3	+repository.schedule_poll_state('<%= @processing.state %>')
0	4	\ No newline at end of file
...	...
...	...	@@ -36,44 +36,20 @@
36	36
37	37	<div id="repository-accordion">
38	38	<h3>Processing information</h3>
39		- <div>
40		- <p>
41		- <strong>State:</strong>
42		- <%= @processing.state %>
43		- </p>
	39	+ <div id="processing_information"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
44	40
45		- <p>
46		- <strong>Creation date:</strong>
47		- <%= @processing.date.strftime("%Y/%m/%d at %Hh%M (%z)") %>
48		- </p>
	41	+ <h3>Modules Tree</h3>
	42	+ <div id="module_tree"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
49	43
50		- <% unless @processing.process_times.nil? %>
51		- <% @processing.process_times.each do \|process_time\| %>
52		- <p>
53		- <strong><%= process_time.state %> time:</strong>
54		- <%= humanize_eplased_time(process_time.time) %>
55		- </p>
56		- <% end %>
57		- <% end %>
58		- </div>
59		-
60		- <% if @processing.ready? %>
61		- <h3>Modules Tree</h3>
62		- <div id="module_tree"></div>
63		-
64		- <h3>Metric Results</h3>
65		- <div id="metric_results"></div>
66		-
67		- <% end %>
	44	+ <h3>Metric Results</h3>
	45	+ <div id="metric_results"><%= image_tag 'loader.gif' %> Loading data. Please, wait.</div>
68	46	</div>
69	47	<script type="text/javascript">
70		- <% if @processing.ready? %>
71	48	$(document).ready(function () {
72		- Module.Tree.load("<%= escape_javascript(image_tag 'loader.gif') %> Loading data. Please, wait.", <%= @processing.results_root_id %>);
	49	+ (new Module.Repository(<%= @repository.project_id %>, <%= @repository.id %>)).poll_state('')
73	50	});
74		- <% end %>
75	51
76		- //Loads the accorcion
	52	+ //Loads the accordion
77	53	$(function() {
78	54	$( "#repository-accordion" ).accordion({
79	55	heightStyle: "content"
...	...
...	...	@@ -59,10 +59,10 @@ Feature: Show Repository
59	59	And I should see "Configuration"
60	60	And I should see "State"
61	61	And I should see "Creation date"
62		- And I should not see Metric
63		- And I should not see Value
64		- And I should not see Weight
65		- And I should not see Threshold
	62	+ When I click the "Metric Results" h3
	63	+ Then I should see "Loading data. Please, wait."
	64	+ When I click the "Modules Tree" h3
	65	+ Then I should see "Loading data. Please, wait."
66	66
67	67	@kalibro_restart @javascript
68	68	Scenario: Should show modules directories root when the process has been finished
...	...
...	...	@@ -86,7 +86,6 @@ describe RepositoriesController do
86	86	before :each do
87	87	processing = FactoryGirl.build(:processing)
88	88
89		- repository.expects(:last_processing).returns(processing)
90	89	KalibroGem::Entities::Configuration.expects(:find).with(repository.id).returns(FactoryGirl.build(:configuration))
91	90	Repository.expects(:find).with(repository.id).returns(repository)
92	91
...	...	@@ -101,7 +100,6 @@ describe RepositoriesController do
101	100	before :each do
102	101	processing = FactoryGirl.build(:processing)
103	102
104		- repository.expects(:last_processing).returns(processing)
105	103	KalibroGem::Entities::Configuration.expects(:find).with(repository.id).returns(FactoryGirl.build(:configuration))
106	104	Repository.expects(:find).with(repository.id).returns(repository)
107	105
...	...