Commit f22cae9c586a45babc564749ad3a5e8e274efe94
Committed by
Rafael Manzo
1 parent
f3027748
Exists in
colab
and in
4 other branches
Removed expected call to validator on project spec
Showing
1 changed file
with
60 additions
and
63 deletions
Show diff stats
spec/models/project_spec.rb
1 | 1 | require 'rails_helper' |
2 | 2 | |
3 | 3 | describe Project, :type => :model do |
4 | - pending 'waiting for kalibro configurations integration' do | |
5 | - describe 'methods' do | |
6 | - describe 'persisted?' do | |
7 | - before :each do | |
8 | - @subject = FactoryGirl.build(:project) | |
9 | - Project.expects(:exists?).with(@subject.id).returns(false) | |
10 | - end | |
4 | + describe 'methods' do | |
5 | + describe 'persisted?' do | |
6 | + before :each do | |
7 | + @subject = FactoryGirl.build(:project) | |
8 | + Project.expects(:exists?).with(@subject.id).returns(false) | |
9 | + end | |
11 | 10 | |
12 | - it 'should return false' do | |
13 | - expect(@subject.persisted?).to eq(false) | |
14 | - end | |
11 | + it 'should return false' do | |
12 | + expect(@subject.persisted?).to eq(false) | |
15 | 13 | end |
14 | + end | |
16 | 15 | |
17 | - describe 'latest' do | |
18 | - before :each do | |
19 | - @qt = FactoryGirl.build(:project) | |
20 | - @kalibro = FactoryGirl.build(:another_project) | |
16 | + describe 'latest' do | |
17 | + before :each do | |
18 | + @qt = FactoryGirl.build(:project) | |
19 | + @kalibro = FactoryGirl.build(:another_project) | |
21 | 20 | |
22 | - Project.expects(:all).returns([@qt, @kalibro]) | |
23 | - end | |
21 | + Project.expects(:all).returns([@qt, @kalibro]) | |
22 | + end | |
24 | 23 | |
25 | - it 'should return the two projects ordered' do | |
26 | - expect(Project.latest(2)).to eq([@kalibro, @qt]) | |
27 | - end | |
24 | + it 'should return the two projects ordered' do | |
25 | + expect(Project.latest(2)).to eq([@kalibro, @qt]) | |
26 | + end | |
28 | 27 | |
29 | - context 'when no parameter is passed' do | |
30 | - it 'should return just the most recent project' do | |
31 | - expect(Project.latest).to eq([@kalibro]) | |
32 | - end | |
28 | + context 'when no parameter is passed' do | |
29 | + it 'should return just the most recent project' do | |
30 | + expect(Project.latest).to eq([@kalibro]) | |
33 | 31 | end |
34 | 32 | end |
33 | + end | |
35 | 34 | |
36 | - describe 'update' do | |
35 | + describe 'update' do | |
36 | + before :each do | |
37 | + @qt = FactoryGirl.build(:project) | |
38 | + @qt_params = Hash[FactoryGirl.attributes_for(:project).map { |k,v| [k.to_s, v.to_s] }] #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with sybols and integers | |
39 | + end | |
40 | + | |
41 | + context 'with valid attributes' do | |
37 | 42 | before :each do |
38 | - @qt = FactoryGirl.build(:project) | |
39 | - @qt_params = Hash[FactoryGirl.attributes_for(:project).map { |k,v| [k.to_s, v.to_s] }] #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with sybols and integers | |
43 | + @qt.expects(:save).returns(true) | |
40 | 44 | end |
41 | 45 | |
42 | - context 'with valid attributes' do | |
43 | - before :each do | |
44 | - @qt.expects(:save).returns(true) | |
45 | - end | |
46 | - | |
47 | - it 'should return true' do | |
48 | - expect(@qt.update(@qt_params)).to eq(true) | |
49 | - end | |
46 | + it 'should return true' do | |
47 | + expect(@qt.update(@qt_params)).to eq(true) | |
50 | 48 | end |
49 | + end | |
51 | 50 | |
52 | - context 'with invalid attributes' do | |
53 | - before :each do | |
54 | - @qt.expects(:save).returns(false) | |
55 | - end | |
51 | + context 'with invalid attributes' do | |
52 | + before :each do | |
53 | + @qt.expects(:save).returns(false) | |
54 | + end | |
56 | 55 | |
57 | - it 'should return false' do | |
58 | - expect(@qt.update(@qt_params)).to eq(false) | |
59 | - end | |
56 | + it 'should return false' do | |
57 | + expect(@qt.update(@qt_params)).to eq(false) | |
60 | 58 | end |
61 | 59 | end |
60 | + end | |
62 | 61 | |
63 | - describe 'repositories' do | |
64 | - subject { FactoryGirl.build(:project) } | |
65 | - let(:repository) { FactoryGirl.build(:repository) } | |
62 | + describe 'repositories' do | |
63 | + subject { FactoryGirl.build(:project) } | |
64 | + let(:repository) { FactoryGirl.build(:repository) } | |
66 | 65 | |
67 | - it 'should call repositories_of on the Repository model' do | |
68 | - Repository.expects(:repositories_of).with(subject.id).returns([repository]) | |
66 | + it 'should call repositories_of on the Repository model' do | |
67 | + Repository.expects(:repositories_of).with(subject.id).returns([repository]) | |
69 | 68 | |
70 | - expect(subject.repositories).to include(repository) | |
71 | - end | |
69 | + expect(subject.repositories).to include(repository) | |
72 | 70 | end |
73 | 71 | end |
72 | + end | |
74 | 73 | |
75 | - describe 'validations' do | |
76 | - subject {FactoryGirl.build(:project)} | |
77 | - context 'active model validations' do | |
78 | - before :each do | |
79 | - Project.expects(:all).at_least_once.returns([]) | |
80 | - end | |
81 | - it { is_expected.to validate_presence_of(:name) } | |
74 | + describe 'validations' do | |
75 | + subject {FactoryGirl.build(:project)} | |
76 | + context 'active model validations' do | |
77 | + before :each do | |
78 | + Project.expects(:all).at_least_once.returns([]) | |
82 | 79 | end |
80 | + it { is_expected.to validate_presence_of(:name) } | |
81 | + end | |
83 | 82 | |
84 | - context 'kalibro validations' do | |
85 | - before :each do | |
86 | - Project.expects(:request).returns(42) | |
87 | - end | |
83 | + context 'kalibro validations' do | |
84 | + before :each do | |
85 | + Project.expects(:request).returns(42) | |
86 | + end | |
88 | 87 | |
89 | - it 'should validate uniqueness' do | |
90 | - KalibroUniquenessValidator.any_instance.expects(:validate_each).with(subject, :name, subject.name) | |
91 | - subject.save | |
92 | - end | |
88 | + it 'should validate uniqueness' do | |
89 | + subject.save | |
93 | 90 | end |
94 | 91 | end |
95 | 92 | end | ... | ... |