Update record #latest methods to be a bit more robust

Don't fail with NoMethodError if a KalibroConfiguration or Project does not have Attributes saved.

Update record #latest methods to be a bit more robust
Don't fail with NoMethodError if a KalibroConfiguration or Project does not have Attributes saved.
Daniel · Diego Araújo
1 parent 75f3fbe9
Showing 2 changed files with 11 additions and 5 deletions Show diff stats
app/models/kalibro_configuration.rb
app/models/project.rb
@@ -19,6 +19,13 @@ class KalibroConfiguration &lt; KalibroClient::Entities::Configurations::KalibroCon
     self.public_or_owned_by_user
   end
+  def self.latest(count = 1)
+    all.sort { |one, another| another.id <=> one.id }.select { |kalibro_configuration|
+      attributes = kalibro_configuration.attributes
+      attributes && attributes.public
+    }.first(count)
+  end
+
   def attributes
     @attributes ||= KalibroConfigurationAttributes.find_by(kalibro_configuration_id: self.id)
   end
@@ -28,8 +35,4 @@ class KalibroConfiguration &lt; KalibroClient::Entities::Configurations::KalibroCon
     @attributes = nil
     super
   end
-
-  def self.latest(count=1)
-    all.sort { |one, another| another.id <=> one.id }.select { |kalibro_configuration| kalibro_configuration.attributes.public }.first(count)
-  end
 end
@@ -17,7 +17,10 @@ class Project &lt; KalibroClient::Entities::Processor::Project
   end
   def self.latest(count = 1)
-    all.sort { |a, b| b.id <=> a.id }.select { |project| project.attributes.public }.first(count)
+    all.sort { |one, another| another.id <=> one.id }.select { |project|
+      attributes = project.attributes
+      attributes && attributes.public
+    }.first(count)
   end
   def attributes