18 Apr, 2016

9 commits


16 Apr, 2016

5 commits


15 Apr, 2016

10 commits


13 Apr, 2016

12 commits


11 Apr, 2016

4 commits

  • Refactor Webhook support to allow verification of parameters
    Daniel
     
  • The repository/notify_push feature was making post request directly
    using Rack::Test methods, which is not optimal when we have Capybara to
    handle all the driver setup and flexibility for us.
    
    Change it to use Capybara methods, and fix all the steps accordingly. To
    make things easier, add some helper methods to deal with headers in
    different drivers.
    
    Also fix a small clarity issue in the notify_push unity tests that also
    have to set headers.
    Daniel
     
  • Ensure webhook requests are only accepted after proper verification of
    expected headers, repository address and branch, using the newly
    implemented library.
    
    To that effect, split up the logic to extract that information from
    requests to it's own class, and use it in the notify_push action.
    
    Also, add factories to make better testing of the notify_push action
    possible, such as a factory similar to a real request from Gitlab, and
    one for the Kalibro Client repository on Gitlab.
    
    Adding other hook providers should be quite a lot easier after this is
    applied.
    Daniel
     
  • It can abstract different webhook formats for different services, and
    have verification of request, repository address and branch information.
    Daniel