22 May, 2015

4 commits


21 May, 2015

4 commits


27 Apr, 2015

1 commit

  • Error handling for finding resources in controllers used a find_resource
    method. It was broken and was letting code pass-through after errors. In
    addition, cases for find methods for things other than simple IDs
    weren't handled.
    
    Replace it with an error handler in ApplicationController capturing
    RecordNotFound exceptions and returning the appropriate error pages (or
    JSON).
    
    Also, fix usages of find that should throw errors (using ActiveRecord
    methods ending with !) but didn't.
    
    Correspondly, fix all the tests that mocked the find_resource method,
    and correct expectations where needed.
    
    Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
    Diego Camarinha
     

17 Apr, 2015

1 commit


12 Feb, 2015

2 commits