27 Apr, 2015

1 commit

  • e390e540   Correct error handling for resource finding in controllers ... Browse File » 
    Error handling for finding resources in controllers used a find_resource
method. It was broken and was letting code pass-through after errors. In
addition, cases for find methods for things other than simple IDs
weren't handled.

Replace it with an error handler in ApplicationController capturing
RecordNotFound exceptions and returning the appropriate error pages (or
JSON).

Also, fix usages of find that should throw errors (using ActiveRecord
methods ending with !) but didn't.

Correspondly, fix all the tests that mocked the find_resource method,
and correct expectations where needed.

Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
    Diego Camarinha
     

10 Dec, 2014

1 commit

07 Aug, 2014

1 commit

05 Jun, 2014

1 commit

  • d576da37   Convert specs to RSpec 2.99.0 syntax with Transpec ... Browse File » 
    This conversion is done by Transpec 2.2.1 with the following command:
    transpec

* 258 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 82 conversions
    from: obj.should
      to: expect(obj).to

* 16 conversions
    from: describe 'some model' { }
      to: describe 'some model', :type => :model { }

* 12 conversions
    from: describe 'some controller' { }
      to: describe 'some controller', :type => :controller { }

* 11 conversions
    from: describe 'some routing' { }
      to: describe 'some routing', :type => :routing { }

* 8 conversions
    from: describe 'some helper' { }
      to: describe 'some helper', :type => :helper { }

* 7 conversions
    from: be_false
      to: be_falsey

* 6 conversions
    from: be_true
      to: be_truthy

* 6 conversions
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

* 4 conversions
    from: obj.should_not
      to: expect(obj).not_to

For more details: https://github.com/yujinakayama/transpec#supported-conversions

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Renan Fichberg
     

22 Apr, 2014

1 commit

09 Mar, 2014

1 commit

27 Jan, 2014

2 commits

23 Jan, 2014

2 commits

21 Jan, 2014

1 commit

09 Dec, 2013

1 commit

27 Nov, 2013

1 commit

26 Nov, 2013

1 commit

25 Nov, 2013

2 commits