22 Feb, 2016
3 commits
-
Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
-
There were outdated tests that did not update from the deprecated 'Average' aggregation form to 'Mean'. Fix that, while simultaneously refactoring the configuration creation and repository processing features, into a single 'golden path' that tests boths, ensuring a very common user task works as expected. Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
-
It previously kept running forever if the processing never succeeded. Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
17 Feb, 2016
6 commits
-
Defaults to localhost memcached server
-
Update kalibro_client
-
This improves platform compatibility and reflects the new mezuro.org configuration.
-
After kalibro_client upgrade, scope now has the type nested as a key.
-
Due to the kalibro_client upgrade, metric granularities are now actual object instances instead of hashes.
-
Now scope has a hash with key type.
12 Feb, 2016
1 commit
-
KalibroClient now expectes granularity as a hash with key type.
05 Feb, 2016
1 commit
-
This update is necessary to run the newest service versions.
03 Feb, 2016
6 commits
29 Jan, 2016
2 commits
-
Replace url helpers by the path ones
-
This is expected to improve compatibility with reverse-proxies. Still, for full compatibility, regarding redirections, we still may need to set the default url options with the proxy host. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
22 Jan, 2016
6 commits
-
Hotspot metric configuration creation
-
Calling methods with self improve the readability as it makes clear that it is not a variable but a method! Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Signed-off-by: Heitor Reis <marcheing@gmail.com>
-
It will never return nil. At most, it will raise a ActiveRecord::RecordNotFound Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed off by: Diego Araújo <diegoamc90@gmail.com>
20 Jan, 2016
15 commits
-
Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
Test the path where the provided metric's type is different from the controller's one. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
We were not testing the case when the returned metric_configuration was from a different KalibroConfiguration. This prevents different ownership MetricConfiguration editions and false positives for ownership_authentication helper. Signed off by: Heitor Reis <marcheing@gmail.com>
-
The code is pretty straightforward, just raising an Error in order to force subclasses to implement this. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
There was no test case for failed_action when the action was neither create or update. The coverage was achieved through show action with invalid reading group id. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
It was missing proper mocks for the set_metric! before_action from BaseMetricConfigurationsController. Signed off by: Heitor Reis <marcheing@gmail.com>
-
Also improve error reporting functions
-
Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Move as much code as possible to BaseMetricConfigurationsController instead of repeating it ad-hoc in the concrete classes. Most of the concrete code has gone away except for some small overrides: - Hotspot's does not have a 'new' action, and therefore can't redirect to it. It also does not accept any MetricConfiguration parameters. - Metric's only accepts 'weight' and 'aggregation_form' MetricConfiguration parameters. It also needs to fetch ReadingGroups to display in the 'choose_metric' action. - Compound's needs to force the Metric type when creating the metric, and must accept parameters for Metric ('name', 'description', 'script', 'scope', 'code') in addition to MetricConfiguration's 'weight'. Additionally: - Update cache clearing to clear caches for Hotspot and Tree configurations - Verify the existence of the KalibroConfiguration and use the object that was fetched whenever necessary, instead of only using the id. - Ensure the KalibroConfiguration and ReadingGroup ids match between the values inside and outside the 'metric_configuration' parameter. Previously it was possible to send one in the URL and update another, which might even have been a security issue. - Allow sending either 'metric_code' or 'metric_name' as a parameter. Both are used in different places in the code, but making them uniform is a job for a later time. Signed off by: Daniel Miranda <danielkza2@gmail.com> -
There will no longer be a @kalibro_configuration_id instance variable, and all the views will use @metric_configuration, with no special cases like Compound previously had. Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
All of it's code is covered by the concrete class tests, and the abstract class tests were nothing like real usage, and will be made totally obsolete with the refactor. Signed off by: Daniel Miranda <danielkza2@gmail.com>
