22 Jan, 2016

1 commit

20 Jan, 2016

4 commits

  • eaaf4f2f   Add proper Reading Group fetching in Metric Configurations controllers ... Browse File » 
    Also improve error reporting functions
    Daniel
     
  • eaa33fc4   Refactor MetricConfiguration controllers ... Browse File » 
    Move as much code as possible to BaseMetricConfigurationsController
instead of repeating it ad-hoc in the concrete classes. Most of the
concrete code has gone away except for some small overrides:

- Hotspot's does not have a 'new' action, and therefore can't redirect
to it. It also does not accept any MetricConfiguration parameters.
- Metric's only accepts 'weight' and 'aggregation_form'
MetricConfiguration parameters. It also needs to fetch ReadingGroups to
display in the 'choose_metric' action.
- Compound's needs to force the Metric type when creating the metric,
and must accept parameters for Metric ('name', 'description', 'script',
'scope', 'code') in addition to MetricConfiguration's 'weight'.

Additionally:
- Update cache clearing to clear caches for Hotspot and Tree
configurations
- Verify the existence of the KalibroConfiguration and use the object
that was fetched whenever necessary, instead of only using the id.
- Ensure the KalibroConfiguration and ReadingGroup ids match between the
values inside and outside the 'metric_configuration' parameter.
Previously it was possible to send one in the URL and update another,
which might even have been a security issue.
- Allow sending either 'metric_code' or 'metric_name' as a parameter.
Both are used in different places in the code, but making them uniform
is a job for a later time.

Signed off by: Daniel Miranda <danielkza2@gmail.com>
    Heitor
     
  • c91af636   Add a redirect on hotspot metric configuration creation ... Browse File » 
    Now it doesn't redirect to the tree metric configuration creation page
after choosing a hotspot metric configuration

Adds a bunch of code from removed commit
ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the
modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f.

It fixes the view to properly work with the path helper.

This is a squash of two commits.

Signed off by: Diego Araújo <diegoamc90@gmail.com>
Signed off by: Heitor Reis <marcheing@gmail.com>
    Heitor
     
  • 07fca75c   Create HotspotMetricConfigurationsController ... Browse File » 
    It has just the prototype for the method so its route works. This
route will be useful when creating the upcoming helper method for metric
configuration creation form.

Signed off by: Heitor Reis <marcheing@gmail.com>
    Rafael Manzo