20 Apr, 2016

1 commit

18 Apr, 2016

2 commits

11 Apr, 2016

2 commits

  • 4734ba1b   Update header and request handling in tests ... Browse File » 
    The repository/notify_push feature was making post request directly
using Rack::Test methods, which is not optimal when we have Capybara to
handle all the driver setup and flexibility for us.

Change it to use Capybara methods, and fix all the steps accordingly. To
make things easier, add some helper methods to deal with headers in
different drivers.

Also fix a small clarity issue in the notify_push unity tests that also
have to set headers.
    Daniel
     
  • b2d7c543   Refactor Webhook support to allow verification of parameters ... Browse File » 
    Ensure webhook requests are only accepted after proper verification of
expected headers, repository address and branch, using the newly
implemented library.

To that effect, split up the logic to extract that information from
requests to it's own class, and use it in the notify_push action.

Also, add factories to make better testing of the notify_push action
possible, such as a factory similar to a real request from Gitlab, and
one for the Kalibro Client repository on Gitlab.

Adding other hook providers should be quite a lot easier after this is
applied.
    Daniel
     

22 Feb, 2016

1 commit

25 Nov, 2015

1 commit

19 Nov, 2015

2 commits

06 Nov, 2015

2 commits

26 Oct, 2015

4 commits

24 Aug, 2015

1 commit

14 Aug, 2015

1 commit

08 Jul, 2015

2 commits

06 Jul, 2015

2 commits

22 Jun, 2015

1 commit

17 Jun, 2015

1 commit

  • e19c7cef   Repository routes decoupled from Project ... Browse File » 
    new and create action can be acessed both with or without a project. This
enables to have repositories the two ways.

The behaviour for the back had to change from going back to a specific project
page. To the all projects pages since some repositories may not have a
project_id.

With the routes, many helpers had to get fixed together with acceptance
tests steps (for this a new step was created in order to be able to create
RepositoryAttributes).

Finally the JS for repository state retrieval needed fixes since it builds the
route withot any helper. Same thing for the JS that prevents infinite state
queries.

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Pedro
     

21 May, 2015

1 commit

29 Apr, 2015

1 commit

17 Apr, 2015

4 commits

06 Apr, 2015

1 commit

25 Feb, 2015

1 commit

19 Feb, 2015

1 commit

12 Feb, 2015

8 commits