Commit 6f252a32edffca0ad71daeee1affa630be2a8c37
1 parent
003ec648
Exists in
master
and in
9 other branches
Change ranking algorithm
Showing
1 changed file
with
7 additions
and
4 deletions
Show diff stats
lib/proposals_discussion_plugin/api.rb
| @@ -4,12 +4,15 @@ class ProposalsDiscussionPlugin::API < Grape::API | @@ -4,12 +4,15 @@ class ProposalsDiscussionPlugin::API < Grape::API | ||
| 4 | 4 | ||
| 5 | get ':id/ranking' do | 5 | get ':id/ranking' do |
| 6 | article = find_article(environment.articles, params[:id]) | 6 | article = find_article(environment.articles, params[:id]) |
| 7 | - Rails.cache.fetch("#{article.cache_key}/proposals_ranking", expires_in: 1.hours) do | 7 | + Rails.cache.fetch("#{article.cache_key}/proposals_ranking", expires_in: 10.minutes) do |
| 8 | + max_hits = article.proposals.maximum(:hits) | ||
| 9 | + min_hits = article.proposals.minimum(:hits) | ||
| 10 | + | ||
| 8 | proposals = article.proposals.map do |proposal| | 11 | proposals = article.proposals.map do |proposal| |
| 9 | - effective_support = (proposal.votes_for - proposal.votes_against)/proposal.hits.to_f | ||
| 10 | - effective_participation = (proposal.votes_for + proposal.votes_against)/proposal.hits.to_f | 12 | + w = [(proposal.hits - max_hits).abs, (proposal.hits - min_hits).abs].max.to_f |
| 13 | + effective_support = (proposal.votes_for - proposal.votes_against)/w | ||
| 11 | 14 | ||
| 12 | - {:id => proposal.id, :abstract => proposal.abstract, :votes_for => proposal.votes_for, :votes_against => proposal.votes_against, :hits => proposal.hits, :effective_support => effective_support, :effective_participation => effective_participation} | 15 | + {:id => proposal.id, :abstract => proposal.abstract, :votes_for => proposal.votes_for, :votes_against => proposal.votes_against, :hits => proposal.hits, :effective_support => effective_support} |
| 13 | end | 16 | end |
| 14 | proposals = proposals.sort_by { |p| p[:effective_support] }.reverse | 17 | proposals = proposals.sort_by { |p| p[:effective_support] }.reverse |
| 15 | {:proposals => proposals, :updated_at => DateTime.now} | 18 | {:proposals => proposals, :updated_at => DateTime.now} |