Merge Request #4

← To merge requests From restore_rejected_proposal into master
Open
noosfero-plugins/proposals_discussion!4
Created by Michel Felipe

New feature: Restore a rejected or finished proposal

Added new button into processed tasks page to allow the admin restore 1 or N proposals to initial status.

In the last commit, was made a refactor to add a relation between tasks and articles entities. The article related with a proposal task is disabled when the task returns to their initial status!!

Assignee: None
Milestone: None
This can't be merged automatically, even if it could be merged you don't have the permission to do so.
This can be merged automatically but you don't have the permission to do so.
Commits (3)
1 participants
needsreview
    0deafa1501ec8dd687ee70f90488d592?s=40&d=identicon
    Show/hide discussion
    Ábner Oliveira started a discussion on commit 02837e31
    last updated by Michel Felipe
  • 0deafa1501ec8dd687ee70f90488d592?s=40&d=identicon
    Link here  
    Ábner Oliveira @abner (Edited )

    • I just think some error handling is missing.

    • We would just check for error in the controller call to the method ProposalTask #undo_flags

    • The method #undo_flag on ProposalTask isn't being used

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper (Edited )

    Hello @abner. I made this changes that you suggested. The method #undo_flag was renamed to undo_flags to remove flag of a specific proposal task or a array of tasks.

    So, you can use like this: ProposalDiscussionPlugin::ProposalTask.undo_flags() or task.undo_flags().

    The unit tests for both situations was changed/created.

    Please, verify if this feature it's ok now! :)

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Added 1 new commit:

    • 5666676a - Rafactor into undo_flags model and controller methods
    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Added 1 new commit:

    • 490cc715 - Refactory to restore finished proposal tasks, disabling associated proposal article
    Choose File ...   File name...
    Cancel