merge and small improvements on webpack.config.js

ABNER SILVA DE OLIVEIRA
1 parent d6dcf19b
Showing 3 changed files with 48 additions and 41 deletions Show diff stats
src/app/components/navbar/navbar.spec.ts
src/app/components/navbar/navbar.ts
webpack.config.js
@@ -13,34 +13,32 @@ describe(&quot;Navbar Component&quot;, () =&gt; {
         id: 1,
         login: "user"
     };
-    
+
     beforeEach(angular.mock.module("templates"));
-    
+
     // beforeEach(inject((_$rootScope_: ng.IRootScopeService) => {
     //     $rootScope = _$rootScope_;
     // }));
     it('should get the loggedIn user', (done: Function) => {
-      
-        
+
         let scope = jasmine.createSpyObj("scope", ["$on"]);
-        
+
         let providers = [
-            
-            
+
+
             new Provider('moment', { useValue: {} }),
             new Provider('$modal', { useValue: {} }),
             new Provider('AuthService', { useValue: {} }),
             new Provider('Session', { useValue: {
-                getCurrentUser: () => { return user}
+                currentUser: () => { return user; }
             } }),
             new Provider('$scope', { useValue: scope }),
             new Provider('$state', { useValue: {} }),
             new Provider('AUTH_EVENTS', { useValue: {AUTH_EVENTS} })
         ];
-        
-        
-        
+
+
         quickCreateComponent({
             providers: providers,
             template: "<acme-navbar></acme-navbar>",
@@ -50,7 +48,7 @@ describe(&quot;Navbar Component&quot;, () =&gt; {
             expect(navbarInstance).toBeDefined();
             expect(navbarInstance["currentUser"]).toEqual(user)
             done();
-        })
+        });
     });
 });
 \ No newline at end of file
@@ -26,7 +26,7 @@ export class Navbar {
         private AUTH_EVENTS: IAuthEvents
     ) {
-        this.currentUser = session.getCurrentUser();
+        this.currentUser = session.currentUser();
         $scope.$on(AUTH_EVENTS.loginSuccess, function() {
             if (this.modalInstance) {
@@ -38,7 +38,7 @@ export class Navbar {
         });
         $scope.$on(AUTH_EVENTS.logoutSuccess, () => {
-            this.currentUser = this.session.getCurrentUser();
+            this.currentUser = this.session.currentUser();
         });
     }
@@ -68,38 +68,47 @@ if (argv.production) {
     webpackConfig.module.loaders.push(uglifyLoaderConfig);
 }
+
+// if webpack executed with --test argument, this code bellow will add a post-compilation
+// code which will run the Tests + Coverage (npm run coverage)
 var testProcess = null;
 var child_process = require("child_process");
 var count = 0;
 var stdinPatched = false;
+
+
 if (argv.test) {
-    webpackConfig.plugins.push(
-        new WebpackOnBuildPlugin(function (stats) {
-            // webpack in watch mode call this twice for just one compilation
-            if (!stdinPatched) {
-                process.stdin.on('data', function (info) {
-                    if (info == '\n') {
-                        if (!testProcess) {
-                            testProcess = child_process.spawn("npm", ["run", "coverage"], { stdio: 'inherit' });
-                            testProcess.on('exit', function () { testProcess = null });
-                        }
-                    }
-                });
-                stdinPatched = true;
-            }
-            
-            // so, here we are checking if the process is still running before trigger another test execution
-            if (testProcess == null) {
-                console.log("Starting tests execution...");
-                testProcess = child_process.spawn("npm", ["run", "coverage"], { stdio: 'inherit' });
-
-                testProcess.on('exit', function () { testProcess = null });
-            } else {
-                console.log("Test still running... Sorry webpack!! :)");
-            }
-
-        })
-        );
+    function spawnChildProcessTest() {
+        if (!testProcess) {
+            testProcess = child_process.spawn("npm", ["run", "coverage"], { stdio: 'inherit' });
+            testProcess.on('exit', function () { testProcess = null });
+        }
+    }
+    // configure the webPackOnBuildPlugin with our post-compilation function as argument
+    var onBuildPluginConfigured = new WebpackOnBuildPlugin(function (stats) {
+
+        // here we are patching the stdin to allow trigger tests when pressing 'Enter'
+        // on terminal
+        if (!stdinPatched) {
+            process.stdin.on('data', function (info) {
+                if (info == '\n') {
+                    spawnChildProcessTest();
+                }
+            });
+            stdinPatched = true;
+        }
+        
+        // webpack in watch mode call this twice for just one compilation    
+        // so, here we are checking if the process is still running before trigger another test execution
+        if (testProcess == null) {
+            console.log("Starting tests execution...");
+            spawnChildProcessTest();
+        } else {
+            console.log("Test still running... Sorry webpack!! :)");
+        }
+
+    });
+    webpackConfig.plugins.push(onBuildPluginConfigured);
 }
 module.exports = webpackConfig;
	@@ -26,7 +26,7 @@ export class Navbar {		@@ -26,7 +26,7 @@ export class Navbar {
26	private AUTH_EVENTS: IAuthEvents	26	private AUTH_EVENTS: IAuthEvents
27	) {	27	) {
28		28
29	- this.currentUser = session.getCurrentUser();	29	+ this.currentUser = session.currentUser();
30		30
31	$scope.$on(AUTH_EVENTS.loginSuccess, function() {	31	$scope.$on(AUTH_EVENTS.loginSuccess, function() {
32	if (this.modalInstance) {	32	if (this.modalInstance) {
	@@ -38,7 +38,7 @@ export class Navbar {		@@ -38,7 +38,7 @@ export class Navbar {
38	});	38	});
39		39
40	$scope.$on(AUTH_EVENTS.logoutSuccess, () => {	40	$scope.$on(AUTH_EVENTS.logoutSuccess, () => {
41	- this.currentUser = this.session.getCurrentUser();	41	+ this.currentUser = this.session.currentUser();
42	});	42	});
43		43
44	}	44	}