Add tests for article editor

Victor Costa
1 parent 29d769ad
Showing 3 changed files with 38 additions and 9 deletions Show diff stats
src/app/article/cms/article-editor/article-editor.component.spec.ts
src/app/article/cms/article-editor/article-editor.component.ts
src/spec/component-test-helper.ts
@@ -0,0 +1,28 @@
+import {ArticleEditorComponent} from './article-editor.component';
+import {BasicEditorComponent} from "../basic-editor/basic-editor.component";
+import {ComponentTestHelper, createClass} from '../../../../spec/component-test-helper';
+import * as helpers from "../../../../spec/helpers";
+
+const htmlTemplate: string = '<article-editor [article]="ctrl.article"></article-editor>';
+
+describe("Components", () => {
+    describe("Article Editor Component", () => {
+
+        let helper: ComponentTestHelper<ArticleEditorComponent>;
+        beforeEach(angular.mock.module("templates"));
+
+        beforeEach((done) => {
+            let properties = { article: { type: "TextArticle" } };
+            let cls = createClass({
+                template: htmlTemplate,
+                directives: [ArticleEditorComponent, BasicEditorComponent],
+                properties: properties
+            });
+            helper = new ComponentTestHelper<ArticleEditorComponent>(cls, done);
+        });
+
+        it("replace element with article basic editor when type is TextArticle", () => {
+            expect(helper.find("article-basic-editor").length).toEqual(1);
+        });
+    });
+});
@@ -16,10 +16,10 @@ export class ArticleEditorComponent {
         private $compile: ng.ICompileService) { }
     ngOnInit() {
-        let articleType = this.article.type.replace(/::/, '');
+        let articleType = this.article && this.article.type ? this.article.type.replace(/::/, '') : "TextArticle";
         let specificDirective = `${articleType.charAt(0).toLowerCase()}${articleType.substring(1)}Editor`;
         let directiveName = "article-basic-editor";
-        if (this.$injector.has(specificDirective + 'Directive')) {
+        if (specificDirective !== "articleEditor" && this.$injector.has(specificDirective + 'Directive')) {
             directiveName = specificDirective.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase();
         }
         this.$element.replaceWith(this.$compile('<' + directiveName + ' [article]="ctrl.article"></' + directiveName + '>')(this.$scope));
@@ -88,10 +88,11 @@ export class ComponentTestHelper&lt;T extends any&gt; {
             this.debugElement = fixture.debugElement;
             this.component = <T>this.debugElement.componentViewChildren[0].componentInstance;
             let mockObj = new this.mockComponent();
-            Object.keys(mockObj).forEach((key: any) => {
-                (<any>this.component)[key] = <any>mockObj[key];
-            });
-
+            if (this.component) {
+                Object.keys(mockObj).forEach((key: any) => {
+                    (<any>this.component)[key] = <any>mockObj[key];
+                });
+            }
         }).then(() => {
             // Force the resolution of components and sync
             done();
@@ -99,9 +100,9 @@ export class ComponentTestHelper&lt;T extends any&gt; {
     }
     changeProperties(properties: any) {
-      Object.keys(properties).forEach((key: any) => {
-          this.component[key] = properties[key];
-      });
+        Object.keys(properties).forEach((key: any) => {
+            this.component[key] = properties[key];
+        });
     }
     /**
@@ -0,0 +1,28 @@		@@ -0,0 +1,28 @@
	1	+import {ArticleEditorComponent} from './article-editor.component';
	2	+import {BasicEditorComponent} from "../basic-editor/basic-editor.component";
	3	+import {ComponentTestHelper, createClass} from '../../../../spec/component-test-helper';
	4	+import * as helpers from "../../../../spec/helpers";
	5	+
	6	+const htmlTemplate: string = '<article-editor [article]="ctrl.article"></article-editor>';
	7	+
	8	+describe("Components", () => {
	9	+ describe("Article Editor Component", () => {
	10	+
	11	+ let helper: ComponentTestHelper<ArticleEditorComponent>;
	12	+ beforeEach(angular.mock.module("templates"));
	13	+
	14	+ beforeEach((done) => {
	15	+ let properties = { article: { type: "TextArticle" } };
	16	+ let cls = createClass({
	17	+ template: htmlTemplate,
	18	+ directives: [ArticleEditorComponent, BasicEditorComponent],
	19	+ properties: properties
	20	+ });
	21	+ helper = new ComponentTestHelper<ArticleEditorComponent>(cls, done);
	22	+ });
	23	+
	24	+ it("replace element with article basic editor when type is TextArticle", () => {
	25	+ expect(helper.find("article-basic-editor").length).toEqual(1);
	26	+ });
	27	+ });
	28	+});
	@@ -16,10 +16,10 @@ export class ArticleEditorComponent {		@@ -16,10 +16,10 @@ export class ArticleEditorComponent {
16	private $compile: ng.ICompileService) { }	16	private $compile: ng.ICompileService) { }
17		17
18	ngOnInit() {	18	ngOnInit() {
19	- let articleType = this.article.type.replace(/::/, '');	19	+ let articleType = this.article && this.article.type ? this.article.type.replace(/::/, '') : "TextArticle";
20	let specificDirective = `${articleType.charAt(0).toLowerCase()}${articleType.substring(1)}Editor`;	20	let specificDirective = `${articleType.charAt(0).toLowerCase()}${articleType.substring(1)}Editor`;
21	let directiveName = "article-basic-editor";	21	let directiveName = "article-basic-editor";
22	- if (this.$injector.has(specificDirective + 'Directive')) {	22	+ if (specificDirective !== "articleEditor" && this.$injector.has(specificDirective + 'Directive')) {
23	directiveName = specificDirective.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase();	23	directiveName = specificDirective.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase();
24	}	24	}
25	this.$element.replaceWith(this.$compile('<' + directiveName + ' [article]="ctrl.article"></' + directiveName + '>')(this.$scope));	25	this.$element.replaceWith(this.$compile('<' + directiveName + ' [article]="ctrl.article"></' + directiveName + '>')(this.$scope));