Merge Request #38

← To merge requests From login_modal_improve into master
Merged
noosfero-themes/angular-theme!38
Created by Daniela Feitosa

Login modal and block improvements

  • Renamed labels and inputs from login form on login block and modal
  • Added css rules that increased margin and padding on specific elements, horizontal rules with text in the middle and new translations.
  • Also added checkbox for keep logged in.
Assignee: Michel Felipe
Milestone: None

Merged by Caio Almeida

Commits (3)
4 participants
  • 0743c2eb05e68c92baa5f8c498995a20?s=40&d=identicon
    Link here  
    Daniela Feitosa @daniela

    mentioned in issue #46

    Choose File ...   File name...
    Cancel
  • Fcd7708520a028e7cdb9f57fcc5e438e?s=40&d=identicon
    Link here  
    Caio Almeida @caiosba

    Looks good! Unfortunately, I don't have enough permissions to merge it.

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Reassigned to @mfdeveloper

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    No problem @caiosba . I will validated this MR and release a merge if everything is ok :)

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    mentioned in issue #46

    Choose File ...   File name...
    Cancel
  • 5bf9bf341e9d00ebd854cdaf1a4299b2?s=40&d=identicon
    Link here  
    Leandro Santos @leandronunes

    @caiosba Now you have the permission

    Choose File ...   File name...
    Cancel
    • Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/app/layout/blocks/login-block/login-block.html
    15 15 <div class="logged-user-info" ng-show="!ctrl.currentUser">
    16 16 <form>
    17 17 <div class="form-group">
    18   - <label for="exampleInputEmail1">{{"auth.form.login" | translate}}</label>
    19   - <input type="text" class="form-control" id="exampleInputEmail1" placeholder="Login / Email" ng-model="ctrl.credentials.username">
      18 + <label for="email">{{"auth.form.login" | translate}}</label>
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Why did you repeat the same value to label tag and placeholder attribute of the input?

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Daniela Feitosa
    src/app/login/login.html
    7   - <label for="exampleInputEmail1">{{"auth.form.login" | translate}}</label>
    8   - <input type="text" class="form-control" id="exampleInputEmail1" placeholder="Login / Email" ng-model="vm.credentials.username">
      7 + <label for="email">{{"auth.form.login" | translate}}</label>
      8 + <input type="text" class="form-control" id="email" placeholder="{{'auth.form.login' | translate}}" ng-model="vm.credentials.username">
    9 9 </div>
    10 10 <div class="form-group">
    11   - <label for="exampleInputPassword1">{{"auth.form.password" | translate}}</label>
    12   - <input type="password" class="form-control" id="exampleInputPassword1" placeholder="Password" ng-model="vm.credentials.password">
      11 + <label for="passwd">{{"auth.form.password" | translate}}</label>
      12 + <input type="password" class="form-control" id="passwd" placeholder="{{'auth.form.password' | translate}}" ng-model="vm.credentials.password">
    13 13 </div>
    14   - <button type="submit" class="btn btn-default" ng-click="vm.login()">{{"auth.form.login_button" | translate}}</button>
      14 + <div class="form-inline">
      15 + <div class="checkbox">
      16 + <label>
      17 + <input type="checkbox" > {{"auth.form.keepLoggedIn" | translate}}
    2
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Why "Keep logged in" checkbox was not added to login-block.html like in this file? Do you have some special reason ?

      Choose File ...   File name...
      Cancel
    • 0743c2eb05e68c92baa5f8c498995a20?s=40&d=identicon
      Link here  
      Daniela Feitosa @daniela

      No special reason.. I just forgot :)

      I'll add it there

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/login/login.scss 0 → 100644
      1 +.modal-content{
      2 + padding: 40px;
      3 +}
      4 +.modal-header {
      5 + border-bottom: 0;
      6 + text-align: center;
      7 +}
      8 +form {
      9 + margin-bottom: 30px;
      10 +}
      11 +form button {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Please, move the button selector like a child of form selector. This is a sass feature. See a code snippet below:

      form {
   margin-bottom: 30px;

   button {
       margin-top: 20px;
       text-transform: uppercase;
   }
}
      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/login/login.scss 0 → 100644
      8 +form {
      9 + margin-bottom: 30px;
      10 +}
      11 +form button {
      12 + margin-top: 20px;
      13 + text-transform: uppercase;
      14 +}
      15 +.strike {
      16 + display: block;
      17 + text-align: center;
      18 + overflow: hidden;
      19 + white-space: nowrap;
      20 + padding: 25px 0;
      21 +}
      22 +
      23 +.strike > span {
    1
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/login/login.scss 0 → 100644
      23 +.strike > span {
      24 + position: relative;
      25 + display: inline-block;
      26 +}
      27 +
      28 +.strike > span:before,
      29 +.strike > span:after {
      30 + content: "";
      31 + position: absolute;
      32 + top: 50%;
      33 + width: 9999px;
      34 + height: 1px;
      35 + background: black;
      36 +}
      37 +
      38 +.strike > span:before {
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper (Edited )

      Seems like a unecessary duplicated use of the .strike > span:before here. Please, see the sass documentation of @extend. Maybe this can be more clear :)

      PS: A similar situation for .strike > span:after at line 43

      Choose File ...   File name...
      Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper (Edited )

    Visual suggestion:

    More clean login, without <label> tags, inputs with icons aligned to left and blue highlited border, like this screen below:

    Choose File ...   File name...
    Cancel
    Login inputs1
    login-inputs1.png
    • Me
    Show/hide discussion
    Michel Felipe started a discussion on the diff
    last updated by Michel Felipe
    src/languages/en.json
    20 20 "activities.create_article.description": "has published on",
    21 21 "activities.add_member_in_community.description": "has joined the community",
    22 22 "activities.new_friendship.description": "has made {friends, plural, one{one new friend} other{# new friends}}:",
    23   - "auth.title": "Login",
    24   - "auth.form.login": "Login / Email address",
      23 + "auth.title": "Great to have you back!",
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      When the user access the app by first time, he will see "back"? Maybe this text will confuse him. What do you think about this?

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/login/login.scss 0 → 100644
      25 + display: inline-block;
      26 +}
      27 +
      28 +.strike > span:before,
      29 +.strike > span:after {
      30 + content: "";
      31 + position: absolute;
      32 + top: 50%;
      33 + width: 9999px;
      34 + height: 1px;
      35 + background: black;
      36 +}
      37 +
      38 +.strike > span:before {
      39 + right: 100%;
      40 + margin-right: 15px;
    1
    • Me
      Link here  
      Michel Felipe @mfdeveloper

      The 15px value is used more than once. Maybe for a better approach, use a variable with this value, something like: $login-margin on top of this file or into the variable.scss general file.

      Choose File ...   File name...
      Cancel
    Me
    Show/hide discussion
    Michel Felipe started a discussion on the outdated diff
    last updated by Michel Felipe
    src/app/login/login.html
    5 5 <form>
    6 6 <div class="form-group">
    7   - <label for="exampleInputEmail1">{{"auth.form.login" | translate}}</label>
    8   - <input type="text" class="form-control" id="exampleInputEmail1" placeholder="Login / Email" ng-model="vm.credentials.username">
      7 + <label for="email">{{"auth.form.login" | translate}}</label>
      8 + <input type="text" class="form-control" id="email" placeholder="{{'auth.form.login' | translate}}" ng-model="vm.credentials.username">
    9 9 </div>
    10 10 <div class="form-group">
    11   - <label for="exampleInputPassword1">{{"auth.form.password" | translate}}</label>
    12   - <input type="password" class="form-control" id="exampleInputPassword1" placeholder="Password" ng-model="vm.credentials.password">
      11 + <label for="passwd">{{"auth.form.password" | translate}}</label>
      12 + <input type="password" class="form-control" id="passwd" placeholder="{{'auth.form.password' | translate}}" ng-model="vm.credentials.password">
    13 13 </div>
    14   - <button type="submit" class="btn btn-default" ng-click="vm.login()">{{"auth.form.login_button" | translate}}</button>
      14 + <div class="form-inline">
      15 + <div class="checkbox">
    1
  • 0743c2eb05e68c92baa5f8c498995a20?s=40&d=identicon
    Link here  
    Daniela Feitosa @daniela

    @mfdeveloper I'll see the visual suggestions, edit the scss files and ping you when I update the MR.

    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper

    Added 34 new commits:

    • da20ce18 - fixed search tests
    • 69ff070c - Component to search for articles in the environment
    • 5bc45a30 - fixed pt translation
    • 575daccf - changed search.component and the search-form.component to fill the query field w…
    • d0fa7823 - Merge branch 'search' into 'master'
    • 7057a9e1 - initial commit for the design mode feature
    • 46f6b264 - Merge branch 'master' into design-mode
    • bbeb5848 - changing designModeToggler to use toggle-switch angular directive
    • b9f6daf6 - better css definition to the design toggler. increased the test coverage to the …
    • 139f17f3 - added a toolbar under the navbar to add layout change buttons
    • a8b16135 - Fix application startup process
    • f4964918 - merge with master. fixed toolbar background-color. small fixes on BootstrapSwitcherItem
    • 9d2ce382 - Merge branch 'design-mode' into 'master'
    • 3963f52f - Rename BlockComponent to BlockContentComponent
    • 167edf00 - Add components to edit block settings
    • 62f85230 - Move logic that show/hide blocks to block component
    • 6e7c76e6 - Get available languages from translator service in block edition
    • 0e0b4a70 - Fix style of edition buttons for blocks
    • 0c28a983 - Merge branch 'edit-blocks'
    • b7f58749 - Merge branch 'master' of softwarepublico.gov.br:noosfero-themes/angular-theme
    • 18b99fd3 - Enable block edition when toggle design mode
    • 2ea040a4 - Enable header and footer edition when toggle design mode
    • 906a13d3 - Small fix in block style
    • dc8c43fd - adding KNOWN ISSUES section to README.md
    • 6a66f44b - Merge branch 'master' of softwarepublico.gov.br:noosfero-themes/angular-theme
    • d00c6e8c - Added export comments button on comment paragraph plugin
    • ba519042 - Display button to export comments only to users with permission to edit article
    • 36e4d9d9 - Merge branch 'export-comments' into 'master'
    • f276722d - New npm config 'skin' to allow sass by theme skins
    • 04a99db3 - Merge branch 'theme-skin-yellow'
    • 12da3fdc - fix invisible block title
    • 2c6cca64 - Merge branch 'fix-invisible-block-title'
    • 49a048fb - Improvements to login modal
    • e3d50634 - New 'checkbox-nice' form UI
    Choose File ...   File name...
    Cancel
  • Me
    Link here  
    Michel Felipe @mfdeveloper (Edited )

    Awesome @daniela ! I pushed a update with a new checkbox style. On the last commit, I'm using the skin scheme and sass @mixin feature. Please, check this :)

    Choose File ...   File name...
    Cancel
  • Fcd7708520a028e7cdb9f57fcc5e438e?s=40&d=identicon
    Link here  
    Caio Almeida @caiosba

    I can review that, @daniela - just ping me when it's updated.

    Choose File ...   File name...
    Cancel
  • 0743c2eb05e68c92baa5f8c498995a20?s=40&d=identicon
    Link here  
    Daniela Feitosa @daniela

    Added 8 new commits:

    • 2841288e - Ticket #85: Fields of Interest block
    • fa8a58b8 - Fix design mode for blocks
    • 2484eb92 - Merge branch 'master' of softwarepublico.gov.br:noosfero-themes/angular-theme
    • 6c67e997 - Fix responsive style of boxes
    • ae05af8e - Fixing conflict
    • 34620a12 - Improvements to login modal
    • e8a886be - New 'checkbox-nice' form UI
    • 738b0244 - Add "Keep logged in" on login block
    Choose File ...   File name...
    Cancel
  • Fcd7708520a028e7cdb9f57fcc5e438e?s=40&d=identicon
    Link here  
    Caio Almeida @caiosba

    mentioned in commit f75c68d0d61523573ff871a3300568a988bab186

    Choose File ...   File name...
    Cancel