Merge Request #4
-
Milestone changed to 2016.04
-
Added 1 new commit:
- 8202814b - Refactor comments component to permit extensions
-
Added 1 new commit:
- 06a2fc8d - Translate success message of post comment
-
Added 10 new commits:
- 556724ef - Fixed home link
- f0b9c7a0 - Display replies of comments
- 8b4048cc - Improve layout of post comment component
- 20a7654b - Toggle reply form when clicked from comment component
- 734399ac - Sort comments by creation date
- b4c8800b - Fix layout of comments replies
- cb5558ce - Add pagination button for comment listing
- 3e93892b - Hide more comments button when there is no more pages to load
- de7418b4 - Refactor comments component to permit extensions
- 95a63439 - Translate success message of post comment
-
Added 13 new commits:
- efa64a13 - Fix helpers.ts type problems and added conditional to show profile custom-fields table
- 6d10324a - People block refactoring. Created component-test-helper
- 458f2ccd - Review Modifications
- 7bab2b41 - Merge branch 'people-block' into 'master'
- 986f9d29 - Display replies of comments
- 89d0707b - Improve layout of post comment component
- 50ef7e70 - Toggle reply form when clicked from comment component
- d78752ef - Sort comments by creation date
- db57fad4 - Fix layout of comments replies
- 34b31510 - Add pagination button for comment listing
- 07583059 - Hide more comments button when there is no more pages to load
- 37a2a450 - Refactor comments component to permit extensions
- 5d2ebeec - Translate success message of post comment
-
I would like to deliver some feedback about the comment system implemented:
1 - The "More" button is showing even when there isn't more comments avaiable;
2 - I think would be better minimize the identation to represent replies, maybe to just one level and use some text+icon to represent the comment is a reply. I think the comments would have anchors and so the reply text+icon would link to the comment it's replying.
3 - I realy liked the Post Comment Button Animation. :D
-
Looks like there is some problem here because this button is showing even when there is more comments avaialble.
-
I'll be fixed with https://gitlab.com/noosfero/noosfero/merge_requests/854
-
I liked the animation here. But maybe would be better provide this animation at the default theme instead. Would be hard to override this on themes.
-
Added 16 new commits:
- 5c75ac60 - Adding a Vagrantfile
- 697684e6 - fix date format for general locales
- 50d18589 - change README install instructions
- dce2b87d - Cleaning up unneeded files
- f9896e22 - Refactoring build task
- d80617bf - Update README.md with new build instructions
- a5c48faf - Merge branch 'dev-fixes' into 'master'
- a944f06a - Display replies of comments
- 4b876c39 - Improve layout of post comment component
- 2ebd4ad0 - Toggle reply form when clicked from comment component
- 6911e123 - Sort comments by creation date
- 1d6363e0 - Fix layout of comments replies
- 6e2ef9ed - Add pagination button for comment listing
- 16b1a6fa - Hide more comments button when there is no more pages to load
- d247ad88 - Refactor comments component to permit extensions
- 845f879b - Translate success message of post comment
-
Added 1 new commit:
- 6061cf6e - Refactor post comment event to use EventEmitter
-
Assignee removed
-
o commit 00882cc3edbc26721fd392b5a314c0a24bee977a não apareceu aqui no MergeRequest
| 1 | 1 | <div class="comments"> |
| 2 | - <noosfero-post-comment [article]="ctrl.article"></noosfero-post-comment> | |
| 2 | + <noosfero-post-comment ng-if="ctrl.showForm" [article]="ctrl.article" [parent]="ctrl.parent"></noosfero-post-comment> | |
| 3 | 3 | |
| 4 | 4 | <div class="comments-list"> |
| 5 | - <noosfero-comment ng-repeat="comment in ctrl.comments" [comment]="comment" [article]="ctrl.article"></noosfero-comment> | |
| 5 | + <noosfero-comment ng-repeat="comment in ctrl.comments | orderBy: 'created_at':true" [comment]="comment" [article]="ctrl.article"></noosfero-comment> | |
| 6 | 6 | </div> |
| 7 | + <button type="button" ng-if="ctrl.displayMore()" class="more-comments btn btn-default btn-block" ng-click="ctrl.loadNextPage()">{{"comment.pagination.more" | translate}}</button> | |
| 2 |
|
|
| 1 | +.comments { | |
| 2 | + .post-comment { | |
| 3 | + .media { | |
| 4 | + border-top: 2px solid #F3F3F3; | |
| 5 | + padding-top: 10px; | |
| 6 | + .media-left { | |
| 7 | + padding: 10px 0; | |
| 8 | + } | |
| 9 | + button { | |
| 1 |
|
|