noosfero-themes / angular-theme

0 up

0 down

← To merge requests From skin-check into master

Merged

noosfero-themes/angular-theme!43

Created by

Michel Felipe 2016-06-20 20:09:24 UTC

This changes closes #81, #96 issues.

Added skin folder structure and a verify whether the .scss file exists. Added a verify to the theme folder.

Now, when the theme or skin configured with npm config not exists, a exception is displayed in your terminal.

The screen below shows a example:

skin-error

Commits (3)

2 participants

Evandro Junior started a discussion on commit 3a1d52ef

README.md

62	64	}
63	65	```
64	66	- Configure application to use the new theme, e.g.:
65		-`npm config set angular-theme:skin custom-skin`
	67	+`npm config set angular-theme:skin skin-myscustom`
2		Link here Evandro Junior @evandrojr 2016-06-27 21:10:57 UTC (Edited 2016-06-28 13:06:24 UTC ) is "skin-myscustom" misspelled? Write Preview is "_skin-myscustom_" misspelled? Choose File ... File name... Cancel Link here Michel Felipe @mfdeveloper 2016-06-28 13:15:50 UTC Done :) Write Preview Done :) Choose File ... File name... Cancel

Evandro Junior started a discussion on commit 3a1d52ef

README.md

62	64	}
63	65	```
64	66	- Configure application to use the new theme, e.g.:
65		-`npm config set angular-theme:skin custom-skin`
	67	+`npm config set angular-theme:skin skin-myscustom`
66	68
67	69	- Start the application with `npm start` scripts ou make a build
	70	+ > PS: If the configured skin is invalid, a error message is showed in the terminal.
1		Link here Evandro Junior @evandrojr 2016-06-27 21:14:40 UTC Fix language to: an error message Write Preview Fix language to: an error message Choose File ... File name... Cancel

Evandro Junior started a discussion on commit 3a1d52ef

gulp/conf.js

	42	+* Check if skin file exists on "{theme}/app/layout/skins" directory
	43	+*
	44	+* @param skin The skin name passed by arg to gulp task
	45	+*/
	46	+exports.skinExists = function (skin) {
	47	+ var skinFile = skin+'.scss';
	48	+ if(/skin-/.test(skin)){
	49	+ skinFile = skin.replace('skin-','_')+'.scss';
	50	+ }
	51	+
	52	+ var skinPath = path.join(exports.paths.themes, exports.paths.theme, '/app/layout/skins/', skinFile);
	53	+
	54	+ try {
	55	+ fs.statSync(skinPath);
	56	+ }catch(e) {
	57	+ throw new Error('The skin "'+skin+'" on path "'+skinPath+'" was not found');
1		Link here Evandro Junior @evandrojr 2016-06-27 21:36:23 UTC IMHO this sounds better: throw new Error('The skin "'+skin+'" was not found in "'+skinPath+'"'); Write Preview IMHO this sounds better: throw new Error('The skin "'+skin+'" was not found in "'+skinPath+'"'); Choose File ... File name... Cancel

Software Público Brasileiro